commit ee09075c0e930756e5ad390fc9250bd5d1ffea52
author Duong Nguyen <duongnt.is@gmail.com> Wed Apr 17 10:10:13 2024 -0700
committer GitHub <noreply@github.com> Wed Apr 17 10:10:13 2024 -0700
tree c26683158d1946b426a7bb800dd74e7ae0840fd5
parent cf9d2292a9f53792a7765da41e3b4b903c0ec1d9

RATIS-2059. Missing reference count when putting log entries to cache on follower. (#1067)

ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/SegmentedRaftLog.java

diff --git a/ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/SegmentedRaftLog.java b/ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/SegmentedRaftLog.java
index 7f9ef30..a3c18f0 100644
--- a/ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/SegmentedRaftLog.java
+++ b/ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/SegmentedRaftLog.java
@@ -457,7 +457,7 @@
       // to statemachine first and then to the cache. Not following the order
       // will leave a spurious entry in the cache.
       final Task write = fileLogWorker.writeLogEntry(entryRef, removedStateMachineData, context);
-      if (stateMachineCachingEnabled) {
+      if (stateMachineCachingEnabled && (removedStateMachineData != entry)) {
         // The stateMachineData will be cached inside the StateMachine itself.
         cache.appendEntry(LogSegment.Op.WRITE_CACHE_WITH_STATE_MACHINE_CACHE,
             ReferenceCountedObject.wrap(removedStateMachineData));