commit be497d5c472038242f8493ef5e56b56b7ce69ef1
author Potato <tanxinyu@apache.org> Sat Mar 23 00:58:31 2024 +0800
committer GitHub <noreply@github.com> Fri Mar 22 09:58:31 2024 -0700
tree 71806ae5ccaf7bb88a94004758dd722dc981c82f
parent c3d615b4f28b92e1d271b84752f1c9b0fc23341c

RATIS-2048. Fix SimpleStateMachineStorage potential NPE exception (#1056)

ratis-server/src/main/java/org/apache/ratis/statemachine/impl/SimpleStateMachineStorage.java

diff --git a/ratis-server/src/main/java/org/apache/ratis/statemachine/impl/SimpleStateMachineStorage.java b/ratis-server/src/main/java/org/apache/ratis/statemachine/impl/SimpleStateMachineStorage.java
index 37e94a8..88cc57d 100644
--- a/ratis-server/src/main/java/org/apache/ratis/statemachine/impl/SimpleStateMachineStorage.java
+++ b/ratis-server/src/main/java/org/apache/ratis/statemachine/impl/SimpleStateMachineStorage.java
@@ -116,7 +116,7 @@
 
     final List<SingleFileSnapshotInfo> allSnapshotFiles = getSingleFileSnapshotInfos(stateMachineDir.toPath());
 
-    if (allSnapshotFiles.size() > snapshotRetentionPolicy.getNumSnapshotsRetained()) {
+    if (allSnapshotFiles.size() > numSnapshotsRetained) {
       allSnapshotFiles.sort(Comparator.comparing(SingleFileSnapshotInfo::getIndex).reversed());
       allSnapshotFiles.subList(numSnapshotsRetained, allSnapshotFiles.size())
           .stream()