RATIS-2109. RaftLogBase#updateCommitIndex should return true only if commitIndex is increased (#1109)
diff --git a/ratis-server/src/main/java/org/apache/ratis/server/raftlog/RaftLogBase.java b/ratis-server/src/main/java/org/apache/ratis/server/raftlog/RaftLogBase.java
index 064e509..4dd9fc1 100644
--- a/ratis-server/src/main/java/org/apache/ratis/server/raftlog/RaftLogBase.java
+++ b/ratis-server/src/main/java/org/apache/ratis/server/raftlog/RaftLogBase.java
@@ -127,15 +127,13 @@
final long newCommitIndex = Math.min(majorityIndex, getFlushIndex());
if (oldCommittedIndex < newCommitIndex) {
if (!isLeader) {
- commitIndex.updateIncreasingly(newCommitIndex, traceIndexChange);
- return true;
+ return commitIndex.updateIncreasingly(newCommitIndex, traceIndexChange);
}
// Only update last committed index for current term. See §5.4.2 in paper for details.
final TermIndex entry = getTermIndex(newCommitIndex);
if (entry != null && entry.getTerm() == currentTerm) {
- commitIndex.updateIncreasingly(newCommitIndex, traceIndexChange);
- return true;
+ return commitIndex.updateIncreasingly(newCommitIndex, traceIndexChange);
}
}
}
