RATIS-1648. Fix EI_EXPOSE_REP in MD5Hash. (#992)
diff --git a/ratis-common/src/main/java/org/apache/ratis/io/MD5Hash.java b/ratis-common/src/main/java/org/apache/ratis/io/MD5Hash.java
index 76be2d5..e60bef9 100644
--- a/ratis-common/src/main/java/org/apache/ratis/io/MD5Hash.java
+++ b/ratis-common/src/main/java/org/apache/ratis/io/MD5Hash.java
@@ -18,8 +18,6 @@
package org.apache.ratis.io;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
-
import java.io.DataInput;
import java.io.DataOutput;
import java.io.IOException;
@@ -53,12 +51,11 @@
}
/** Constructs an MD5Hash with a specified value. */
- @SuppressFBWarnings("EI_EXPOSE_REP2")
public MD5Hash(byte[] digest) {
if (digest.length != MD5_LEN) {
throw new IllegalArgumentException("Wrong length: " + digest.length);
}
- this.digest = digest;
+ this.digest = digest.clone();
}
public void readFields(DataInput in) throws IOException {
@@ -82,9 +79,8 @@
}
/** Returns the digest bytes. */
- @SuppressFBWarnings("EI_EXPOSE_REP")
public byte[] getDigest() {
- return digest;
+ return digest.clone();
}
/** Construct a hash value for a byte array. */