commit 256fc2a511d0cb201d1c1a6821a1a47d21fd92e1
author huangzhaobo <huangzhaobo99@126.com> Tue Jan 09 10:18:26 2024 +0800
committer GitHub <noreply@github.com> Mon Jan 08 18:18:26 2024 -0800
tree fc8b206702937b2910deab9d0f14127925759852
parent c2dacbd013a96a8cfb23e60dc09373fe0e32a28c

RATIS-1991. Optimize the reconfig judgment logic in the ReconfigurationBase class. (#1004)

ratis-common/src/main/java/org/apache/ratis/conf/ReconfigurationBase.java

diff --git a/ratis-common/src/main/java/org/apache/ratis/conf/ReconfigurationBase.java b/ratis-common/src/main/java/org/apache/ratis/conf/ReconfigurationBase.java
index 6d4930e..8123e24 100644
--- a/ratis-common/src/main/java/org/apache/ratis/conf/ReconfigurationBase.java
+++ b/ratis-common/src/main/java/org/apache/ratis/conf/ReconfigurationBase.java
@@ -172,7 +172,7 @@
     }
     final String effective = reconfigureProperty(property, newValue);
     LOG.info("{}: changed property {} to {} (effective {})", name, property, newValue, effective);
-    if (newValue != null) {
+    if (effective != null) {
       properties.set(property, effective);
     } else {
       properties.unset(property);