[fix][client] Fix breaking changes for the deprecated methods of TopicMessageIdImpl (#20163)
(cherry picked from commit 6036dcce8d48f8e1ae311153eeb625f51c5aa827)
diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/TopicMessageIdImpl.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/TopicMessageIdImpl.java
index 00fe12b..3dc9b23 100644
--- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/TopicMessageIdImpl.java
+++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/TopicMessageIdImpl.java
@@ -62,7 +62,7 @@
@Deprecated
public MessageId getInnerMessageId() {
- return new MessageIdImpl(getLedgerId(), getEntryId(), getPartitionIndex());
+ return msgId;
}
@Override
diff --git a/pulsar-client/src/test/java/org/apache/pulsar/client/impl/TopicMessageIdImplTest.java b/pulsar-client/src/test/java/org/apache/pulsar/client/impl/TopicMessageIdImplTest.java
index daf49f0..1ddd47a 100644
--- a/pulsar-client/src/test/java/org/apache/pulsar/client/impl/TopicMessageIdImplTest.java
+++ b/pulsar-client/src/test/java/org/apache/pulsar/client/impl/TopicMessageIdImplTest.java
@@ -20,6 +20,7 @@
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertNotEquals;
+import static org.testng.Assert.assertSame;
import org.testng.annotations.Test;
@@ -54,4 +55,12 @@
assertNotEquals(topicMsgId1, topicMsgId2);
}
+ @Test
+ public void testDeprecatedMethods() {
+ BatchMessageIdImpl msgId = new BatchMessageIdImpl(1, 2, 3, 4);
+ TopicMessageIdImpl topicMsgId = new TopicMessageIdImpl("topic-partition-0", "topic", msgId);
+ assertSame(topicMsgId.getInnerMessageId(), msgId);
+ assertEquals(topicMsgId.getTopicPartitionName(), topicMsgId.getOwnerTopic());
+ assertEquals(topicMsgId.getTopicName(), "topic");
+ }
}
