commit 7b1eaf62ddbd432367bd6601a3593df7c33d7bf6
author lee_chrisbell <lee.chrisbell@gmail.com> Wed Sep 02 09:32:33 2020 -0400
committer GitHub <noreply@github.com> Wed Sep 02 15:32:33 2020 +0200
tree f0dcd385647104b873a92a6f049cb2d50abb0d68
parent ac1e228a47bd0c8d45a3314b5cca6f67aa3772e5

Eat errors in SetupChannel (#52)

* SetupChannel needs to eat its errors.  Callers cannot catch exceptions from async void methods.

* PR suggestions.

Co-authored-by: Christopher Bell <christopher.bell@stretto.com>

src/DotPulsar/Internal/ConsumerProcess.cs

diff --git a/src/DotPulsar/Internal/ConsumerProcess.cs b/src/DotPulsar/Internal/ConsumerProcess.cs
index 449aedb..a078146 100644
--- a/src/DotPulsar/Internal/ConsumerProcess.cs
+++ b/src/DotPulsar/Internal/ConsumerProcess.cs
@@ -84,8 +84,15 @@
 
         private async void SetupChannel()
         {
-            var channel = await _factory.Create(CancellationTokenSource.Token).ConfigureAwait(false);
-            await _consumer.SetChannel(channel).ConfigureAwait(false);
+            try
+            {
+                var channel = await _factory.Create(CancellationTokenSource.Token).ConfigureAwait(false);
+                await _consumer.SetChannel(channel).ConfigureAwait(false);
+            }
+            catch
+            {
+                // ignored
+            }
         }
     }
 }

src/DotPulsar/Internal/ProducerProcess.cs

diff --git a/src/DotPulsar/Internal/ProducerProcess.cs b/src/DotPulsar/Internal/ProducerProcess.cs
index fad638a..81861e3 100644
--- a/src/DotPulsar/Internal/ProducerProcess.cs
+++ b/src/DotPulsar/Internal/ProducerProcess.cs
@@ -68,8 +68,15 @@
 
         private async void SetupChannel()
         {
-            var channel = await _factory.Create(CancellationTokenSource.Token).ConfigureAwait(false);
-            await _producer.SetChannel(channel).ConfigureAwait(false);
+            try
+            {
+                var channel = await _factory.Create(CancellationTokenSource.Token).ConfigureAwait(false);
+                await _producer.SetChannel(channel).ConfigureAwait(false);
+            }
+            catch
+            {
+                // ignored
+            }
         }
     }
 }

src/DotPulsar/Internal/ReaderProcess.cs

diff --git a/src/DotPulsar/Internal/ReaderProcess.cs b/src/DotPulsar/Internal/ReaderProcess.cs
index 9b9a438..67763c5 100644
--- a/src/DotPulsar/Internal/ReaderProcess.cs
+++ b/src/DotPulsar/Internal/ReaderProcess.cs
@@ -71,8 +71,15 @@
 
         private async void SetupChannel()
         {
-            var channel = await _factory.Create(CancellationTokenSource.Token).ConfigureAwait(false);
-            await _reader.SetChannel(channel).ConfigureAwait(false);
+            try
+            {
+                var channel = await _factory.Create(CancellationTokenSource.Token).ConfigureAwait(false);
+                await _reader.SetChannel(channel).ConfigureAwait(false);
+            }
+            catch
+            {
+                // ignored
+            }
         }
     }
 }