fix test errors
diff --git a/pulsar/message.go b/pulsar/message.go index 4131726..fc5f038 100644 --- a/pulsar/message.go +++ b/pulsar/message.go
@@ -18,11 +18,12 @@ package pulsar import ( - "github.com/pkg/errors" "math" "strconv" "strings" "time" + + "github.com/pkg/errors" ) // ProducerMessage abstraction used in Pulsar producer @@ -134,8 +135,8 @@ return deserializeMessageID(data) } -func MessageIDFromParts(ledgerId, entryId int64, batchIdx, partitionIdx int32) MessageID { - return newMessageID(ledgerId, entryId, batchIdx, partitionIdx) +func MessageIDFromParts(ledgerID, entryID int64, batchIdx, partitionIdx int32) MessageID { + return newMessageID(ledgerID, entryID, batchIdx, partitionIdx) } func MessageIDFromString(str string) (MessageID, error) { @@ -146,12 +147,12 @@ return nil, errors.Errorf("invalid message id string. %s", str) } - ledgerId, err := strconv.ParseInt(s[0], 10, 64) + ledgerID, err := strconv.ParseInt(s[0], 10, 64) if err != nil { return nil, errors.Errorf("invalid ledger id. %s", str) } - entryId, err := strconv.ParseInt(s[1], 10, 64) + entryID, err := strconv.ParseInt(s[1], 10, 64) if err != nil { return nil, errors.Errorf("invalid entry id. %s", str) } @@ -173,7 +174,7 @@ } batchIdx = int32(bi) } - return newMessageID(ledgerId, entryId, batchIdx, partitionIdx), nil + return newMessageID(ledgerID, entryID, batchIdx, partitionIdx), nil } // EarliestMessageID returns a messageID that points to the earliest message available in a topic
diff --git a/pulsar/message_test.go b/pulsar/message_test.go index 1467a23..14d7d83 100644 --- a/pulsar/message_test.go +++ b/pulsar/message_test.go
@@ -2,21 +2,22 @@ import ( "github.com/stretchr/testify/assert" + "testing" ) func TestMessageIDFromString(t *testing.T) { id, err := MessageIDFromString("1:2") assert.Nil(t, err) - assert.True(t, id.Equals(MessageIDFromParts(1, 2, -1, -1))) + assert.True(t, id.Equals(MessageIDFromParts(1, 2, -1, -1))) id, err = MessageIDFromString("1:2:3") assert.Nil(t, err) - assert.True(t, id.Equals(MessageIDFromParts(1, 2, -1, 3))) + assert.True(t, id.Equals(MessageIDFromParts(1, 2, -1, 3))) id, err = MessageIDFromString("1:2:3:4") assert.Nil(t, err) - assert.True(t, id.Equals(MessageIDFromParts(1, 2, 4, 3))) + assert.True(t, id.Equals(MessageIDFromParts(1, 2, 4, 3))) } func TestMessageIDFromStringErrors(t *testing.T) {