PHOENIX-3826 Improve logging when HConnection is established(Loknath Priyatham Teja Singamsetty)
diff --git a/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java b/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
index 14e31d2..76f6393 100644
--- a/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
+++ b/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
@@ -223,6 +223,7 @@
import org.apache.phoenix.util.Closeables;
import org.apache.phoenix.util.ConfigUtil;
import org.apache.phoenix.util.JDBCUtil;
+import org.apache.phoenix.util.LogUtil;
import org.apache.phoenix.util.MetaDataUtil;
import org.apache.phoenix.util.PhoenixContextExecutor;
import org.apache.phoenix.util.PhoenixRuntime;
@@ -431,7 +432,7 @@
QueryServicesOptions.DEFAULT_TRANSACTIONS_ENABLED);
this.connection = HBaseFactoryProvider.getHConnectionFactory().createConnection(this.config);
GLOBAL_HCONNECTIONS_COUNTER.increment();
- logger.info("HConnnection established. Details: " + connection + " " + Throwables.getStackTraceAsString(new Exception()));
+ logger.info("HConnection established. Stacktrace for informational purposes: " + connection + " " + LogUtil.getCallerStackTrace());
// only initialize the tx service client if needed and if we succeeded in getting a connection
// to HBase
if (transactionsEnabled) {
@@ -2398,7 +2399,7 @@
boolean success = false;
try {
GLOBAL_QUERY_SERVICES_COUNTER.increment();
- logger.info("An instance of ConnectionQueryServices was created: " + Throwables.getStackTraceAsString(new Exception()));
+ logger.info("An instance of ConnectionQueryServices was created.");
openConnection();
hConnectionEstablished = true;
boolean isDoNotUpgradePropSet = UpgradeUtil.isNoUpgradeSet(props);
diff --git a/phoenix-core/src/main/java/org/apache/phoenix/util/LogUtil.java b/phoenix-core/src/main/java/org/apache/phoenix/util/LogUtil.java
index 21dec13..7ebdbb4 100644
--- a/phoenix-core/src/main/java/org/apache/phoenix/util/LogUtil.java
+++ b/phoenix-core/src/main/java/org/apache/phoenix/util/LogUtil.java
@@ -50,4 +50,14 @@
return con.getCustomTracingAnnotations().toString();
}
}
+
+ public static String getCallerStackTrace() {
+ StackTraceElement[] st = Thread.currentThread().getStackTrace();
+ StringBuilder sb = new StringBuilder();
+ for (StackTraceElement element : st) {
+ sb.append(element.toString());
+ sb.append("\n");
+ }
+ return sb.toString();
+ }
}
