commit ac5bd8247f6adf8a674a52938c172ab72d1450b2
author Philipp Hoch <p.hoch@celonis.com> Thu Jun 28 11:23:24 2018 -0400
committer Deepak Majeti <deepak.majeti@hpe.com> Thu Jun 28 11:23:24 2018 -0400
tree 7bbd2fe85e77561a7ff1e68aeb6651a95e43d8eb
parent be4c532139e9542fd42c4a65dc7928c512023582

PARQUET-1334: [C++] memory_map parameter seems missleading in parquet file opener

If memory_map parameter is true, normal file operation is executed, while in negative case, the according memory mapped file operation happens. Seems either be used via inverted logic or being bug.

Author: Philipp Hoch <p.hoch@celonis.com>

Closes #471 from philhoch/bugfix-mixed-up-memory-map-parameter and squashes the following commits:

651cf6b [Philipp Hoch] switched logic within conditional to support memory mapped behavior if requested and readable file accordingly

src/parquet/file_reader.cc

diff --git a/src/parquet/file_reader.cc b/src/parquet/file_reader.cc
index 0632872..ae1c0a7 100644
--- a/src/parquet/file_reader.cc
+++ b/src/parquet/file_reader.cc
@@ -273,15 +273,15 @@
     const std::shared_ptr<FileMetaData>& metadata) {
   std::shared_ptr<::arrow::io::ReadableFileInterface> source;
   if (memory_map) {
-    std::shared_ptr<::arrow::io::ReadableFile> handle;
-    PARQUET_THROW_NOT_OK(
-        ::arrow::io::ReadableFile::Open(path, props.memory_pool(), &handle));
-    source = handle;
-  } else {
     std::shared_ptr<::arrow::io::MemoryMappedFile> handle;
     PARQUET_THROW_NOT_OK(
         ::arrow::io::MemoryMappedFile::Open(path, ::arrow::io::FileMode::READ, &handle));
     source = handle;
+  } else {
+    std::shared_ptr<::arrow::io::ReadableFile> handle;
+    PARQUET_THROW_NOT_OK(
+        ::arrow::io::ReadableFile::Open(path, props.memory_pool(), &handle));
+    source = handle;
   }
 
   return Open(source, props, metadata);