commit ef712b8eb808f918e94e541376f67ea4f91b19e9
author Alexander Klimetschek <aklimets@adobe.com> Mon Apr 13 18:49:30 2020 -0700
committer Alexander Klimetschek <alexander@klimetschek.de> Tue Apr 14 00:53:16 2020 -0700
tree 9b33f913fbd65163a1d6186841bd1ae28bf84977
parent 560f81d0ad70e1969bdc09c2bf0faec8ae37c243

performance: create backup action in parallel when debugger is already ready

saves many seconds on startup with larger actions

src/agentmgr.js

diff --git a/src/agentmgr.js b/src/agentmgr.js
index d862e05..452e49a 100644
--- a/src/agentmgr.js
+++ b/src/agentmgr.js
@@ -213,15 +213,18 @@
             console.log(`Installing agent in OpenWhisk (${agentName})...`);
         }
 
-        // create copy
-        await this.wsk.actions.update({
-            name: backupName,
-            action: agentAction
-        });
-        debug(`created action backup ${backupName}`);
+        // create copy in case wskdebug gets killed hard
+        // do async as this can be slow for larger actions and this is part of the critical startup path
+        this.createBackup = (async () => {
+            await this.wsk.actions.update({
+                name: backupName,
+                action: agentAction
+            });
+            debug(`created action backup ${backupName}`);
+        })();
 
         if (this.argv.verbose) {
-            console.log(`Original action backed up at ${backupName}.`);
+            console.log(`Original action will be backed up at ${backupName}.`);
         }
 
         if (this.argv.condition) {
@@ -255,6 +258,9 @@
 
     async shutdown() {
         try {
+            // make sure we finished creating the backup
+            await this.createBackup;
+
             if (this.agentInstalled) {
                 await this.restoreAction();
             }