commit 43aa42ccb533212db9acf1a238d24172b18dc513
author Mark Struberg <struberg@apache.org> Sat Feb 02 12:02:58 2019 +0100
committer Mark Struberg <struberg@apache.org> Sat Feb 02 12:02:58 2019 +0100
tree 5ed1ac5c9bd0271563be7ab5f2d8d783ef72ffca
parent 0cd523b1f564ec7d1c27de6e017423471f94b4af

OPENJPA-2771 fix h2 'unlimited' LIMIT case

With h2 one should omit the LIMIT section to get all results.
Our old LIMIT 0 did effectively prune the whole result list to zero entries.

openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/H2Dictionary.java

diff --git a/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/H2Dictionary.java b/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/H2Dictionary.java
index a6f1e79..925e2c9 100644
--- a/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/H2Dictionary.java
+++ b/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/H2Dictionary.java
@@ -225,8 +225,6 @@
         if (end != Long.MAX_VALUE)
             buf.append(" LIMIT ").appendValue(end - start);
         if (start != 0) {
-            if(end == Long.MAX_VALUE)
-                buf.append(" LIMIT 0");
             buf.append(" OFFSET ").appendValue(start);
         }
     }