commit a941f16db247d3988d6e94f4a9c8775ccb4f0884
author ramya vasanth <ramya.vasanth@sap.com> Thu May 23 14:20:54 2019 +0530
committer ramya vasanth <ramya.vasanth@sap.com> Thu May 23 14:20:54 2019 +0530
tree 8c7d439b454cc4bf755940f96f179cbb39d4b088
parent 5245762de3d300e548c41f1ddb5ff57127075957

[OLINGO-1322]An empty string validation in UriParser

odata2-lib/odata-core/src/main/java/org/apache/olingo/odata2/core/uri/UriParserImpl.java

diff --git a/odata2-lib/odata-core/src/main/java/org/apache/olingo/odata2/core/uri/UriParserImpl.java b/odata2-lib/odata-core/src/main/java/org/apache/olingo/odata2/core/uri/UriParserImpl.java
index 3a31ad7..a49e7c1 100644
--- a/odata2-lib/odata-core/src/main/java/org/apache/olingo/odata2/core/uri/UriParserImpl.java
+++ b/odata2-lib/odata-core/src/main/java/org/apache/olingo/odata2/core/uri/UriParserImpl.java
@@ -469,10 +469,6 @@
         }
       }
       
-      if("''".equals(value) || value==null){
-        throw new UriSyntaxException(UriSyntaxException.INVALIDVALUE.addContent(value));
-      }
-
       EdmProperty keyProperty = null;
       for (final EdmProperty testKeyProperty : keyProperties) {
         if (testKeyProperty.getName().equals(name)) {

odata2-lib/odata-core/src/test/java/org/apache/olingo/odata2/core/uri/UriParserTest.java

diff --git a/odata2-lib/odata-core/src/test/java/org/apache/olingo/odata2/core/uri/UriParserTest.java b/odata2-lib/odata-core/src/test/java/org/apache/olingo/odata2/core/uri/UriParserTest.java
index 51a2669..5896cfe 100644
--- a/odata2-lib/odata-core/src/test/java/org/apache/olingo/odata2/core/uri/UriParserTest.java
+++ b/odata2-lib/odata-core/src/test/java/org/apache/olingo/odata2/core/uri/UriParserTest.java
@@ -256,11 +256,6 @@
   }
   
   @Test
-  public void parseEmployeesEntityWithEmptyKey() throws Exception {
-    parseWrongUri("/Employees('')", UriSyntaxException.INVALIDVALUE.addContent("''"));
-  }
-  
-  @Test
   public void parseEmployeesEntityWithNullKey() throws Exception {
     parseWrongUri("/Employees(null)", UriSyntaxException.INCOMPATIBLELITERAL);
   }