Improved: Document the rounting number fields in entities
(OFBIZ-7725)
Initially Swapnil Shah proposed to add a branchCode field in EftAccount and
Check entities. Pierre mentioned that branchCode is actually the same than the
existing rountingNumber field there.
This adds a description for the rountingNumber field (also in PayrollPreference
in humares) with a link to https://en.wikipedia.org/wiki/Bank_code
where this field is explained for many countries.
As suggested by Paul Foxworthy I added the Bank-State-Branch label for
Australia. You might want to check the translation for you country or add it
Finally I removed the FormFieldTitle_routingNumber in in humanres, it's not used
anywhere and at least the French translation was wrong. Better to stick to
AccountingRoutingNumber
Thanks: Swapnil, Pierre and Paul for the helpful discussion
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1770345 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/applications/datamodel/entitydef/accounting-entitymodel.xml b/applications/datamodel/entitydef/accounting-entitymodel.xml
index c9e4ab8..997d6a3 100644
--- a/applications/datamodel/entitydef/accounting-entitymodel.xml
+++ b/applications/datamodel/entitydef/accounting-entitymodel.xml
@@ -2799,7 +2799,7 @@
title="EFT Account Information Entity">
<field name="paymentMethodId" type="id-ne"></field>
<field name="bankName" type="name"></field>
- <field name="routingNumber" type="short-varchar"></field>
+ <field name="routingNumber" type="short-varchar"><description>See https://en.wikipedia.org/wiki/Bank_code </description></field>
<field name="accountType" type="short-varchar"></field>
<field name="accountNumber" type="long-varchar"></field>
<field name="nameOnAccount" type="name"></field>
@@ -2823,7 +2823,7 @@
title="Check Information Entity">
<field name="paymentMethodId" type="id-ne"></field>
<field name="bankName" type="name"></field>
- <field name="routingNumber" type="short-varchar"></field>
+ <field name="routingNumber" type="short-varchar"><description>See https://en.wikipedia.org/wiki/Bank_code </description></field>
<field name="accountType" type="short-varchar"></field>
<field name="accountNumber" type="long-varchar"></field>
<field name="nameOnAccount" type="name"></field>
@@ -3300,7 +3300,7 @@
<alias entity-alias="PM" name="fromDate"/>
<alias entity-alias="PM" name="thruDate"/>
<alias entity-alias="EA" name="bankName"/>
- <alias entity-alias="EA" name="routingNumber"/><!-- also used for IBAN number -->
+ <alias entity-alias="EA" name="routingNumber"/><!-- also used for IBAN number, see https://en.wikipedia.org/wiki/Bank_code -->
<alias entity-alias="EA" name="accountType"/>
<alias entity-alias="EA" name="accountNumber"/>
<alias entity-alias="EA" name="nameOnAccount"/>
diff --git a/applications/datamodel/entitydef/humanres-entitymodel.xml b/applications/datamodel/entitydef/humanres-entitymodel.xml
index 39df07d..45cb0f7 100644
--- a/applications/datamodel/entitydef/humanres-entitymodel.xml
+++ b/applications/datamodel/entitydef/humanres-entitymodel.xml
@@ -570,7 +570,7 @@
<field name="thruDate" type="date-time"></field>
<field name="percentage" type="floating-point"></field>
<field name="flatAmount" type="currency-amount"></field>
- <field name="routingNumber" type="short-varchar"></field>
+ <field name="routingNumber" type="short-varchar"><description>See https://en.wikipedia.org/wiki/Bank_code </description></field>
<field name="accountNumber" type="short-varchar"></field>
<field name="bankName" type="name"></field>
<prim-key field="partyId"/>
diff --git a/applications/humanres/config/HumanResUiLabels.xml b/applications/humanres/config/HumanResUiLabels.xml
index 25b70b7..0d4ef59 100644
--- a/applications/humanres/config/HumanResUiLabels.xml
+++ b/applications/humanres/config/HumanResUiLabels.xml
@@ -694,17 +694,6 @@
<value xml:lang="zh">简历正文</value>
<value xml:lang="zh-TW">簡歷正文</value>
</property>
- <property key="FormFieldTitle_routingNumber">
- <value xml:lang="en">Routing Number</value>
- <value xml:lang="fr">N° de routage</value>
- <value xml:lang="it">Numero Routing</value>
- <value xml:lang="ja">ルーティング番号</value>
- <value xml:lang="pt-BR">Número de rota</value>
- <value xml:lang="th">หมายเลข Routing</value>
- <value xml:lang="vi">Số phân công</value>
- <value xml:lang="zh">汇款路线码</value>
- <value xml:lang="zh-TW">匯款路線碼</value>
- </property>
<property key="FormFieldTitle_salary">
<value xml:lang="en">Salary</value>
<value xml:lang="it">Salario</value>
