Maven's analyze task should fail on warnings by default.
diff --git a/cmdline/maven/src/main/java/org/netbeans/modules/jackpot30/maven/Utils.java b/cmdline/maven/src/main/java/org/netbeans/modules/jackpot30/maven/Utils.java
index 3fd1b65..8310a22 100644
--- a/cmdline/maven/src/main/java/org/netbeans/modules/jackpot30/maven/Utils.java
+++ b/cmdline/maven/src/main/java/org/netbeans/modules/jackpot30/maven/Utils.java
@@ -71,7 +71,7 @@
}
}
- return false;
+ return true;
}
private static Xpp3Dom getJackpotPluginConfiguration(MavenProject project) {
diff --git a/cmdline/maven/tests/fail-on-warnings/pom.xml b/cmdline/maven/tests/fail-on-warnings/pom.xml
index c4536a7..0dadded 100644
--- a/cmdline/maven/tests/fail-on-warnings/pom.xml
+++ b/cmdline/maven/tests/fail-on-warnings/pom.xml
@@ -47,7 +47,6 @@
<version>${jackpot.plugin.version}</version>
<configuration>
<configurationFile>jackpot-settings.xml</configurationFile>
- <failOnWarnings>true</failOnWarnings>
</configuration>
</plugin>
<plugin>
diff --git a/cmdline/maven/tests/fail-on-warnings2/golden b/cmdline/maven/tests/fail-on-warnings2/golden
new file mode 100644
index 0000000..bea3cf1
--- /dev/null
+++ b/cmdline/maven/tests/fail-on-warnings2/golden
@@ -0,0 +1,12 @@
+${basedir}/src/main/java/test/App.java:24: warning: [Convert_to_Lambda_or_Member_Reference] This anonymous inner class creation can be turned into a lambda expression.
+ Runnable r = new Runnable() { public void run() { } };
+ ^
+[ERROR] Failed to execute goal org.apache.netbeans.modules.jackpot30:jackpot30-maven-plugin:13.0:analyze (default-cli) on project maven-test: jackpo30 failed. -> [Help 1]
+[ERROR]
+[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
+[ERROR] Re-run Maven using the -X switch to enable full debug logging.
+[ERROR]
+[ERROR] For more information about the errors and possible solutions, please read the following articles:
+[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
+
+result: 1
\ No newline at end of file
diff --git a/cmdline/maven/tests/fail-on-warnings2/jackpot-settings.xml b/cmdline/maven/tests/fail-on-warnings2/jackpot-settings.xml
new file mode 100644
index 0000000..0461d8a
--- /dev/null
+++ b/cmdline/maven/tests/fail-on-warnings2/jackpot-settings.xml
@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<!DOCTYPE configuration PUBLIC "-//NetBeans//DTD Tool Configuration 1.0//EN" "http://www.netbeans.org/dtds/ToolConfiguration-1_0.dtd">
+<configuration>
+ <tool kind="hints" type="text/x-java">
+ <node name="Javac_canUseLambda">
+ <attribute name="enabled" value="true"/>
+ </node>
+ <node name="org.netbeans.modules.java.hints.AddOverrideAnnotation">
+ <attribute name="enabled" value="false"/>
+ </node>
+ </tool>
+</configuration>
diff --git a/cmdline/maven/tests/fail-on-warnings2/pom.xml b/cmdline/maven/tests/fail-on-warnings2/pom.xml
new file mode 100644
index 0000000..0dadded
--- /dev/null
+++ b/cmdline/maven/tests/fail-on-warnings2/pom.xml
@@ -0,0 +1,63 @@
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.netbeans.modules.jackpot30</groupId>
+ <artifactId>maven-test</artifactId>
+ <version>1.0-SNAPSHOT</version>
+ <packaging>jar</packaging>
+
+ <name>jackpot30-maven-plugin-test1</name>
+ <url>http://maven.apache.org</url>
+
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>3.8.1</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.netbeans.modules.jackpot30</groupId>
+ <artifactId>jackpot30-maven-plugin</artifactId>
+ <version>${jackpot.plugin.version}</version>
+ <configuration>
+ <configurationFile>jackpot-settings.xml</configurationFile>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <version>2.3.2</version>
+ <configuration>
+ <source>17</source>
+ <target>17</target>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+</project>
diff --git a/cmdline/maven/tests/fail-on-warnings2/src/main/java/test/App.java b/cmdline/maven/tests/fail-on-warnings2/src/main/java/test/App.java
new file mode 100644
index 0000000..37f42dc
--- /dev/null
+++ b/cmdline/maven/tests/fail-on-warnings2/src/main/java/test/App.java
@@ -0,0 +1,27 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package test;
+
+public class App {
+
+ public static void main( String[] args ) {
+ Runnable r = new Runnable() { public void run() { } };
+ r.run();
+ }
+}
diff --git a/cmdline/maven/tests/sl-17/pom.xml b/cmdline/maven/tests/sl-17/pom.xml
index 0dadded..19c02d8 100644
--- a/cmdline/maven/tests/sl-17/pom.xml
+++ b/cmdline/maven/tests/sl-17/pom.xml
@@ -47,6 +47,7 @@
<version>${jackpot.plugin.version}</version>
<configuration>
<configurationFile>jackpot-settings.xml</configurationFile>
+ <failOnWarnings>false</failOnWarnings>
</configuration>
</plugin>
<plugin>
diff --git a/cmdline/maven/tests/sl-1_18/pom.xml b/cmdline/maven/tests/sl-1_18/pom.xml
index d080ea1..d84744b 100644
--- a/cmdline/maven/tests/sl-1_18/pom.xml
+++ b/cmdline/maven/tests/sl-1_18/pom.xml
@@ -47,6 +47,7 @@
<version>${jackpot.plugin.version}</version>
<configuration>
<configurationFile>jackpot-settings.xml</configurationFile>
+ <failOnWarnings>false</failOnWarnings>
</configuration>
</plugin>
<plugin>
diff --git a/cmdline/maven/tests/sl-failure/pom.xml b/cmdline/maven/tests/sl-failure/pom.xml
index c73ba01..c86f184 100644
--- a/cmdline/maven/tests/sl-failure/pom.xml
+++ b/cmdline/maven/tests/sl-failure/pom.xml
@@ -47,6 +47,7 @@
<version>${jackpot.plugin.version}</version>
<configuration>
<configurationFile>jackpot-settings.xml</configurationFile>
+ <failOnWarnings>false</failOnWarnings>
</configuration>
</plugin>
<plugin>
diff --git a/cmdline/maven/tests/test-custom/pom.xml b/cmdline/maven/tests/test-custom/pom.xml
index f263af8..79afff6 100644
--- a/cmdline/maven/tests/test-custom/pom.xml
+++ b/cmdline/maven/tests/test-custom/pom.xml
@@ -45,6 +45,9 @@
<groupId>org.apache.netbeans.modules.jackpot30</groupId>
<artifactId>jackpot30-maven-plugin</artifactId>
<version>${jackpot.plugin.version}</version>
+ <configuration>
+ <failOnWarnings>false</failOnWarnings>
+ </configuration>
</plugin>
</plugins>
</build>
diff --git a/cmdline/maven/tests/test1/pom.xml b/cmdline/maven/tests/test1/pom.xml
index 87b4c1b..fa4a70f 100644
--- a/cmdline/maven/tests/test1/pom.xml
+++ b/cmdline/maven/tests/test1/pom.xml
@@ -47,6 +47,7 @@
<version>${jackpot.plugin.version}</version>
<configuration>
<configurationFile>jackpot-settings.xml</configurationFile>
+ <failOnWarnings>false</failOnWarnings>
</configuration>
</plugin>
</plugins>
