commit faaa8e821a53bbf483f151e996eb4bbb21467b60
author Mariusz Skamra <mariusz.skamra@codecoup.pl> Fri Jan 19 14:24:43 2024 +0100
committer Łukasz Rymanowski <lukasz.rymanowski@codecoup.pl> Tue Feb 27 09:43:43 2024 +0100
tree b49567762ef5bc3ceb78fb768fad5a1983dd9ee6
parent 894a8f497abf305c146662bc6deb6a64d5eeb403

nimble/iso: Fix missing BIG NULL pointer checks

The BIG lookup function returns NULL if BIG has not been found, thus to
be safe the return value has to be checked in case functions are called
with big_handle value of non-existent BIG.

nimble/host/src/ble_iso.c

diff --git a/nimble/host/src/ble_iso.c b/nimble/host/src/ble_iso.c
index 5ca94e5..5c79783 100644
--- a/nimble/host/src/ble_iso.c
+++ b/nimble/host/src/ble_iso.c
@@ -29,6 +29,7 @@
 #include "host/ble_iso.h"
 #include "nimble/hci_common.h"
 #include "sys/queue.h"
+#include "ble_hs_priv.h"
 #include "ble_hs_hci_priv.h"
 
 struct ble_iso_big {
@@ -213,6 +214,10 @@
     int i;
 
     big = ble_iso_big_find_by_handle(ev->big_handle);
+    if (big == NULL) {
+        BLE_HS_LOG_ERROR("No BIG with handle=%d\n", ev->big_handle);
+        return;
+    }
 
     big->num_bis = ev->num_bis;
 
@@ -250,6 +255,10 @@
     struct ble_iso_big *big;
 
     big = ble_iso_big_find_by_handle(ev->big_handle);
+    if (big == NULL) {
+        BLE_HS_LOG_ERROR("No BIG with handle=%d\n", ev->big_handle);
+        return;
+    }
 
     event.type = BLE_ISO_EVENT_BIG_TERMINATE_COMPLETE;
     event.big_terminated.big_handle = ev->big_handle;