commit a6e47b687bf316a2bfd456a455ca904a9903884d
author Szymon Janc <szymon.janc@codecoup.pl> Fri Mar 15 10:45:45 2024 +0100
committer Szymon Janc <szymon.janc@codecoup.pl> Thu Mar 21 08:52:42 2024 +0100
tree 33a7664b195a8f71ebd807dcd56342e22230a8ce
parent a41b4570d6f22636ec65bbb94907bf5861765673

nimble/host: Fix leak on EATT connection

If EATT COC connection failed we need to clean up allocated memory.

nimble/host/src/ble_eatt.c

diff --git a/nimble/host/src/ble_eatt.c b/nimble/host/src/ble_eatt.c
index 2ef62a8..93ff0f5 100644
--- a/nimble/host/src/ble_eatt.c
+++ b/nimble/host/src/ble_eatt.c
@@ -320,6 +320,7 @@
 {
     struct ble_eatt *eatt;
     struct os_mbuf *om;
+    int rc;
 
     eatt = ble_npl_event_get_arg(ev);
     assert(eatt);
@@ -332,8 +333,16 @@
     }
 
     BLE_EATT_LOG_DEBUG("eatt: connecting eatt on conn_handle 0x%04x\n", eatt->conn_handle);
-    ble_l2cap_enhanced_connect(eatt->conn_handle, BLE_EATT_PSM,
-                               MYNEWT_VAL(BLE_EATT_MTU), 1, &om, ble_eatt_l2cap_event_fn, eatt);
+
+    rc = ble_l2cap_enhanced_connect(eatt->conn_handle, BLE_EATT_PSM,
+                                    MYNEWT_VAL(BLE_EATT_MTU), 1, &om,
+                                    ble_eatt_l2cap_event_fn, eatt);
+    if (rc) {
+        BLE_EATT_LOG_ERROR("eatt: Failed to connect EATT on conn_handle 0x%04x (status=%d)\n",
+                            eatt->conn_handle, rc);
+        os_mbuf_free_chain(om);
+        ble_eatt_free(eatt);
+    }
 }
 
 static int