nimble/ll: Reschedule preempted adv event if possible
Currently we simply drop adv event if it was preempted, but instead we
can try to reschedule it as longs as new start time does not exceed
adv_delay limit.
Note that we only reschedule if no PDU was sent in that event, otherwise
we could not guarantee that aux is properly scheduled relative to exts.
diff --git a/nimble/controller/include/controller/ble_ll_adv.h b/nimble/controller/include/controller/ble_ll_adv.h
index b861d19..db35209 100644
--- a/nimble/controller/include/controller/ble_ll_adv.h
+++ b/nimble/controller/include/controller/ble_ll_adv.h
@@ -168,7 +168,7 @@
* Called when an advertising event has been removed from the scheduler
* without being run.
*/
-void ble_ll_adv_event_rmvd_from_sched(struct ble_ll_adv_sm *advsm);
+void ble_ll_adv_preempted(struct ble_ll_adv_sm *advsm);
/*
* Called when a periodic event has been removed from the scheduler
diff --git a/nimble/controller/src/ble_ll_adv.c b/nimble/controller/src/ble_ll_adv.c
index 52606f9..8dc4444 100644
--- a/nimble/controller/src/ble_ll_adv.c
+++ b/nimble/controller/src/ble_ll_adv.c
@@ -110,6 +110,7 @@
uint8_t own_addr_type;
uint8_t peer_addr_type;
uint8_t adv_chan;
+ uint8_t retry_event;
uint8_t adv_pdu_len;
int8_t adv_rpa_index;
int8_t tx_power;
@@ -227,7 +228,7 @@
struct ble_ll_adv_sm g_ble_ll_adv_sm[BLE_ADV_INSTANCES];
struct ble_ll_adv_sm *g_ble_ll_cur_adv_sm;
-static void ble_ll_adv_drop_event(struct ble_ll_adv_sm *advsm);
+static void ble_ll_adv_drop_event(struct ble_ll_adv_sm *advsm, bool preempted);
static struct ble_ll_adv_sm *
ble_ll_adv_sm_find_configured(uint8_t instance)
@@ -1068,14 +1069,10 @@
g_ble_ll_cur_adv_sm = NULL;
}
-/*
- * Called when an advertising event has been removed from the scheduler
- * without being run.
- */
void
-ble_ll_adv_event_rmvd_from_sched(struct ble_ll_adv_sm *advsm)
+ble_ll_adv_preempted(struct ble_ll_adv_sm *advsm)
{
- ble_ll_adv_drop_event(advsm);
+ ble_ll_adv_drop_event(advsm, 1);
}
#if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_PERIODIC_ADV)
@@ -4742,8 +4739,10 @@
}
static void
-ble_ll_adv_drop_event(struct ble_ll_adv_sm *advsm)
+ble_ll_adv_drop_event(struct ble_ll_adv_sm *advsm, bool preempted)
{
+ os_sr_t sr;
+
STATS_INC(ble_ll_stats, adv_drop_event);
ble_ll_sched_rmv_elem(&advsm->adv_sch);
@@ -4755,6 +4754,12 @@
advsm->aux_active = 0;
#endif
+ if (preempted) {
+ OS_ENTER_CRITICAL(sr);
+ advsm->retry_event = !(advsm->flags & BLE_LL_ADV_SM_FLAG_ACTIVE_CHANSET_MASK);
+ OS_EXIT_CRITICAL(sr);
+ }
+
advsm->adv_chan = ble_ll_adv_final_chan(advsm);
ble_ll_event_add(&advsm->adv_txdone_ev);
}
@@ -4779,7 +4784,7 @@
rc = ble_ll_sched_adv_reschedule(sch, max_delay_ticks);
if (rc) {
- ble_ll_adv_drop_event(advsm);
+ ble_ll_adv_drop_event(advsm, 0);
return;
}
@@ -4845,25 +4850,35 @@
final_adv_chan = ble_ll_adv_final_chan(advsm);
if (advsm->adv_chan == final_adv_chan) {
-#if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_EXT_ADV)
- if (advsm->events_max) {
- advsm->events++;
- }
-#endif
-
ble_ll_scan_chk_resume();
/* This event is over. Set adv channel to first one */
advsm->adv_chan = ble_ll_adv_first_chan(advsm);
- /*
- * Calculate start time of next advertising event. NOTE: we do not
- * add the random advDelay as the scheduling code will do that.
- */
itvl = advsm->adv_itvl_usecs;
tick_itvl = ble_ll_tmr_u2t(itvl);
- advsm->adv_event_start_time += tick_itvl;
- advsm->adv_pdu_start_time = advsm->adv_event_start_time;
+
+ /* do not calculate new event time if current event should be retried;
+ * this happens if event was preempted, so we just try to schedule one
+ * more time with the same start time
+ */
+
+ if (!advsm->retry_event) {
+#if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_EXT_ADV)
+ if (advsm->events_max) {
+ advsm->events++;
+ }
+#endif
+
+ /*
+ * Calculate start time of next advertising event. NOTE: we do not
+ * add the random advDelay as the scheduling code will do that.
+ */
+ advsm->adv_event_start_time += tick_itvl;
+ advsm->adv_pdu_start_time = advsm->adv_event_start_time;
+ } else {
+ advsm->retry_event = 0;
+ }
/*
* The scheduled time better be in the future! If it is not, we will
@@ -4909,7 +4924,7 @@
advsm->aux_active &&
LL_TMR_GT(advsm->adv_pdu_start_time,
AUX_CURRENT(advsm)->start_time)) {
- ble_ll_adv_drop_event(advsm);
+ ble_ll_adv_drop_event(advsm, 0);
return;
}
#endif
@@ -5009,7 +5024,7 @@
ble_ll_rfmgmt_release();
if (advsm->aux_dropped) {
- ble_ll_adv_drop_event(advsm);
+ ble_ll_adv_drop_event(advsm, 0);
return;
}
diff --git a/nimble/controller/src/ble_ll_sched.c b/nimble/controller/src/ble_ll_sched.c
index bfec620..f2987df 100644
--- a/nimble/controller/src/ble_ll_sched.c
+++ b/nimble/controller/src/ble_ll_sched.c
@@ -151,9 +151,9 @@
break;
#endif
#if MYNEWT_VAL(BLE_LL_ROLE_BROADCASTER)
- case BLE_LL_SCHED_TYPE_ADV:
- ble_ll_adv_event_rmvd_from_sched(entry->cb_arg);
- break;
+ case BLE_LL_SCHED_TYPE_ADV:
+ ble_ll_adv_preempted(entry->cb_arg);
+ break;
#endif
#if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_EXT_ADV) && MYNEWT_VAL(BLE_LL_ROLE_OBSERVER)
case BLE_LL_SCHED_TYPE_SCAN_AUX:
