Fix unitialized variable warning
Fix usage of prev when curr==group, and add checking for invalid
parameter.
Signed-off-by: Fabio Utzig <fabio.utzig@nordicsemi.no>
diff --git a/mgmt/src/mgmt.c b/mgmt/src/mgmt.c
index 77aa631..361211a 100644
--- a/mgmt/src/mgmt.c
+++ b/mgmt/src/mgmt.c
@@ -74,9 +74,13 @@
void
mgmt_unregister_group(struct mgmt_group *group)
{
- struct mgmt_group *curr = mgmt_group_list, *prev;
+ struct mgmt_group *curr = mgmt_group_list, *prev = NULL;
- if (curr && curr == group) {
+ if (!group) {
+ return;
+ }
+
+ if (curr == group) {
mgmt_group_list = curr->mg_next;
return;
}
@@ -86,7 +90,7 @@
curr = curr->mg_next;
}
- if (!curr) {
+ if (!prev || !curr) {
return;
}