commit 4b03911b3a64579f71c17f008582138c550c9ee5
author Szymon Janc <szymon.janc@codecoup.pl> Mon Jun 27 18:08:05 2022 +0200
committer Szymon Janc <szymon.janc@codecoup.pl> Fri Jul 01 10:47:39 2022 +0200
tree f9b57a5916433d3a76a3291c4bb6b619ba4422b8
parent a4dfaad8136c43e6b72c228535abf8fe644aab29

cmd/img_mgmt: Fix compilation with dummy hash enabled

Hash len is 32 bytes.

repos/apache-mynewt-mcumgr/cmd/img_mgmt/src/img_mgmt.c:
     In function ‘img_mgmt_read_info’:
repos/apache-mynewt-mcumgr/cmd/img_mgmt/src/img_mgmt.c:122:9:
     error: ‘memcpy’ reading 32 bytes from a region of size 16
     [-Werror=stringop-overread]
  122 |         memcpy(hash, dummy_hash, IMG_MGMT_HASH_LEN);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
repos/apache-mynewt-mcumgr/cmd/img_mgmt/src/img_mgmt.c:114:13:
     note: source object ‘dummy_hash’ of size 16
  114 |     uint8_t dummy_hash[] = {0x00, 0x11, 0x22, 0x33,
                                    0x44, 0x55, 0x66, 0x77,
      |             ^~~~~~~~~~
cc1: all warnings being treated as errors

cmd/img_mgmt/src/img_mgmt.c

diff --git a/cmd/img_mgmt/src/img_mgmt.c b/cmd/img_mgmt/src/img_mgmt.c
index 6e28906..d582dbd 100644
--- a/cmd/img_mgmt/src/img_mgmt.c
+++ b/cmd/img_mgmt/src/img_mgmt.c
@@ -112,6 +112,8 @@
 
 #if IMG_MGMT_DUMMY_HDR
     uint8_t dummy_hash[] = {0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77,
+                            0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77,
+                            0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77,
                             0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77};
 
     if (!hash && !ver && !flags) {