i2s: Assure open fails in case of driver error
When device is not configured correctly i2s_start for
I2S output device may fail.
i2s_start() returning I2S_ERR_NO_BUFFER is rather expected
while other errors may indicate some serious configuration
problem.
With this change failing i2s_start will stop user code form
openning device since it will probably not work anyway.
diff --git a/hw/drivers/i2s/src/i2s.c b/hw/drivers/i2s/src/i2s.c
index 7930c56..d8d9d83 100644
--- a/hw/drivers/i2s/src/i2s.c
+++ b/hw/drivers/i2s/src/i2s.c
@@ -32,6 +32,7 @@
struct i2s *i2s;
struct i2s_client *client = (struct i2s_client *)arg;
struct i2s_sample_buffer *buffer;
+ int rc;
if (dev->od_flags & OS_DEV_F_STATUS_OPEN) {
return OS_EBUSY;
@@ -52,7 +53,14 @@
i2s_buffer_put(i2s, buffer);
}
} else {
- i2s_start(i2s);
+ rc = i2s_start(i2s);
+ /*
+ * No buffers on opening output I2S stream is to be expected
+ * and is not error preventing device usage.
+ */
+ if (rc != OS_OK && rc != I2S_ERR_NO_BUFFER) {
+ return rc;
+ }
}
return OS_OK;
