commit 34e5adb009e652959c0e59e22d860ec212396779
author Szymon Janc <szymon.janc@codecoup.pl> Thu Jun 24 08:23:53 2021 +0200
committer Szymon Janc <szymon.janc@codecoup.pl> Fri Jun 25 12:32:49 2021 +0200
tree 593ebd07feaf22b9ad2a108b8a67685379fe9c09
parent 8c153b11290b752fdb95959b8eed48c2ce44b3e4

hw/ipc_nrf5340: Assert on ipc_nrf5340_recv if channel is already in use

Calling ipc_nrf5340_recv on channel which is already enabled is always
an application error which leads to confusing behaviour (or crashes).

If application want to change receive handler for specified channel it
shall first unregister old one by passing NULL pointer.

hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c

diff --git a/hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c b/hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c
index 786a85a..a44f267 100644
--- a/hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c
+++ b/hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c
@@ -249,6 +249,8 @@
     assert(channel < IPC_MAX_CHANS);
 
     if (cb) {
+        assert(ipcs[channel].cb == NULL);
+
         ipcs[channel].cb = cb;
         ipcs[channel].user_data = user_data;
         NRF_IPC->RECEIVE_CNF[channel] = (0x1UL << channel);