commit 77df54d311418b241fb2fb757e77a728e8c5c4e0
author Volker Weber <v.weber@inexso.de> Mon Aug 26 13:27:15 2019 +0200
committer Volker Weber <v.weber@inexso.de> Mon Aug 26 13:31:42 2019 +0200
tree 853b6da8465fc7777fa5b67886299c3c0df21c2e
parent 3e048e75ee931e5d3f83ce6b9d2bd6e3c53b46ee

TOBAGO-2003 - Tobago: Confirmation facet should not render if isRendered evals to false

tobago-core/src/main/java/org/apache/myfaces/tobago/util/ComponentUtils.java

diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/util/ComponentUtils.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/util/ComponentUtils.java
index 7588a8b..1f6dab4 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/util/ComponentUtils.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/util/ComponentUtils.java
@@ -925,10 +925,10 @@
       return confirmation;
     }
     final UIComponent facet = ComponentUtils.getFacet(component, Facets.confirmation);
-    if (facet instanceof ValueHolder) {
+    if (facet instanceof ValueHolder && ((UIComponent) facet).isRendered()) {
       final ValueHolder valueHolder = (ValueHolder) facet;
       return "" + valueHolder.getValue();
-    } else if (facet != null) {
+    } else if (facet != null && !(facet instanceof ValueHolder)) {
       LOG.warn("The content of a confirmation facet must be a ValueHolder. Use e. g. <tc:out>.");
     }
     return null;