Use String#isEmpty()
diff --git a/client/src/main/java/org/apache/ahc/auth/AuthChallengeParser.java b/client/src/main/java/org/apache/ahc/auth/AuthChallengeParser.java
index c3269d1..eb29bb2 100644
--- a/client/src/main/java/org/apache/ahc/auth/AuthChallengeParser.java
+++ b/client/src/main/java/org/apache/ahc/auth/AuthChallengeParser.java
@@ -51,7 +51,7 @@
} else {
s = challengeStr.substring(0, idx);
}
- if (s.equals("")) {
+ if (s.isEmpty()) {
throw new MalformedChallengeException("Invalid challenge: " + challengeStr);
}
return s.toLowerCase();
diff --git a/client/src/main/java/org/apache/ahc/auth/NTLM.java b/client/src/main/java/org/apache/ahc/auth/NTLM.java
index 893752e..dd93847 100644
--- a/client/src/main/java/org/apache/ahc/auth/NTLM.java
+++ b/client/src/main/java/org/apache/ahc/auth/NTLM.java
@@ -78,7 +78,7 @@
throws AuthenticationException {
final String response;
- if (message == null || message.trim().equals("")) {
+ if (message == null || message.trim().isEmpty()) {
response = getType1Message(host, domain);
} else {
response = getType3Message(username, password, host, domain,
diff --git a/client/src/main/java/org/apache/ahc/util/ParameterParser.java b/client/src/main/java/org/apache/ahc/util/ParameterParser.java
index 4d46ce0..aa716ae 100644
--- a/client/src/main/java/org/apache/ahc/util/ParameterParser.java
+++ b/client/src/main/java/org/apache/ahc/util/ParameterParser.java
@@ -219,7 +219,7 @@
if (hasChar() && (chars[pos] == separator)) {
pos++; // skip separator
}
- if (paramName != null && !(paramName.equals("") && paramValue == null)) {
+ if (paramName != null && !(paramName.isEmpty() && paramValue == null)) {
params.add(new NameValuePair(paramName, paramValue));
}
}
