commit fdeac61e7fac9f3975dff9d0524a67989e3b90fc
author Paul Brett <paul_b@twopensource.com> Tue Aug 18 13:05:28 2015 -0700
committer Benjamin Mahler <benjamin.mahler@gmail.com> Tue Aug 18 13:06:48 2015 -0700
tree cd8e75f44b7c4760a615484799c5b5de018e252f
parent 9f2386f1f22a8b7b6e716e7a42d7c23cd050be3e

Added a comment in Perf to explain kill correctness.

Review: https://reviews.apache.org/r/37424

src/linux/perf.cpp

diff --git a/src/linux/perf.cpp b/src/linux/perf.cpp
index cab6271..cdc5f83 100644
--- a/src/linux/perf.cpp
+++ b/src/linux/perf.cpp
@@ -193,7 +193,9 @@
 
   virtual void finalize()
   {
-    // Kill the perf process if it's still running.
+    // Kill the perf process (if it's still running) by sending
+    // SIGTERM to the signal handler which will then SIGKILL the
+    // perf process group created by setupChild.
     if (perf.isSome() && perf.get().status().isPending()) {
       kill(perf.get().pid(), SIGTERM);
     }