[MSHARED-562] applied updates proposed by Michael
git-svn-id: https://svn.apache.org/repos/asf/maven/shared/trunk@1753088 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/logging/MessageUtils.java b/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/logging/MessageUtils.java
index a315976..409f855 100644
--- a/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/logging/MessageUtils.java
+++ b/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/logging/MessageUtils.java
@@ -23,7 +23,7 @@
import org.fusesource.jansi.AnsiConsole;
/**
- * Colored message utils, to manage colors colors consistently across plugins (only if Maven version is at least 3.4.0).
+ * Colored message utils, to manage colors consistently across plugins (only if Maven version is at least 3.4.0).
* For Maven version before 3.4.0, message built with this util will never add color.
* <p>
* Internally, <a href="http://fusesource.github.io/jansi/">Jansi</a> is used to render
@@ -60,6 +60,11 @@
}
}
+ /**
+ * Undo a previous {@link #systemInstall()}. If {@link #systemInstall()} was called
+ * multiple times, {@link #systemUninstall()} must be called call the same number of times before
+ * it is actually uninstalled.
+ */
public static void systemUninstall()
{
if ( JANSI )
@@ -69,10 +74,10 @@
}
/**
- * Activates message color (if JAnsi is available).
+ * Enables message color (if JAnsi is available).
* @param flag
*/
- public static void setColor( boolean flag )
+ public static void setColorEnabled( boolean flag )
{
if ( JANSI )
{
@@ -81,9 +86,9 @@
}
/**
- * Is message color active: requires JAnsi available (through Maven) and the color has not been disabled.
+ * Is message color enabled: requires JAnsi available (through Maven) and the color has not been disabled.
*/
- public static boolean isColor()
+ public static boolean isColorEnabled()
{
return JANSI ? Ansi.isEnabled() : false;
}
@@ -116,11 +121,11 @@
}
/**
- * Remove any ANSI code from a message
+ * Remove any ANSI code from a message (colors or other escape sequences).
* @param msg message eventually containing ANSI codes
* @return the message with ANSI codes removed
*/
- public static String stripAnsi( String msg )
+ public static String stripAnsiCodes( String msg )
{
return msg.replaceAll( "\u001B\\[[;\\d]*[ -/]*[@-~]", "" );
}
diff --git a/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/logging/Style.java b/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/logging/Style.java
index 81b4d64..41ecc7f 100644
--- a/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/logging/Style.java
+++ b/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/logging/Style.java
@@ -144,7 +144,7 @@
{
return name();
}
- StringBuilder sb = new StringBuilder();
+ StringBuilder sb = new StringBuilder( name() + '=' );
if ( bold )
{
sb.append( "bold" );
@@ -174,7 +174,7 @@
}
sb.append( bgColor.name() );
}
- return name() + '=' + sb;
+ return sb.toString();
}
}
diff --git a/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/logging/package-info.java b/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/logging/package-info.java
index aa0c28e..6f1288f 100644
--- a/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/logging/package-info.java
+++ b/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/logging/package-info.java
@@ -30,8 +30,8 @@
* <p>
* Styles are:<ul>
* <li><code>debug</code>, <code>info</code>, <code>warning</code> and <code>error</code> for slf4j level display,</li>
- * <li><code>success</code>, <code>failure</code>, <code>strong</code>, <code>mojo</code> and <code>project</code> for
- * message content</li>
+ * <li><code>success</code>, <code>warning</code>, <code>failure</code>, <code>strong</code>, <code>mojo</code>
+ * and <code>project</code> for message content</li>
* </ul>
* Default styles colors can be overridden through system properties, that can be set in <code>MAVEN_OPTS</code>
* environment variable (eventually in <code>.mavenrc</code> script):<ul>
