commit 9161f1e12078bd979008ed4d34816d6414359e35
author Elliotte Rusty Harold <elharo@users.noreply.github.com> Sat Aug 15 07:36:40 2020 -0400
committer GitHub <noreply@github.com> Sat Aug 15 07:36:40 2020 -0400
tree 719ac713aeb8f74c4864d9287fe3ebf4df794e00
parent 1a015f162e8bb6472ecc3d9b1ded3006ea048041

[MSHARED-954] Deprecate platform dependent unifyLineSeparators method (#63)

* deprecate unifyLineSeparators

src/main/java/org/apache/maven/shared/utils/StringUtils.java

diff --git a/src/main/java/org/apache/maven/shared/utils/StringUtils.java b/src/main/java/org/apache/maven/shared/utils/StringUtils.java
index b44a054..b0906e0 100644
--- a/src/main/java/org/apache/maven/shared/utils/StringUtils.java
+++ b/src/main/java/org/apache/maven/shared/utils/StringUtils.java
@@ -2403,8 +2403,12 @@
      * @param s a not null String
      * @return a String that contains only System line separators
      * @see #unifyLineSeparators(String, String)
-     * 
+     * @deprecated this method produces platform dependent code and contributes to 
+     *     non-reproducible builds. In the context of Maven, this is almost never what's needed.
+     *     Remove calls to this method and do not replace them. That is, change
+     *     {@code Stringutils.unifyLineSeparators(s)} with simply {@code s}.
      */
+    @Deprecated
     public static String unifyLineSeparators( @Nullable String s )
     {
         return unifyLineSeparators( s, System.getProperty( "line.separator" ) );