commit 761f7babd827f35775dd92d75cf97b6dfe351309
author Clemens Quoss <clemens@quoss.de> Sat Dec 05 13:39:50 2020 +0100
committer Michael Osipov <michaelo@apache.org> Sat Dec 05 13:51:46 2020 +0100
tree 268ba28b78f558512820a8372ed5d57f52c780d5
parent c5eb2c187568809e0dc0ea9ac83031f1dcb5ad1a

Provide version type constants (revision, branch and tag)

This closes #108

maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/AbstractScmMojo.java

diff --git a/maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/AbstractScmMojo.java b/maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/AbstractScmMojo.java
index a18e319..b0a3aea 100644
--- a/maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/AbstractScmMojo.java
+++ b/maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/AbstractScmMojo.java
@@ -60,6 +60,16 @@
 public abstract class AbstractScmMojo
     extends AbstractMojo
 {
+
+    protected static final String VERSION_TYPE_BRANCH = "branch";
+
+    protected static final String VERSION_TYPE_REVISION = "revision";
+
+    protected static final String VERSION_TYPE_TAG = "tag";
+
+    protected static final String[] VALID_VERSION_TYPES = { VERSION_TYPE_BRANCH,
+            VERSION_TYPE_REVISION, VERSION_TYPE_TAG };
+
     /**
      * The SCM connection URL.
      */
@@ -472,17 +482,17 @@
             return null;
         }
 
-        if ( "branch".equals( versionType ) )
+        if ( VERSION_TYPE_BRANCH.equals( versionType ) )
         {
             return new ScmBranch( version );
         }
 
-        if ( "tag".equals( versionType ) )
+        if ( VERSION_TYPE_TAG.equals( versionType ) )
         {
             return new ScmTag( version );
         }
 
-        if ( "revision".equals( versionType ) )
+        if ( VERSION_TYPE_REVISION.equals( versionType ) )
         {
             return new ScmRevision( version );
         }

maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/ChangeLogMojo.java

diff --git a/maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/ChangeLogMojo.java b/maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/ChangeLogMojo.java
index 1f777a2..8de8056 100644
--- a/maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/ChangeLogMojo.java
+++ b/maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/ChangeLogMojo.java
@@ -126,11 +126,11 @@
             ScmProvider provider = getScmManager().getProviderByRepository( repository );
 
             ScmVersion startRev =
-                getScmVersion( StringUtils.isEmpty( startScmVersionType ) ? "revision" : startScmVersionType,
-                               startScmVersion );
+                getScmVersion( StringUtils.isEmpty( startScmVersionType ) ? VERSION_TYPE_REVISION
+                               : startScmVersionType, startScmVersion );
             ScmVersion endRev =
-                getScmVersion( StringUtils.isEmpty( endScmVersionType ) ? "revision" : endScmVersionType,
-                               endScmVersion );
+                getScmVersion( StringUtils.isEmpty( endScmVersionType ) ? VERSION_TYPE_REVISION
+                               : endScmVersionType, endScmVersion );
 
             ChangeLogScmResult result;
             if ( startRev != null || endRev != null )