commit 90dfc9c00470d2469013e0c76681832360d4d7f1
author Robert Varga <nite@hq.sk> Fri Feb 09 14:50:07 2018 +0100
committer Michael Osipov <michaelo@apache.org> Mon Mar 05 20:36:02 2018 +0100
tree 77d07809970e6d2ad9e3f00e88c5ac682eb52422
parent 57fc4329d99f994e0f9a608cd28e5a48d185563f

[MRESOLVER-42] Use pre-compiled pattern in DefaultArtifact constructor

Compiling a pattern is a rather expensive operation and doing it
a user-convenient constructor is very hurtful. Cache the compiled
pattern in a static final field, just like other classes in this
artifact do.

This closes #16

maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java

diff --git a/maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java b/maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java
index 786af74..6003756 100644
--- a/maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java
+++ b/maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java
@@ -33,6 +33,8 @@
 public final class DefaultArtifact
     extends AbstractArtifact
 {
+    private static final Pattern COORDINATE_PATTERN =
+        Pattern.compile( "([^: ]+):([^: ]+)(:([^: ]*)(:([^: ]+))?)?:([^: ]+)" );
 
     private final String groupId;
 
@@ -70,8 +72,7 @@
      */
     public DefaultArtifact( String coords, Map<String, String> properties )
     {
-        Pattern p = Pattern.compile( "([^: ]+):([^: ]+)(:([^: ]*)(:([^: ]+))?)?:([^: ]+)" );
-        Matcher m = p.matcher( coords );
+        Matcher m = COORDINATE_PATTERN.matcher( coords );
         if ( !m.matches() )
         {
             throw new IllegalArgumentException( "Bad artifact coordinates " + coords