[MRESOLVER-91] Error messages not clear when not reattempting resolution when a previous attempt failed and the failure was cached
For users that were not aware or did not understand well the
ResolutionErrorPolicy, the error messages that were presented when this
policy was enforced, ie a resolution was not reattempted due to a
previous failure that was cached, could be difficult to understand.
This closes #37
diff --git a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java
index 27f85da..e7f2c8e 100644
--- a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java
+++ b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java
@@ -211,16 +211,18 @@
{
if ( error == null || error.length() <= 0 )
{
- return new ArtifactNotFoundException( artifact, repository, "Failure to find " + artifact + " in "
- + repository.getUrl() + " was cached in the local repository, "
- + "resolution will not be reattempted until the update interval of " + repository.getId()
+ return new ArtifactNotFoundException( artifact, repository, artifact
+ + " was not found in " + repository.getUrl() + " during a previous attempt. This failure was"
+ + " cached in the local repository and"
+ + " resolution is not reattempted until the update interval of " + repository.getId()
+ " has elapsed or updates are forced", true );
}
else
{
- return new ArtifactTransferException( artifact, repository, "Failure to transfer " + artifact + " from "
- + repository.getUrl() + " was cached in the local repository, "
- + "resolution will not be reattempted until the update interval of " + repository.getId()
+ return new ArtifactTransferException( artifact, repository, artifact + " failed to transfer from "
+ + repository.getUrl() + " during a previous attempt. This failure"
+ + " was cached in the local repository and"
+ + " resolution is not reattempted until the update interval of " + repository.getId()
+ " has elapsed or updates are forced. Original error: " + error, true );
}
}
@@ -322,16 +324,18 @@
{
if ( error == null || error.length() <= 0 )
{
- return new MetadataNotFoundException( metadata, repository, "Failure to find " + metadata + " in "
- + repository.getUrl() + " was cached in the local repository, "
- + "resolution will not be reattempted until the update interval of " + repository.getId()
+ return new MetadataNotFoundException( metadata, repository, metadata + " was not found in "
+ + repository.getUrl() + " during a previous attempt."
+ + " This failure was cached in the local repository and"
+ + " resolution is not be reattempted until the update interval of " + repository.getId()
+ " has elapsed or updates are forced", true );
}
else
{
- return new MetadataTransferException( metadata, repository, "Failure to transfer " + metadata + " from "
- + repository.getUrl() + " was cached in the local repository, "
- + "resolution will not be reattempted until the update interval of " + repository.getId()
+ return new MetadataTransferException( metadata, repository, metadata + "failed to transfer from "
+ + repository.getUrl() + " during a previous attempt."
+ + " This failure was cached in the local repository and"
+ + " resolution will not be reattempted until the update interval of " + repository.getId()
+ " has elapsed or updates are forced. Original error: " + error, true );
}
}
