commit 4d4ad2b998bcf0e9f5146143c2399be68c9a6a42
author Herve Boutemy <hboutemy@apache.org> Sun Apr 07 09:29:44 2013 +0000
committer Herve Boutemy <hboutemy@apache.org> Sun Apr 07 09:29:44 2013 +0000
tree ea91440413d7f2a7018c63cbcf8c532dc3196fb8
parent 96fcb55b20c22a8642ab48104216d6b8797dbc8e

check reports duplicate and warn if necessary

git-svn-id: https://svn.apache.org/repos/asf/maven/shared/trunk@1465350 13f79535-47bb-0310-9956-ffa450edef68

src/main/java/org/apache/maven/reporting/exec/DefaultMavenReportExecutor.java

diff --git a/src/main/java/org/apache/maven/reporting/exec/DefaultMavenReportExecutor.java b/src/main/java/org/apache/maven/reporting/exec/DefaultMavenReportExecutor.java
index b27f6cc..e8bba45 100644
--- a/src/main/java/org/apache/maven/reporting/exec/DefaultMavenReportExecutor.java
+++ b/src/main/java/org/apache/maven/reporting/exec/DefaultMavenReportExecutor.java
@@ -197,16 +197,32 @@
         }
         else
         {
+            Set<String> goals = new HashSet<String>();
             for ( String report : reportPlugin.getReports() )
             {
-                goalsWithConfiguration.add( new GoalWithConf( report, reportPlugin.getConfiguration() ) );
+                if ( goals.add( report ) )
+                {
+                    goalsWithConfiguration.add( new GoalWithConf( report, reportPlugin.getConfiguration() ) );
+                }
+                else
+                {
+                    logger.warn( report + " report is declared twice in default reports" );
+                }
             }
 
             for ( ReportSet reportSet : reportPlugin.getReportSets() )
             {
+                goals = new HashSet<String>();
                 for ( String report : reportSet.getReports() )
                 {
-                    goalsWithConfiguration.add( new GoalWithConf( report, reportSet.getConfiguration() ) );
+                    if ( goals.add( report ) )
+                    {
+                        goalsWithConfiguration.add( new GoalWithConf( report, reportSet.getConfiguration() ) );
+                    }
+                    else
+                    {
+                        logger.warn( report + " report is declared twice in " + reportSet.getId() + " reportSet" );
+                    }
                 }
             }
         }