Google Git
Sign in
apache / maven-integration-testing / 046a94efc176191922b1689155a62b8801a35f46
commit046a94efc176191922b1689155a62b8801a35f46[log] [tgz]
authorTamas Cservenak <tamas@cservenak.net>Thu Feb 23 13:52:03 2023 +0100
committerGitHub <noreply@github.com>Thu Feb 23 13:52:03 2023 +0100
tree739b7195f9924447bb475c0c934b943b71b16402
parentba0a91b4874e35ec34f558b6efe9a78f1ebef643 [diff]
[MNG-7706] Fix for ITs WARNING detection (#245)

The MNG-7706 deprecates ancient ArtifactRepository type use to get access to local repository, and issues warning as for any other deprecated Mojo parameters.

But alas, in ITs the MNG-5576 completely unrelated IT there is an assertion to have WARNING-free log. This IT uses the IT-plugins/IT-plugin-expression EvalMojo, that in turn uses the deprecated `${localRepository}` parameter (but does not use it). Result is, Maven 3.9.1 emits a WARNING about use of deprecated parameter and the IT fails.

Further inspection shows, that while EvalMojo injects ArtifactRepository for local repository, there is only one IT that actually uses it, the MNG-4305, but even that one is interested in basedir of the local repository only. So to say, the use of deprecated ArtifactRepository type is not needed at all.

Fix:
* change EvalMojo to not expose in context the localRepository (w/ type ArtifactRepository), but a new expression `localRepositoryBasedir` only, that is injected in non-deprecated way (in real life repoSysSession would be injected, but in IT we keep all super-safe and use Object types).
* adjusted MNG-4305 to use new epxression instead to use object reflection in template to get basedir from ArtifactRepository
* This makes the originally failing MNG-5576 pass, as warning due EvalMojo is gone.

See
https://issues.apache.org/jira/browse/MNG-7706
https://github.com/apache/maven/pull/1009
3 files changed
tree: 739b7195f9924447bb475c0c934b943b71b16402
  1. .github/
  2. core-it-suite/
  3. core-it-support/
  4. environments/
  5. src/
  6. .asf.yaml
  7. .gitattributes
  8. .gitignore
  9. Jenkinsfile
  10. pom.xml
  11. README.md
  12. run-its.bat
  13. run-its.sh
README.md

Maven Core Integration Tests

https://maven.apache.org/core-its/

If you want to run the integration tests against a custom build of Maven use the following command:

mvn clean install -Prun-its -Dmaven.repo.local=`pwd`/repo -DmavenDistro=/path/to/apache-maven-dist.zip

or if behind a proxy

mvn clean install -Prun-its -Dmaven.repo.local=`pwd`/repo -DmavenDistro=/path/to/apache-maven-dist.zip -Dproxy.active=true -Dproxy.type=http -Dproxy.host=... -Dproxy.port=... -Dproxy.user=... -Dproxy.pass=...

Using the script

Build Maven core with the profile -PversionlessMavenDist

Now Run the script: sh ./run-its.sh

Maven Developers List: dev@maven.apache.org