More code analysis fixes

git-svn-id: https://svn.apache.org/repos/asf/maven/plugins/trunk@1517623 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/main/java/org/apache/maven/plugin/gpg/AttachedSignedArtifact.java b/src/main/java/org/apache/maven/plugin/gpg/AttachedSignedArtifact.java
index a4baf8e..22e40f2 100644
--- a/src/main/java/org/apache/maven/plugin/gpg/AttachedSignedArtifact.java
+++ b/src/main/java/org/apache/maven/plugin/gpg/AttachedSignedArtifact.java
@@ -274,14 +274,14 @@
         delegate.setOptional( optional );
     }
 
-    public Collection getMetadataList()
+    public Collection<ArtifactMetadata> getMetadataList()
     {
-        List result = new ArrayList( delegate.getMetadataList() );
+        List<ArtifactMetadata> result = new ArrayList<ArtifactMetadata>( delegate.getMetadataList() );
         boolean alreadySigned = false;
         for ( Iterator i = result.iterator(); i.hasNext() && !alreadySigned; )
         {
             ArtifactMetadata metadata = (ArtifactMetadata) i.next();
-            alreadySigned = alreadySigned | signature.getKey().equals( metadata.getKey() );
+            alreadySigned = signature.getKey().equals(metadata.getKey());
         }
         if ( !alreadySigned )
         {