Fixed large number of Checkstyle reported errors/warnings.
git-svn-id: https://svn.apache.org/repos/asf/maven/shared/trunk@1716978 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/AbstractStrictPatternArtifactFilter.java b/src/main/java/org/apache/maven/shared/artifact/filter/AbstractStrictPatternArtifactFilter.java
index fc26e25..0c18d91 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/AbstractStrictPatternArtifactFilter.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/AbstractStrictPatternArtifactFilter.java
@@ -79,9 +79,7 @@
// ArtifactFilter methods -------------------------------------------------
- /*
- * @see org.apache.maven.artifact.resolver.filter.ArtifactFilter#include(org.apache.maven.artifact.Artifact)
- */
+ /** {@inheritDoc} */
public boolean include( Artifact artifact )
{
boolean matched = false;
@@ -121,7 +119,7 @@
String[] patternTokens = pattern.split( ":" );
// fail immediately if pattern tokens outnumber tokens to match
- boolean matched = ( patternTokens.length <= tokens.length );
+ boolean matched = patternTokens.length <= tokens.length;
for ( int i = 0; matched && i < patternTokens.length; i++ )
{
@@ -154,7 +152,7 @@
{
String contains = pattern.substring( 1, pattern.length() - 1 );
- matches = ( token.contains( contains ) );
+ matches = token.contains( contains );
}
// support leading wildcard
else if ( pattern.startsWith( "*" ) )
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/PatternExcludesArtifactFilter.java b/src/main/java/org/apache/maven/shared/artifact/filter/PatternExcludesArtifactFilter.java
index 0dddb7b..b0d7a1e 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/PatternExcludesArtifactFilter.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/PatternExcludesArtifactFilter.java
@@ -32,16 +32,24 @@
public class PatternExcludesArtifactFilter
extends PatternIncludesArtifactFilter
{
+ /**
+ * @param patterns The pattern to be used.
+ */
public PatternExcludesArtifactFilter( Collection<String> patterns )
{
super( patterns );
}
+ /**
+ * @param patterns The pattern which will be used.
+ * @param actTransitively yes/no.
+ */
public PatternExcludesArtifactFilter( Collection<String> patterns, boolean actTransitively )
{
super( patterns, actTransitively );
}
+ /** {@inheritDoc} */
public boolean include( Artifact artifact )
{
boolean shouldInclude = !patternMatches( artifact );
@@ -54,11 +62,13 @@
return shouldInclude;
}
+ /** {@inheritDoc} */
protected String getFilterDescription()
{
return "artifact exclusion filter";
}
+ /** {@inheritDoc} */
public String toString()
{
return "Excludes filter:" + getPatternsAsString();
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/PatternIncludesArtifactFilter.java b/src/main/java/org/apache/maven/shared/artifact/filter/PatternIncludesArtifactFilter.java
index 8bf74d1..ba9ec82 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/PatternIncludesArtifactFilter.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/PatternIncludesArtifactFilter.java
@@ -52,6 +52,9 @@
private final List<String> filteredArtifactIds = new ArrayList<String>();
+ /**
+ * @param patterns The pattern to be used.
+ */
public PatternIncludesArtifactFilter( final Collection<String> patterns )
{
this( patterns, false );
@@ -64,12 +67,16 @@
this( (Collection) patterns, actTransitively );
}
+ /**
+ * @param patterns The pattern to be used.
+ * @param actTransitively transitive yes/no.
+ */
public PatternIncludesArtifactFilter( final Collection<String> patterns, final boolean actTransitively )
{
this.actTransitively = actTransitively;
final List<String> pos = new ArrayList<String>();
final List<String> neg = new ArrayList<String>();
- if ( ( patterns != null ) && !patterns.isEmpty() )
+ if ( patterns != null && !patterns.isEmpty() )
{
for ( String pattern : patterns )
{
@@ -88,6 +95,7 @@
negativePatterns = neg;
}
+ /** {@inheritDoc} */
public boolean include( final Artifact artifact )
{
final boolean shouldInclude = patternMatches( artifact );
@@ -100,11 +108,18 @@
return shouldInclude;
}
+ /**
+ * @param artifact to check for.
+ * @return true if the match is true false otherwise.
+ */
protected boolean patternMatches( final Artifact artifact )
{
- return ( positiveMatch( artifact ) == Boolean.TRUE ) || ( negativeMatch( artifact ) == Boolean.FALSE );
+ return positiveMatch( artifact ) == Boolean.TRUE || negativeMatch( artifact ) == Boolean.FALSE;
}
+ /**
+ * @param artifactId add artifact to the filtered artifacts list.
+ */
protected void addFilteredArtifactId( final String artifactId )
{
filteredArtifactIds.add( artifactId );
@@ -112,7 +127,7 @@
private Boolean negativeMatch( final Artifact artifact )
{
- if ( ( negativePatterns == null ) || negativePatterns.isEmpty() )
+ if ( negativePatterns == null || negativePatterns.isEmpty() )
{
return null;
}
@@ -122,9 +137,13 @@
}
}
+ /**
+ * @param artifact check for positive match.
+ * @return true/false.
+ */
protected Boolean positiveMatch( final Artifact artifact )
{
- if ( ( positivePatterns == null ) || positivePatterns.isEmpty() )
+ if ( positivePatterns == null || positivePatterns.isEmpty() )
{
return null;
}
@@ -159,7 +178,7 @@
{
final List<String> depTrail = artifact.getDependencyTrail();
- if ( ( depTrail != null ) && depTrail.size() > 1 )
+ if ( depTrail != null && depTrail.size() > 1 )
{
for ( String trailItem : depTrail )
{
@@ -182,7 +201,7 @@
final String[] patternTokens = pattern.split( ":" );
// fail immediately if pattern tokens outnumber tokens to match
- boolean matched = ( patternTokens.length <= tokens.length );
+ boolean matched = patternTokens.length <= tokens.length;
for ( int i = 0; matched && i < patternTokens.length; i++ )
{
@@ -244,7 +263,7 @@
{
final String contains = pattern.substring( 1, pattern.length() - 1 );
- matches = ( token.contains( contains ) );
+ matches = token.contains( contains );
}
// support leading wildcard
else if ( pattern.startsWith( "*" ) )
@@ -307,6 +326,7 @@
}
}
+ /** {@inheritDoc} */
public void reportMissedCriteria( final Logger logger )
{
// if there are no patterns, there is nothing to report.
@@ -344,6 +364,9 @@
return "Includes filter:" + getPatternsAsString();
}
+ /**
+ * @return pattern as a string.
+ */
protected String getPatternsAsString()
{
final StringBuilder buffer = new StringBuilder();
@@ -355,11 +378,15 @@
return buffer.toString();
}
+ /**
+ * @return description.
+ */
protected String getFilterDescription()
{
return "artifact inclusion filter";
}
+ /** {@inheritDoc} */
public void reportFilteredArtifacts( final Logger logger )
{
if ( !filteredArtifactIds.isEmpty() && logger.isDebugEnabled() )
@@ -376,6 +403,7 @@
}
}
+ /** {@inheritDoc} */
public boolean hasMissedCriteria()
{
// if there are no patterns, there is nothing to report.
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/ScopeArtifactFilter.java b/src/main/java/org/apache/maven/shared/artifact/filter/ScopeArtifactFilter.java
index 1a80c67..8ea1b61 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/ScopeArtifactFilter.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/ScopeArtifactFilter.java
@@ -106,6 +106,7 @@
}
}
+ /** {@inheritDoc} */
public boolean include( Artifact artifact )
{
boolean result = true;
@@ -162,6 +163,9 @@
return result;
}
+ /**
+ * @return Information converted to a string.
+ */
public String toString()
{
return "Scope filter [null-scope=" + includeNullScope + ", compile=" + includeCompileScope + ", runtime="
@@ -169,6 +173,7 @@
+ includeSystemScope + "]";
}
+ /** {@inheritDoc} */
public void reportFilteredArtifacts( Logger logger )
{
if ( !filteredArtifactIds.isEmpty() && logger.isDebugEnabled() )
@@ -184,6 +189,7 @@
}
}
+ /** {@inheritDoc} */
public void reportMissedCriteria( Logger logger )
{
if ( logger.isDebugEnabled() )
@@ -229,6 +235,7 @@
}
}
+ /** {@inheritDoc} */
public boolean hasMissedCriteria()
{
boolean report = false;
@@ -261,62 +268,94 @@
return report;
}
+ /**
+ * @return {@link #includeCompileScope}
+ */
public boolean isIncludeCompileScope()
{
return includeCompileScope;
}
- public ScopeArtifactFilter setIncludeCompileScope( boolean includeCompileScope )
+ /**
+ * @param pIncludeCompileScope true/false.
+ * @return {@link ScopeArtifactFilter}
+ */
+ public ScopeArtifactFilter setIncludeCompileScope( boolean pIncludeCompileScope )
{
- this.includeCompileScope = includeCompileScope;
+ this.includeCompileScope = pIncludeCompileScope;
return this;
}
+ /**
+ * @return {@link #includeRuntimeScope}
+ */
public boolean isIncludeRuntimeScope()
{
return includeRuntimeScope;
}
- public ScopeArtifactFilter setIncludeRuntimeScope( boolean includeRuntimeScope )
+ /**
+ * @param pIncludeRuntimeScope true/false
+ * @return {@link ScopeArtifactFilter}
+ */
+ public ScopeArtifactFilter setIncludeRuntimeScope( boolean pIncludeRuntimeScope )
{
- this.includeRuntimeScope = includeRuntimeScope;
+ this.includeRuntimeScope = pIncludeRuntimeScope;
return this;
}
+ /**
+ * @return {@link #includeTestScope}
+ */
public boolean isIncludeTestScope()
{
return includeTestScope;
}
- public ScopeArtifactFilter setIncludeTestScope( boolean includeTestScope )
+ /**
+ * @param pIncludeTestScope {@link #includeTestScope}
+ * @return {@link ScopeArtifactFilter}
+ */
+ public ScopeArtifactFilter setIncludeTestScope( boolean pIncludeTestScope )
{
- this.includeTestScope = includeTestScope;
+ this.includeTestScope = pIncludeTestScope;
return this;
}
+ /**
+ * @return {@link #includeProvidedScope}
+ */
public boolean isIncludeProvidedScope()
{
return includeProvidedScope;
}
- public ScopeArtifactFilter setIncludeProvidedScope( boolean includeProvidedScope )
+ /**
+ * @param pIncludeProvidedScope yes/no.
+ * @return {@link #ScopeArtifactFilter()}
+ */
+ public ScopeArtifactFilter setIncludeProvidedScope( boolean pIncludeProvidedScope )
{
- this.includeProvidedScope = includeProvidedScope;
+ this.includeProvidedScope = pIncludeProvidedScope;
return this;
}
+ /**
+ * @return {@link #includeSystemScope}
+ */
public boolean isIncludeSystemScope()
{
return includeSystemScope;
}
- public ScopeArtifactFilter setIncludeSystemScope( boolean includeSystemScope )
+ /** {@inheritDoc} */
+ public ScopeArtifactFilter setIncludeSystemScope( boolean pIncludeSystemScope )
{
- this.includeSystemScope = includeSystemScope;
+ this.includeSystemScope = pIncludeSystemScope;
return this;
}
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/StatisticsReportingArtifactFilter.java b/src/main/java/org/apache/maven/shared/artifact/filter/StatisticsReportingArtifactFilter.java
index 03acbdc..ffecb5e 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/StatisticsReportingArtifactFilter.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/StatisticsReportingArtifactFilter.java
@@ -27,10 +27,19 @@
public interface StatisticsReportingArtifactFilter
{
+ /**
+ * @param logger The logger.
+ */
void reportMissedCriteria( Logger logger );
+ /**
+ * @param logger The logger.
+ */
void reportFilteredArtifacts( Logger logger );
+ /**
+ * @return {@code true} if missed cireteria {@code false} otherwise.
+ */
boolean hasMissedCriteria();
}
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/collection/AbstractArtifactFeatureFilter.java b/src/main/java/org/apache/maven/shared/artifact/filter/collection/AbstractArtifactFeatureFilter.java
index 18d5192..dbf677a 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/collection/AbstractArtifactFeatureFilter.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/collection/AbstractArtifactFeatureFilter.java
@@ -44,6 +44,10 @@
*/
private List<String> excludes;
+ /**
+ * @param include comma separated list with includes.
+ * @param exclude comma separated list with excludes.
+ */
public AbstractArtifactFeatureFilter( String include, String exclude )
{
setExcludes( exclude );
@@ -146,6 +150,9 @@
*/
protected abstract String getArtifactFeature( Artifact artifact );
+ /**
+ * @param excludeString comma separated list with excludes.
+ */
public void setExcludes( String excludeString )
{
if ( StringUtils.isNotEmpty( excludeString ) )
@@ -154,6 +161,9 @@
}
}
+ /**
+ * @param includeString comma separated list with includes.
+ */
public void setIncludes( String includeString )
{
if ( StringUtils.isNotEmpty( includeString ) )
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/collection/AbstractArtifactsFilter.java b/src/main/java/org/apache/maven/shared/artifact/filter/collection/AbstractArtifactsFilter.java
index 34a56a8..f7918a4 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/collection/AbstractArtifactsFilter.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/collection/AbstractArtifactsFilter.java
@@ -25,14 +25,15 @@
import org.apache.maven.artifact.Artifact;
/**
- *
+ * @author <a href="mailto:brianf@apache.org">Brian Fox</a>
+ * @version $Id$
*/
public abstract class AbstractArtifactsFilter
implements ArtifactsFilter
{
/**
- * @author <a href="mailto:brianf@apache.org">Brian Fox</a>
- * @version $Id$
+ * @param artifact {@link Artifact}
+ * @return {@code true} if artifact is includes {@code false} otherwise.
* @throws ArtifactFilterException when filtering fails
*/
public boolean isArtifactIncluded( Artifact artifact )
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactFilterException.java b/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactFilterException.java
index 62c1973..0f25099 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactFilterException.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactFilterException.java
@@ -30,21 +30,34 @@
*/
private static final long serialVersionUID = 1L;
+ /**
+ * Create an instance.
+ */
public ArtifactFilterException()
{
super();
}
+ /**
+ * @param theMessage The message which describes what happends.
+ * @param theCause The cause.
+ */
public ArtifactFilterException( String theMessage, Throwable theCause )
{
super( theMessage, theCause );
}
+ /**
+ * @param theMessage The message which describes what happends.
+ */
public ArtifactFilterException( String theMessage )
{
super( theMessage );
}
+ /**
+ * @param theCause {@link Throwable} cause of the problem.
+ */
public ArtifactFilterException( Throwable theCause )
{
super( theCause );
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactTransitivityFilter.java b/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactTransitivityFilter.java
index 69a7909..debc6af 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactTransitivityFilter.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactTransitivityFilter.java
@@ -173,6 +173,9 @@
}
}
+ /**
+ * {@inheritDoc}
+ */
public Set<Artifact> filter( Set<Artifact> artifacts )
{
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactsFilter.java b/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactsFilter.java
index af4624c..6fdc3c9 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactsFilter.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/collection/ArtifactsFilter.java
@@ -33,9 +33,19 @@
*/
public interface ArtifactsFilter
{
+ /**
+ * @param artifacts {@link Artifact}
+ * @return Set of artifacts.
+ * @throws ArtifactFilterException in case of a failure.
+ */
Set<Artifact> filter( Set<Artifact> artifacts )
throws ArtifactFilterException;
+ /**
+ * @param artifact {@link Artifact}
+ * @return {@code true} if artifact is included {@code false} otherwise.
+ * @throws ArtifactFilterException in case of a failure.
+ */
boolean isArtifactIncluded( Artifact artifact )
throws ArtifactFilterException;
}
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/collection/ClassifierFilter.java b/src/main/java/org/apache/maven/shared/artifact/filter/collection/ClassifierFilter.java
index ac5ff4e..f9fe056 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/collection/ClassifierFilter.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/collection/ClassifierFilter.java
@@ -29,11 +29,16 @@
public class ClassifierFilter
extends AbstractArtifactFeatureFilter
{
+ /**
+ * @param include comma separated list with includes.
+ * @param exclude comma separated list with excludes.
+ */
public ClassifierFilter( String include, String exclude )
{
super( include, exclude );
}
+ /** {@inheritDoc} */
protected String getArtifactFeature( Artifact artifact )
{
return artifact.getClassifier();
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/collection/FilterArtifacts.java b/src/main/java/org/apache/maven/shared/artifact/filter/collection/FilterArtifacts.java
index 8cb8047..a8f211f 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/collection/FilterArtifacts.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/collection/FilterArtifacts.java
@@ -37,6 +37,9 @@
{
private List<ArtifactsFilter> filters;
+ /**
+ * Created new instance.
+ */
public FilterArtifacts()
{
filters = new ArrayList<ArtifactsFilter>();
@@ -79,6 +82,11 @@
}
}
+ /**
+ * @param artifacts The {@link Artifact}s to filter.
+ * @return The resulting artifacts set.
+ * @throws ArtifactFilterException in case of a failure.
+ */
public Set<Artifact> filter( Set<Artifact> artifacts )
throws ArtifactFilterException
{
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/collection/ProjectTransitivityFilter.java b/src/main/java/org/apache/maven/shared/artifact/filter/collection/ProjectTransitivityFilter.java
index 976d4fe..e05c68b 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/collection/ProjectTransitivityFilter.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/collection/ProjectTransitivityFilter.java
@@ -36,12 +36,18 @@
private Set<Artifact> directDependencies;
+ /**
+ * @param directDependencies set of direct dependencies.
+ * @param excludeTransitive {@code true} exclude transitive deps {@code false} otherwise.
+ */
public ProjectTransitivityFilter( Set<Artifact> directDependencies, boolean excludeTransitive )
{
this.excludeTransitive = excludeTransitive;
this.directDependencies = directDependencies;
}
+ /** {@inheritDoc}
+ */
public Set<Artifact> filter( Set<Artifact> artifacts )
{
// why not just take the directDependencies here?
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/collection/ScopeFilter.java b/src/main/java/org/apache/maven/shared/artifact/filter/collection/ScopeFilter.java
index be2cc09..61c3afe 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/collection/ScopeFilter.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/collection/ScopeFilter.java
@@ -39,6 +39,10 @@
private String excludeScope;
+ /**
+ * @param includeScope the scope to be included.
+ * @param excludeScope the scope to be excluded.
+ */
public ScopeFilter( String includeScope, String excludeScope )
{
this.includeScope = includeScope;
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/collection/TypeFilter.java b/src/main/java/org/apache/maven/shared/artifact/filter/collection/TypeFilter.java
index 34ecb8c..96d4c93 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/collection/TypeFilter.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/collection/TypeFilter.java
@@ -28,11 +28,16 @@
public class TypeFilter
extends AbstractArtifactFeatureFilter
{
+ /**
+ * @param include comma separated list with includes.
+ * @param exclude comma separated list with excludes.
+ */
public TypeFilter( String include, String exclude )
{
super( include, exclude );
}
+ /** {@inheritDoc} */
protected String getArtifactFeature( Artifact artifact )
{
return artifact.getType();
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/resolve/AbstractFilter.java b/src/main/java/org/apache/maven/shared/artifact/filter/resolve/AbstractFilter.java
index 2449ab5..a02c045 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/resolve/AbstractFilter.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/resolve/AbstractFilter.java
@@ -30,11 +30,18 @@
public abstract class AbstractFilter implements TransformableFilter
{
+ /** {@inheritDoc}
+ */
@Override
public final <T> T transform( FilterTransformer<T> transformer )
{
return transformer.transform( this );
}
+ /**
+ * @param node {@link Node}
+ * @param parents {@link Node}s.
+ * @return {@code true} / {@code false}
+ */
public abstract boolean accept( Node node, List<Node> parents );
}
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/resolve/ExclusionsFilter.java b/src/main/java/org/apache/maven/shared/artifact/filter/resolve/ExclusionsFilter.java
index 1f076a5..b9da1b0 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/resolve/ExclusionsFilter.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/resolve/ExclusionsFilter.java
@@ -47,6 +47,9 @@
this.excludes = Collections.unmodifiableCollection( excludes );
}
+ /**
+ * @return The list of excludes.
+ */
public final Collection<String> getExcludes()
{
return excludes;
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/resolve/Node.java b/src/main/java/org/apache/maven/shared/artifact/filter/resolve/Node.java
index 763d744..aff9fd5 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/resolve/Node.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/resolve/Node.java
@@ -24,10 +24,12 @@
*
* @author Robert Scholte
* @since 3.0
- *
*/
public interface Node
{
+ /**
+ * @return {@link Dependency}
+ */
org.apache.maven.model.Dependency getDependency();
}
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/resolve/ScopeFilter.java b/src/main/java/org/apache/maven/shared/artifact/filter/resolve/ScopeFilter.java
index cb47c75..57d4788 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/resolve/ScopeFilter.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/resolve/ScopeFilter.java
@@ -116,7 +116,9 @@
/**
* Transform this filter to a tool specific implementation
*
+ * @param <T> The type to be used.
* @param transformer the transformer, must not be {@code null}
+ * @return T.
*/
public <T> T transform ( FilterTransformer<T> transformer )
{
diff --git a/src/main/java/org/apache/maven/shared/artifact/filter/resolve/transform/ArtifactIncludeNode.java b/src/main/java/org/apache/maven/shared/artifact/filter/resolve/transform/ArtifactIncludeNode.java
index a392776..aa2c5fc 100644
--- a/src/main/java/org/apache/maven/shared/artifact/filter/resolve/transform/ArtifactIncludeNode.java
+++ b/src/main/java/org/apache/maven/shared/artifact/filter/resolve/transform/ArtifactIncludeNode.java
@@ -47,7 +47,7 @@
@Override
public Dependency getDependency()
{
- org.apache.maven.model.Dependency mavenDependency = new org.apache.maven.model.Dependency();
+ Dependency mavenDependency = new Dependency();
mavenDependency.setGroupId( artifact.getGroupId() );
mavenDependency.setArtifactId( artifact.getArtifactId() );
mavenDependency.setVersion( artifact.getVersion() );
