Fix problem reported by FindBugs: may fail to clean up java.io.InputStream
git-svn-id: https://svn.apache.org/repos/asf/maven/plugins/trunk@1579079 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/main/java/org/apache/maven/plugin/changes/ChangesXML.java b/src/main/java/org/apache/maven/plugin/changes/ChangesXML.java
index 0c86e8a..337e65d 100644
--- a/src/main/java/org/apache/maven/plugin/changes/ChangesXML.java
+++ b/src/main/java/org/apache/maven/plugin/changes/ChangesXML.java
@@ -29,6 +29,7 @@
import org.apache.maven.plugins.changes.model.ChangesDocument;
import org.apache.maven.plugins.changes.model.Properties;
import org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader;
+import org.codehaus.plexus.util.IOUtil;
/**
* A facade for a changes.xml file.
@@ -57,12 +58,15 @@
return;
}
+ FileInputStream fileInputStream = null;
+
try
{
ChangesXpp3Reader reader = new ChangesXpp3Reader();
- changesDocument = reader.read( new FileInputStream( xmlPath ), false );
+ fileInputStream = new FileInputStream( xmlPath );
+ changesDocument = reader.read( fileInputStream, false );
if ( changesDocument == null )
{
@@ -97,6 +101,10 @@
// FIXME throw an Exception ?
log.error( "An error occurred when parsing the changes.xml file: ", e );
}
+ finally
+ {
+ IOUtil.close( fileInputStream );
+ }
}
public void setAuthor( String author )
