blob: 8953d74339e024d69a82a4be7428d0e3dc989767 [file]
import assert from 'node:assert/strict';
import { describe, test } from 'node:test';
import {
renderInterruptedPlanContext,
renderPlanExecutionPrompt,
renderPlanModePrompt,
selectCollaborationTools,
} from '../plan-mode.js';
import { buildCancelPlanTool, buildSubmitPlanTool, buildUpdatePlanTool } from '../plan-tools.js';
import type { MakaTool } from '../tool-runtime.js';
describe('Plan Mode tool surface', () => {
test('keeps plan lifecycle controls outside nested Code Mode execution', () => {
const store = {} as never;
assert.equal(buildSubmitPlanTool(store).nesting, 'direct_only');
assert.equal(buildUpdatePlanTool(store, 'execution-1').nesting, 'direct_only');
assert.equal(buildCancelPlanTool(store, 'execution-1').nesting, 'direct_only');
});
test('requires plain-text step titles and descriptions', () => {
const submitPlan = buildSubmitPlanTool({} as never);
assert.equal(submitPlan.recoveryMode, 'idempotent');
const schema = submitPlan.parameters as {
safeParse(input: unknown): { success: boolean };
};
const valid = {
title: 'Plan',
steps: [{ id: 'inspect', title: 'Inspect code', description: 'Read the relevant files.' }],
};
assert.equal(schema.safeParse(valid).success, true);
assert.equal(
schema.safeParse({ title: 'Plan', steps: [{ id: 'inspect', description: 'Read files.' }] })
.success,
false,
);
assert.equal(
schema.safeParse({
title: 'Plan',
steps: [{ id: 'inspect', title: '**Inspect code**', description: 'Read files.' }],
}).success,
false,
);
assert.equal(
schema.safeParse({
title: 'Plan',
steps: [{ id: 'inspect', title: 'Inspect code', description: '- Read files' }],
}).success,
false,
);
assert.equal(
schema.safeParse({
title: 'Plan',
steps: [{ id: 'step one', title: 'Inspect code', description: 'Read files.' }],
}).success,
false,
);
assert.equal(
schema.safeParse({
title: 'Plan',
steps: [
{
id: 'inspect',
title: 'Inspect code',
description: 'x'.repeat(16 * 1024 + 1),
},
],
}).success,
false,
);
assert.equal(
schema.safeParse({
title: 'Plan',
steps: Array.from({ length: 16 }, (_, index) => ({
id: `step-${index}`,
title: `Step ${index}`,
description: 'x'.repeat(4_000),
})),
}).success,
false,
);
const lifecycleSteps = (descriptionBytes: number) =>
Array.from({ length: 50 }, (_, index) => ({
id: `step-${index}`,
title: `Step ${index}`,
description: 'x'.repeat(descriptionBytes),
}));
assert.equal(schema.safeParse({ title: 'Plan', steps: lifecycleSteps(900) }).success, true);
assert.equal(schema.safeParse({ title: 'Plan', steps: lifecycleSteps(1_100) }).success, false);
assert.match(renderPlanModePrompt(), /plain text without Markdown formatting/);
});
test('keeps read tools and plan controls while removing writes and subagents', () => {
const selected = selectCollaborationTools({
mode: 'plan',
hasActiveExecution: false,
tools: [
tool('Read', 'read'),
tool('WebSearch', 'web_read'),
tool('Write', 'file_write'),
tool('ExploreAgent', 'subagent'),
tool('AskUserQuestion'),
tool('SubmitPlan'),
tool('update_plan'),
],
});
assert.deepEqual(
selected.map((tool) => tool.name),
['Read', 'WebSearch', 'AskUserQuestion', 'SubmitPlan'],
);
});
test('active execution exposes progress controls and removes subagents', () => {
const selected = selectCollaborationTools({
mode: 'agent',
hasActiveExecution: true,
tools: [
tool('Write', 'file_write'),
tool('ExploreAgent', 'subagent'),
tool('SubmitPlan'),
tool('update_plan'),
tool('cancel_plan'),
],
});
assert.deepEqual(
selected.map((tool) => tool.name),
['Write', 'update_plan', 'cancel_plan'],
);
});
test('injects interrupted progress as replanning context without resuming execution', () => {
const prompt = renderInterruptedPlanContext({
proposal: {
planId: 'plan-1',
proposalId: 'proposal-1',
sessionId: 'session-1',
turnId: 'turn-1',
revision: 1,
title: 'Original plan',
steps: [{ id: 'inspect', title: 'Inspect code', description: 'Inspect' }],
status: 'approved',
submittedAt: 1,
},
execution: {
executionId: 'execution-1',
planId: 'plan-1',
proposalId: 'proposal-1',
sessionId: 'session-1',
status: 'interrupted',
steps: [
{
id: 'inspect',
title: 'Inspect code',
description: 'Inspect',
status: 'completed',
updatedAt: 2,
},
],
startedAt: 1,
updatedAt: 2,
interruptedAt: 2,
interruptionReason: 'User stopped execution',
},
});
assert.match(prompt, /Interrupted execution ID: execution-1/);
assert.match(prompt, /<title>Inspect code<\/title>/);
assert.match(prompt, /<description>Inspect<\/description>/);
assert.match(prompt, /<status>completed<\/status>/);
assert.match(prompt, /Do not resume execution or modify files/);
});
test('requires execution progress updates at step boundaries', () => {
const prompt = renderPlanExecutionPrompt({
proposal: {
planId: 'plan-1',
proposalId: 'proposal-1',
sessionId: 'session-1',
turnId: 'turn-1',
revision: 1,
title: 'Implement plan',
steps: [{ id: 'change', title: 'Change implementation', description: 'Change code' }],
status: 'approved',
submittedAt: 1,
},
execution: {
executionId: 'execution-1',
planId: 'plan-1',
proposalId: 'proposal-1',
sessionId: 'session-1',
status: 'active',
steps: [
{
id: 'change',
title: 'Change implementation',
description: 'Change code',
status: 'pending',
updatedAt: 1,
},
],
startedAt: 1,
updatedAt: 1,
},
});
assert.match(prompt, /Before implementation, call update_plan/);
assert.match(prompt, /<title>Change implementation<\/title>/);
assert.match(prompt, /<description>Change code<\/description>/);
assert.match(prompt, /Immediately after finishing a step, call update_plan again/);
assert.match(prompt, /Before the final response, update every finished or skipped step/);
});
});
function tool(name: string, categoryHint?: MakaTool['categoryHint']): MakaTool {
return {
name,
description: name,
parameters: {},
...(categoryHint ? { categoryHint } : {}),
impl: () => null,
};
}