Summary: Fix defaults when the user passes NULL
JIRA: MADLIB-1413
Summarizer used python defaults for setting up the optional parameters.
If the user passes a NULL, these values get overwritten. This commit
fixes this issue by moving the defaults inside the code.
diff --git a/src/ports/postgres/modules/summary/Summarizer.py_in b/src/ports/postgres/modules/summary/Summarizer.py_in
index 277fa7f..5790972 100644
--- a/src/ports/postgres/modules/summary/Summarizer.py_in
+++ b/src/ports/postgres/modules/summary/Summarizer.py_in
@@ -11,8 +11,8 @@
def __init__(self, schema_madlib, source_table, output_table,
target_cols, grouping_cols, distinctify, get_quartiles,
- xtileify='Exact', ntile_array=None, how_many_mfv=10,
- get_mfv_quick=False, n_cols_per_run=15):
+ xtileify, ntile_array, how_many_mfv, get_mfv_quick,
+ n_cols_per_run):
self._schema_madlib = schema_madlib
self._source_table = source_table
self._output_table = output_table
@@ -20,11 +20,11 @@
self._target_cols = target_cols
self._distinctify = distinctify
self._get_quartiles = get_quartiles
- self._xtileify = xtileify
+ self._xtileify = xtileify if xtileify else 'Exact'
self._ntile_array = ntile_array
- self._how_many_mfv = how_many_mfv
- self._get_mfv_quick = get_mfv_quick
- self._n_cols_per_run = n_cols_per_run
+ self._how_many_mfv = how_many_mfv if how_many_mfv is not None else 10
+ self._get_mfv_quick = get_mfv_quick if get_mfv_quick is not None else False
+ self._n_cols_per_run = n_cols_per_run if n_cols_per_run is not None else 15
self._columns = None
self._column_names = None
self._delimiter = '_.*.&.!.!.&.*_'
