PGXN: Add newline between files during concat
JIRA: MADLIB-1194
PGXN requires a single SQL file during installation. This is created by
concatenating all our sql_in files together. This was earlier performed
with a simple `cat` command, but that led to an error due to a missing
newline at EOF (MADLIB-1191). This commit avoids such an issue by
explicitly adding a newline during the concatenation. This is performed
by using `awk` instead of `cat`.
Closes #221
diff --git a/src/ports/postgres/CMakeLists.txt b/src/ports/postgres/CMakeLists.txt
index b226e4d..6c7b3a8 100644
--- a/src/ports/postgres/CMakeLists.txt
+++ b/src/ports/postgres/CMakeLists.txt
@@ -307,8 +307,14 @@
# The workhorse for extension target
# It is hard to interpret Modules.yml in this cmake file, thus we use
# sort-module.py to sort modules based on the dependencies.
+ # awk is used to read and print each line from each file into {EXTENSION_SQL}
+ # awk's prog contains two parts:
+ # 1. FNR==1{print ""}: add an empty newline if reading the
+ # first line of a file
+ # 2. 1: Print each line. This part takes advantage of the default
+ # action of {print}
add_custom_command(OUTPUT ${EXTENSION_SQL}
- COMMAND cat ${EXTENSION_SQL_BASE}
+ COMMAND awk 'FNR==1{print \"\"}1' ${EXTENSION_SQL_BASE}
`cd ${CMAKE_BINARY_DIR}/src/madpack &&
python sort-module.py ${MODULE_SQL_POST_FILES}` >${EXTENSION_SQL}
DEPENDS ${MODULE_SQL_POST_FILES} madpackFiles configFiles pythonFiles_${DBMS} madlib_${DBMS}
