commit a4c79c8d3068ce257adcaf019db210e5842ed137
author Luca Cavanna <javanna@apache.org> Tue Sep 17 09:41:10 2024 +0200
committer GitHub <noreply@github.com> Tue Sep 17 09:41:10 2024 +0200
tree e4548ac0cb26aa7152710ef62dd473af60106919
parent f4ebed2404eea001a76f6ad7dda03a135b0d7cbc

Remove CollectorManager#forSequentialExecution (#13790)

We have recently (see #13735) introduced this utility method that creates a
collector manager which only works when a searcher does not have an executor
set, otherwise it throws exception once we attempt to create a new collector
for more than one slice.

While we discussed it should be safe to use in some specific scenarios like the
monitor module, we should be careful exposing this utility publicly, because
while we'd like to ease migration from the search(Query, Collector) method, we
may end up making users like even worse, in that it exposes them to failures
whenever an executor is set and there are more than one slice created, which
is hard to follow and does not provide a good user experience.

My proposal is that we use a similar collector manager locally, where safe and
required, but we don't expose it to users. In most places, we should rather
expose collector managers that do support search concurrency, rather than working
around the lack of those.