| package org.apache.solr.update.processor; |
| |
| /* |
| * Licensed to the Apache Software Foundation (ASF) under one or more |
| * contributor license agreements. See the NOTICE file distributed with |
| * this work for additional information regarding copyright ownership. |
| * The ASF licenses this file to You under the Apache License, Version 2.0 |
| * (the "License"); you may not use this file except in compliance with |
| * the License. You may obtain a copy of the License at |
| * |
| * http://www.apache.org/licenses/LICENSE-2.0 |
| * |
| * Unless required by applicable law or agreed to in writing, software |
| * distributed under the License is distributed on an "AS IS" BASIS, |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| * See the License for the specific language governing permissions and |
| * limitations under the License. |
| */ |
| |
| import static org.apache.solr.update.processor.DistributingUpdateProcessorFactory.DISTRIB_UPDATE_PARAM; |
| |
| import java.io.IOException; |
| import java.util.ArrayList; |
| import java.util.Arrays; |
| import java.util.Collection; |
| import java.util.Collections; |
| import java.util.HashMap; |
| import java.util.HashSet; |
| import java.util.List; |
| import java.util.Map; |
| import java.util.Map.Entry; |
| import java.util.Set; |
| import java.util.concurrent.ExecutorService; |
| import java.util.concurrent.TimeUnit; |
| import java.util.concurrent.atomic.AtomicInteger; |
| import java.util.concurrent.locks.ReentrantLock; |
| |
| import org.apache.lucene.util.BytesRef; |
| import org.apache.lucene.util.CharsRef; |
| import org.apache.solr.client.solrj.request.UpdateRequest; |
| import org.apache.solr.cloud.CloudDescriptor; |
| import org.apache.solr.cloud.DistributedQueue; |
| import org.apache.solr.cloud.LeaderInitiatedRecoveryThread; |
| import org.apache.solr.cloud.Overseer; |
| import org.apache.solr.cloud.ZkController; |
| import org.apache.solr.common.SolrException; |
| import org.apache.solr.common.SolrException.ErrorCode; |
| import org.apache.solr.common.SolrInputDocument; |
| import org.apache.solr.common.SolrInputField; |
| import org.apache.solr.common.cloud.ClusterState; |
| import org.apache.solr.common.cloud.CompositeIdRouter; |
| import org.apache.solr.common.cloud.DocCollection; |
| import org.apache.solr.common.cloud.DocRouter; |
| import org.apache.solr.common.cloud.Replica; |
| import org.apache.solr.common.cloud.RoutingRule; |
| import org.apache.solr.common.cloud.Slice; |
| import org.apache.solr.common.cloud.SolrZkClient; |
| import org.apache.solr.common.cloud.ZkCoreNodeProps; |
| import org.apache.solr.common.cloud.ZkNodeProps; |
| import org.apache.solr.common.cloud.ZkStateReader; |
| import org.apache.solr.common.cloud.ZooKeeperException; |
| import org.apache.solr.common.params.ModifiableSolrParams; |
| import org.apache.solr.common.params.ShardParams; |
| import org.apache.solr.common.params.SolrParams; |
| import org.apache.solr.common.params.UpdateParams; |
| import org.apache.solr.common.util.Hash; |
| import org.apache.solr.common.util.NamedList; |
| import org.apache.solr.core.CoreContainer; |
| import org.apache.solr.core.CoreDescriptor; |
| import org.apache.solr.handler.component.RealTimeGetComponent; |
| import org.apache.solr.request.SolrQueryRequest; |
| import org.apache.solr.request.SolrRequestInfo; |
| import org.apache.solr.response.SolrQueryResponse; |
| import org.apache.solr.schema.IndexSchema; |
| import org.apache.solr.schema.SchemaField; |
| import org.apache.solr.update.AddUpdateCommand; |
| import org.apache.solr.update.CommitUpdateCommand; |
| import org.apache.solr.update.DeleteUpdateCommand; |
| import org.apache.solr.update.SolrCmdDistributor; |
| import org.apache.solr.update.SolrCmdDistributor.Error; |
| import org.apache.solr.update.SolrCmdDistributor.Node; |
| import org.apache.solr.update.SolrCmdDistributor.RetryNode; |
| import org.apache.solr.update.SolrCmdDistributor.StdNode; |
| import org.apache.solr.update.SolrIndexSplitter; |
| import org.apache.solr.update.UpdateCommand; |
| import org.apache.solr.update.UpdateHandler; |
| import org.apache.solr.update.UpdateLog; |
| import org.apache.solr.update.VersionBucket; |
| import org.apache.solr.update.VersionInfo; |
| import org.apache.zookeeper.KeeperException; |
| import org.slf4j.Logger; |
| import org.slf4j.LoggerFactory; |
| |
| // NOT mt-safe... create a new processor for each add thread |
| // TODO: we really should not wait for distrib after local? unless a certain replication factor is asked for |
| public class DistributedUpdateProcessor extends UpdateRequestProcessor { |
| public static final String DISTRIB_FROM_SHARD = "distrib.from.shard"; |
| public static final String DISTRIB_FROM_COLLECTION = "distrib.from.collection"; |
| public static final String DISTRIB_FROM_PARENT = "distrib.from.parent"; |
| public static final String DISTRIB_FROM = "distrib.from"; |
| private static final String TEST_DISTRIB_SKIP_SERVERS = "test.distrib.skip.servers"; |
| public final static Logger log = LoggerFactory.getLogger(DistributedUpdateProcessor.class); |
| |
| /** |
| * Values this processor supports for the <code>DISTRIB_UPDATE_PARAM</code>. |
| * This is an implementation detail exposed solely for tests. |
| * |
| * @see DistributingUpdateProcessorFactory#DISTRIB_UPDATE_PARAM |
| */ |
| public static enum DistribPhase { |
| NONE, TOLEADER, FROMLEADER; |
| |
| public static DistribPhase parseParam(final String param) { |
| if (param == null || param.trim().isEmpty()) { |
| return NONE; |
| } |
| try { |
| return valueOf(param); |
| } catch (IllegalArgumentException e) { |
| throw new SolrException |
| (SolrException.ErrorCode.BAD_REQUEST, "Illegal value for " + |
| DISTRIB_UPDATE_PARAM + ": " + param, e); |
| } |
| } |
| } |
| |
| /** |
| * Keeps track of the replication factor achieved for a distributed update request |
| * originated in this distributed update processor. |
| */ |
| public static class RequestReplicationTracker { |
| int minRf; |
| // if a leader is driving the update request, then this will be non-null |
| // however a replica may also be driving the update request (forwards to leaders) |
| // in which case we leave this as null so we only count the rf back from the leaders |
| String onLeaderShardId; |
| // track number of nodes we sent requests to and how many resulted in errors |
| // there may be multiple requests per node when processing a batch |
| Map<String,AtomicInteger> nodeErrorTracker; |
| // if not using DirectUpdates, a leader may end up forwarding to other |
| // leaders, so we need to keep the achieved rf for each of those too |
| Map<String,Integer> otherLeaderRf; |
| |
| private RequestReplicationTracker(String shardId, int minRf) { |
| this.minRf = minRf; |
| this.onLeaderShardId = shardId; |
| this.nodeErrorTracker = new HashMap<>(5); |
| this.otherLeaderRf = new HashMap<>(); |
| } |
| |
| // gives the replication factor that was achieved for this request |
| public int getAchievedRf() { |
| // look across all shards to find the minimum achieved replication |
| // factor ... unless the client is using direct updates from CloudSolrServer |
| // there may be multiple shards at play here |
| int achievedRf = 1; |
| if (onLeaderShardId != null) { |
| synchronized (nodeErrorTracker) { |
| for (AtomicInteger nodeErrors : nodeErrorTracker.values()) { |
| if (nodeErrors.get() == 0) |
| ++achievedRf; |
| } |
| } |
| } else { |
| // the node driving this updateRequest is not a leader and so |
| // it only forwards to other leaders, so its local result doesn't count |
| achievedRf = Integer.MAX_VALUE; |
| } |
| |
| // min achieved may come from a request to another leader |
| synchronized (otherLeaderRf) { |
| for (Integer otherRf : otherLeaderRf.values()) { |
| if (otherRf < achievedRf) |
| achievedRf = otherRf; |
| } |
| } |
| |
| return (achievedRf == Integer.MAX_VALUE) ? 1 : achievedRf; |
| } |
| |
| public void trackRequestResult(Node node, boolean success, Integer rf) { |
| String shardId = node.getShardId(); |
| |
| if (log.isDebugEnabled()) |
| log.debug("trackRequestResult("+node+"): success? "+success+" rf="+rf+ |
| ", shardId="+shardId+" onLeaderShardId="+onLeaderShardId); |
| |
| if (onLeaderShardId == null || !onLeaderShardId.equals(shardId)) { |
| // result from another leader that we forwarded to |
| synchronized (otherLeaderRf) { |
| otherLeaderRf.put(shardId, rf != null ? rf : new Integer(1)); |
| } |
| return; |
| } |
| |
| if (onLeaderShardId != null) { |
| // track result for this leader |
| String nodeUrl = node.getUrl(); |
| AtomicInteger nodeErrors = null; |
| // potentially many results flooding into this method from multiple nodes concurrently |
| synchronized (nodeErrorTracker) { |
| nodeErrors = nodeErrorTracker.get(nodeUrl); |
| if (nodeErrors == null) { |
| nodeErrors = new AtomicInteger(0); |
| nodeErrorTracker.put(nodeUrl, nodeErrors); |
| } |
| } |
| |
| if (!success) |
| nodeErrors.incrementAndGet(); |
| } |
| } |
| |
| public String toString() { |
| StringBuilder sb = new StringBuilder("RequestReplicationTracker"); |
| sb.append(": onLeaderShardId=").append(String.valueOf(onLeaderShardId)); |
| sb.append(", minRf=").append(minRf); |
| sb.append(", achievedRf=").append(getAchievedRf()); |
| return sb.toString(); |
| } |
| } |
| |
| public static final String COMMIT_END_POINT = "commit_end_point"; |
| public static final String LOG_REPLAY = "log_replay"; |
| |
| private final SolrQueryRequest req; |
| private final SolrQueryResponse rsp; |
| private final UpdateRequestProcessor next; |
| |
| public static final String VERSION_FIELD = "_version_"; |
| |
| private final UpdateHandler updateHandler; |
| private final UpdateLog ulog; |
| private final VersionInfo vinfo; |
| private final boolean versionsStored; |
| private boolean returnVersions = true; // todo: default to false and make configurable |
| |
| private NamedList addsResponse = null; |
| private NamedList deleteResponse = null; |
| private NamedList deleteByQueryResponse = null; |
| private CharsRef scratch; |
| |
| private final SchemaField idField; |
| |
| private SolrCmdDistributor cmdDistrib; |
| |
| private final boolean zkEnabled; |
| |
| private CloudDescriptor cloudDesc; |
| private final String collection; |
| private final ZkController zkController; |
| |
| // these are setup at the start of each request processing |
| // method in this update processor |
| private boolean isLeader = true; |
| private boolean forwardToLeader = false; |
| private boolean isSubShardLeader = false; |
| private List<Node> nodes; |
| |
| private UpdateCommand updateCommand; // the current command this processor is working on. |
| |
| //used for keeping track of replicas that have processed an add/update from the leader |
| private RequestReplicationTracker replicationTracker = null; |
| |
| public DistributedUpdateProcessor(SolrQueryRequest req, |
| SolrQueryResponse rsp, UpdateRequestProcessor next) { |
| super(next); |
| this.rsp = rsp; |
| this.next = next; |
| this.idField = req.getSchema().getUniqueKeyField(); |
| // version init |
| |
| this.updateHandler = req.getCore().getUpdateHandler(); |
| this.ulog = updateHandler.getUpdateLog(); |
| this.vinfo = ulog == null ? null : ulog.getVersionInfo(); |
| versionsStored = this.vinfo != null && this.vinfo.getVersionField() != null; |
| returnVersions = req.getParams().getBool(UpdateParams.VERSIONS ,false); |
| |
| // TODO: better way to get the response, or pass back info to it? |
| SolrRequestInfo reqInfo = returnVersions ? SolrRequestInfo.getRequestInfo() : null; |
| |
| this.req = req; |
| |
| CoreDescriptor coreDesc = req.getCore().getCoreDescriptor(); |
| |
| this.zkEnabled = coreDesc.getCoreContainer().isZooKeeperAware(); |
| zkController = req.getCore().getCoreDescriptor().getCoreContainer().getZkController(); |
| if (zkEnabled) { |
| cmdDistrib = new SolrCmdDistributor(coreDesc.getCoreContainer().getUpdateShardHandler()); |
| } |
| //this.rsp = reqInfo != null ? reqInfo.getRsp() : null; |
| |
| cloudDesc = coreDesc.getCloudDescriptor(); |
| |
| if (cloudDesc != null) { |
| collection = cloudDesc.getCollectionName(); |
| } else { |
| collection = null; |
| } |
| |
| } |
| |
| |
| private List<Node> setupRequest(String id, SolrInputDocument doc) { |
| List<Node> nodes = null; |
| |
| // if we are in zk mode... |
| if (zkEnabled) { |
| |
| if ((updateCommand.getFlags() & (UpdateCommand.REPLAY | UpdateCommand.PEER_SYNC)) != 0) { |
| isLeader = false; // we actually might be the leader, but we don't want leader-logic for these types of updates anyway. |
| forwardToLeader = false; |
| return nodes; |
| } |
| |
| ClusterState cstate = zkController.getClusterState(); |
| DocCollection coll = cstate.getCollection(collection); |
| Slice slice = coll.getRouter().getTargetSlice(id, doc, req.getParams(), coll); |
| |
| if (slice == null) { |
| // No slice found. Most strict routers will have already thrown an exception, so a null return is |
| // a signal to use the slice of this core. |
| // TODO: what if this core is not in the targeted collection? |
| String shardId = req.getCore().getCoreDescriptor().getCloudDescriptor().getShardId(); |
| slice = coll.getSlice(shardId); |
| if (slice == null) { |
| throw new SolrException(ErrorCode.BAD_REQUEST, "No shard " + shardId + " in " + coll); |
| } |
| } |
| |
| DistribPhase phase = |
| DistribPhase.parseParam(req.getParams().get(DISTRIB_UPDATE_PARAM)); |
| |
| if (DistribPhase.FROMLEADER == phase && !couldIbeSubShardLeader(coll)) { |
| if (req.getCore().getCoreDescriptor().getCloudDescriptor().isLeader()) { |
| // locally we think we are leader but the request says it came FROMLEADER |
| // that could indicate a problem, let the full logic below figure it out |
| } else { |
| isLeader = false; // we actually might be the leader, but we don't want leader-logic for these types of updates anyway. |
| forwardToLeader = false; |
| return nodes; |
| } |
| } |
| |
| String shardId = slice.getName(); |
| |
| try { |
| // Not equivalent to getLeaderProps, which does retries to find a leader. |
| // Replica leader = slice.getLeader(); |
| Replica leaderReplica = zkController.getZkStateReader().getLeaderRetry( |
| collection, shardId); |
| isLeader = leaderReplica.getName().equals( |
| req.getCore().getCoreDescriptor().getCloudDescriptor() |
| .getCoreNodeName()); |
| |
| if (!isLeader) { |
| isSubShardLeader = amISubShardLeader(coll, slice, id, doc); |
| if (isSubShardLeader) { |
| String myShardId = req.getCore().getCoreDescriptor().getCloudDescriptor().getShardId(); |
| slice = coll.getSlice(myShardId); |
| shardId = myShardId; |
| leaderReplica = zkController.getZkStateReader().getLeaderRetry(collection, myShardId); |
| List<ZkCoreNodeProps> myReplicas = zkController.getZkStateReader().getReplicaProps(collection, shardId, leaderReplica.getName(), null, ZkStateReader.DOWN); |
| } |
| } |
| |
| doDefensiveChecks(phase); |
| |
| // if request is coming from another collection then we want it to be sent to all replicas |
| // even if it's phase is FROMLEADER |
| String fromCollection = updateCommand.getReq().getParams().get(DISTRIB_FROM_COLLECTION); |
| |
| if (DistribPhase.FROMLEADER == phase && !isSubShardLeader && fromCollection == null) { |
| // we are coming from the leader, just go local - add no urls |
| forwardToLeader = false; |
| } else if (isLeader || isSubShardLeader) { |
| // that means I want to forward onto my replicas... |
| // so get the replicas... |
| forwardToLeader = false; |
| List<ZkCoreNodeProps> replicaProps = zkController.getZkStateReader() |
| .getReplicaProps(collection, shardId, leaderReplica.getName(), null, ZkStateReader.DOWN); |
| |
| if (replicaProps != null) { |
| if (nodes == null) { |
| nodes = new ArrayList<>(replicaProps.size()); |
| } |
| // check for test param that lets us miss replicas |
| String[] skipList = req.getParams().getParams(TEST_DISTRIB_SKIP_SERVERS); |
| Set<String> skipListSet = null; |
| if (skipList != null) { |
| skipListSet = new HashSet<>(skipList.length); |
| skipListSet.addAll(Arrays.asList(skipList)); |
| log.info("test.distrib.skip.servers was found and contains:" + skipListSet); |
| } |
| |
| for (ZkCoreNodeProps props : replicaProps) { |
| if (skipList != null) { |
| boolean skip = skipListSet.contains(props.getCoreUrl()); |
| log.info("check url:" + props.getCoreUrl() + " against:" + skipListSet + " result:" + skip); |
| if (!skip) { |
| nodes.add(new StdNode(props, collection, shardId)); |
| } |
| } else { |
| nodes.add(new StdNode(props, collection, shardId)); |
| } |
| } |
| } |
| |
| } else { |
| // I need to forward onto the leader... |
| nodes = new ArrayList<>(1); |
| nodes.add(new RetryNode(new ZkCoreNodeProps(leaderReplica), zkController.getZkStateReader(), collection, shardId)); |
| forwardToLeader = true; |
| } |
| |
| } catch (InterruptedException e) { |
| Thread.currentThread().interrupt(); |
| throw new ZooKeeperException(SolrException.ErrorCode.SERVER_ERROR, "", |
| e); |
| } |
| } |
| |
| return nodes; |
| } |
| |
| private boolean couldIbeSubShardLeader(DocCollection coll) { |
| // Could I be the leader of a shard in "construction/recovery" state? |
| String myShardId = req.getCore().getCoreDescriptor().getCloudDescriptor() |
| .getShardId(); |
| Slice mySlice = coll.getSlice(myShardId); |
| String state = mySlice.getState(); |
| return (Slice.CONSTRUCTION.equals(state) || Slice.RECOVERY.equals(state)); |
| } |
| |
| private boolean amISubShardLeader(DocCollection coll, Slice parentSlice, String id, SolrInputDocument doc) throws InterruptedException { |
| // Am I the leader of a shard in "construction/recovery" state? |
| String myShardId = req.getCore().getCoreDescriptor().getCloudDescriptor().getShardId(); |
| Slice mySlice = coll.getSlice(myShardId); |
| String state = mySlice.getState(); |
| if (Slice.CONSTRUCTION.equals(state) || Slice.RECOVERY.equals(state)) { |
| Replica myLeader = zkController.getZkStateReader().getLeaderRetry(collection, myShardId); |
| boolean amILeader = myLeader.getName().equals( |
| req.getCore().getCoreDescriptor().getCloudDescriptor() |
| .getCoreNodeName()); |
| if (amILeader) { |
| // Does the document belong to my hash range as well? |
| DocRouter.Range myRange = mySlice.getRange(); |
| if (myRange == null) myRange = new DocRouter.Range(Integer.MIN_VALUE, Integer.MAX_VALUE); |
| if (parentSlice != null) { |
| boolean isSubset = parentSlice.getRange() != null && myRange.isSubsetOf(parentSlice.getRange()); |
| return isSubset && coll.getRouter().isTargetSlice(id, doc, req.getParams(), myShardId, coll); |
| } else { |
| // delete by query case -- as long as I am a sub shard leader we're fine |
| return true; |
| } |
| } |
| } |
| return false; |
| } |
| |
| private List<Node> getSubShardLeaders(DocCollection coll, String shardId, String docId, SolrInputDocument doc) { |
| Collection<Slice> allSlices = coll.getSlices(); |
| List<Node> nodes = null; |
| for (Slice aslice : allSlices) { |
| if (Slice.CONSTRUCTION.equals(aslice.getState()) || Slice.RECOVERY.equals(aslice.getState())) { |
| DocRouter.Range myRange = coll.getSlice(shardId).getRange(); |
| if (myRange == null) myRange = new DocRouter.Range(Integer.MIN_VALUE, Integer.MAX_VALUE); |
| boolean isSubset = aslice.getRange() != null && aslice.getRange().isSubsetOf(myRange); |
| if (isSubset && |
| (docId == null // in case of deletes |
| || (docId != null && coll.getRouter().isTargetSlice(docId, doc, req.getParams(), aslice.getName(), coll)))) { |
| Replica sliceLeader = aslice.getLeader(); |
| // slice leader can be null because node/shard is created zk before leader election |
| if (sliceLeader != null && zkController.getClusterState().liveNodesContain(sliceLeader.getNodeName())) { |
| if (nodes == null) nodes = new ArrayList<>(); |
| ZkCoreNodeProps nodeProps = new ZkCoreNodeProps(sliceLeader); |
| nodes.add(new StdNode(nodeProps, coll.getName(), shardId)); |
| } |
| } |
| } |
| } |
| return nodes; |
| } |
| |
| private List<Node> getNodesByRoutingRules(ClusterState cstate, DocCollection coll, String id, SolrInputDocument doc) { |
| DocRouter router = coll.getRouter(); |
| List<Node> nodes = null; |
| if (router instanceof CompositeIdRouter) { |
| CompositeIdRouter compositeIdRouter = (CompositeIdRouter) router; |
| String myShardId = req.getCore().getCoreDescriptor().getCloudDescriptor().getShardId(); |
| Slice slice = coll.getSlice(myShardId); |
| Map<String, RoutingRule> routingRules = slice.getRoutingRules(); |
| if (routingRules != null) { |
| |
| // delete by query case |
| if (id == null) { |
| for (Entry<String, RoutingRule> entry : routingRules.entrySet()) { |
| String targetCollectionName = entry.getValue().getTargetCollectionName(); |
| Collection<Slice> activeSlices = cstate.getActiveSlices(targetCollectionName); |
| if (activeSlices != null && !activeSlices.isEmpty()) { |
| Slice any = activeSlices.iterator().next(); |
| if (nodes == null) nodes = new ArrayList<>(); |
| nodes.add(new StdNode(new ZkCoreNodeProps(any.getLeader()))); |
| } |
| } |
| return nodes; |
| } |
| |
| String routeKey = SolrIndexSplitter.getRouteKey(id); |
| if (routeKey != null) { |
| RoutingRule rule = routingRules.get(routeKey + "!"); |
| if (rule != null) { |
| // TODO: look at using nanoTime |
| if (rule.getExpireAt() >= System.currentTimeMillis()) { |
| List<DocRouter.Range> ranges = rule.getRouteRanges(); |
| if (ranges != null && !ranges.isEmpty()) { |
| int hash = compositeIdRouter.sliceHash(id, doc, null, coll); |
| for (DocRouter.Range range : ranges) { |
| if (range.includes(hash)) { |
| if (nodes == null) nodes = new ArrayList<>(); |
| DocCollection targetColl = cstate.getCollection(rule.getTargetCollectionName()); |
| Collection<Slice> activeSlices = targetColl.getRouter().getSearchSlicesSingle(id, null, targetColl); |
| if (activeSlices == null || activeSlices.isEmpty()) { |
| throw new SolrException(ErrorCode.SERVER_ERROR, |
| "No active slices serving " + id + " found for target collection: " + rule.getTargetCollectionName()); |
| } |
| Replica targetLeader = cstate.getLeader(rule.getTargetCollectionName(), activeSlices.iterator().next().getName()); |
| nodes.add(new StdNode(new ZkCoreNodeProps(targetLeader))); |
| break; |
| } |
| } |
| } |
| } else { |
| ReentrantLock ruleExpiryLock = req.getCore().getRuleExpiryLock(); |
| if (!ruleExpiryLock.isLocked()) { |
| try { |
| if (ruleExpiryLock.tryLock(10, TimeUnit.MILLISECONDS)) { |
| log.info("Going to expire routing rule"); |
| try { |
| Map<String, Object> map = ZkNodeProps.makeMap(Overseer.QUEUE_OPERATION, Overseer.OverseerAction.REMOVEROUTINGRULE.toLower(), |
| ZkStateReader.COLLECTION_PROP, collection, |
| ZkStateReader.SHARD_ID_PROP, myShardId, |
| "routeKey", routeKey + "!"); |
| SolrZkClient zkClient = req.getCore().getCoreDescriptor().getCoreContainer().getZkController().getZkClient(); |
| DistributedQueue queue = Overseer.getInQueue(zkClient); |
| queue.offer(ZkStateReader.toJSON(map)); |
| } catch (KeeperException e) { |
| log.warn("Exception while removing routing rule for route key: " + routeKey, e); |
| } catch (Exception e) { |
| log.error("Exception while removing routing rule for route key: " + routeKey, e); |
| } finally { |
| ruleExpiryLock.unlock(); |
| } |
| } |
| } catch (InterruptedException e) { |
| Thread.currentThread().interrupt(); |
| } |
| } |
| } |
| } |
| } |
| } |
| } |
| return nodes; |
| } |
| |
| private void doDefensiveChecks(DistribPhase phase) { |
| boolean isReplayOrPeersync = (updateCommand.getFlags() & (UpdateCommand.REPLAY | UpdateCommand.PEER_SYNC)) != 0; |
| if (isReplayOrPeersync) return; |
| |
| String from = req.getParams().get(DISTRIB_FROM); |
| ClusterState clusterState = zkController.getClusterState(); |
| |
| CloudDescriptor cloudDescriptor = req.getCore().getCoreDescriptor().getCloudDescriptor(); |
| Slice mySlice = clusterState.getSlice(collection, cloudDescriptor.getShardId()); |
| boolean localIsLeader = cloudDescriptor.isLeader(); |
| if (DistribPhase.FROMLEADER == phase && localIsLeader && from != null) { // from will be null on log replay |
| String fromShard = req.getParams().get(DISTRIB_FROM_PARENT); |
| if (fromShard != null) { |
| if (Slice.ACTIVE.equals(mySlice.getState())) { |
| throw new SolrException(ErrorCode.SERVICE_UNAVAILABLE, |
| "Request says it is coming from parent shard leader but we are in active state"); |
| } |
| // shard splitting case -- check ranges to see if we are a sub-shard |
| Slice fromSlice = zkController.getClusterState().getCollection(collection).getSlice(fromShard); |
| DocRouter.Range parentRange = fromSlice.getRange(); |
| if (parentRange == null) parentRange = new DocRouter.Range(Integer.MIN_VALUE, Integer.MAX_VALUE); |
| if (mySlice.getRange() != null && !mySlice.getRange().isSubsetOf(parentRange)) { |
| throw new SolrException(ErrorCode.SERVICE_UNAVAILABLE, |
| "Request says it is coming from parent shard leader but parent hash range is not superset of my range"); |
| } |
| } else { |
| String fromCollection = req.getParams().get(DISTRIB_FROM_COLLECTION); // is it because of a routing rule? |
| if (fromCollection == null) { |
| log.error("Request says it is coming from leader, but we are the leader: " + req.getParamString()); |
| throw new SolrException(ErrorCode.SERVICE_UNAVAILABLE, "Request says it is coming from leader, but we are the leader"); |
| } |
| } |
| } |
| |
| if ((isLeader && !localIsLeader) || (isSubShardLeader && !localIsLeader)) { |
| log.error("ClusterState says we are the leader, but locally we don't think so"); |
| throw new SolrException(ErrorCode.SERVICE_UNAVAILABLE, |
| "ClusterState says we are the leader (" + zkController.getBaseUrl() |
| + "/" + req.getCore().getName() + "), but locally we don't think so. Request came from " + from); |
| } |
| } |
| |
| |
| // used for deleteByQuery to get the list of nodes this leader should forward to |
| private List<Node> setupRequest() { |
| List<Node> nodes = null; |
| String shardId = cloudDesc.getShardId(); |
| |
| try { |
| Replica leaderReplica = zkController.getZkStateReader().getLeaderRetry( |
| collection, shardId); |
| isLeader = leaderReplica.getName().equals( |
| req.getCore().getCoreDescriptor().getCloudDescriptor() |
| .getCoreNodeName()); |
| |
| // TODO: what if we are no longer the leader? |
| |
| forwardToLeader = false; |
| List<ZkCoreNodeProps> replicaProps = zkController.getZkStateReader() |
| .getReplicaProps(collection, shardId, leaderReplica.getName()); |
| if (replicaProps != null) { |
| nodes = new ArrayList<>(replicaProps.size()); |
| for (ZkCoreNodeProps props : replicaProps) { |
| nodes.add(new StdNode(props, collection, shardId)); |
| } |
| } |
| } catch (InterruptedException e) { |
| Thread.currentThread().interrupt(); |
| throw new ZooKeeperException(SolrException.ErrorCode.SERVER_ERROR, "", |
| e); |
| } |
| |
| return nodes; |
| } |
| |
| |
| @Override |
| public void processAdd(AddUpdateCommand cmd) throws IOException { |
| updateCommand = cmd; |
| |
| if (zkEnabled) { |
| zkCheck(); |
| nodes = setupRequest(cmd.getHashableId(), cmd.getSolrInputDocument()); |
| } else { |
| isLeader = getNonZkLeaderAssumption(req); |
| } |
| |
| // check if client has requested minimum replication factor information |
| int minRf = -1; // disabled by default |
| if (replicationTracker != null) { |
| minRf = replicationTracker.minRf; // for subsequent requests in the same batch |
| } else { |
| SolrParams rp = cmd.getReq().getParams(); |
| String distribUpdate = rp.get(DISTRIB_UPDATE_PARAM); |
| // somewhat tricky logic here: we only activate the replication tracker if we're on |
| // a leader or this is the top-level request processor |
| if (distribUpdate == null || distribUpdate.equals(DistribPhase.TOLEADER.toString())) { |
| String minRepFact = rp.get(UpdateRequest.MIN_REPFACT); |
| if (minRepFact != null) { |
| try { |
| minRf = Integer.parseInt(minRepFact); |
| } catch (NumberFormatException nfe) { |
| minRf = -1; |
| } |
| |
| if (minRf <= 0) |
| throw new SolrException(ErrorCode.BAD_REQUEST, "Invalid value "+minRepFact+" for "+UpdateRequest.MIN_REPFACT+ |
| "; must be >0 and less than or equal to the collection replication factor."); |
| } |
| |
| if (minRf > 1) { |
| String myShardId = forwardToLeader ? null : cloudDesc.getShardId(); |
| replicationTracker = new RequestReplicationTracker(myShardId, minRf); |
| } |
| } |
| } |
| |
| // TODO: if minRf > 1 and we know the leader is the only active replica, we could fail |
| // the request right here but for now I think it is better to just return the status |
| // to the client that the minRf wasn't reached and let them handle it |
| |
| boolean dropCmd = false; |
| if (!forwardToLeader) { |
| dropCmd = versionAdd(cmd); |
| } |
| |
| if (dropCmd) { |
| // TODO: do we need to add anything to the response? |
| return; |
| } |
| |
| if (zkEnabled && isLeader && !isSubShardLeader) { |
| DocCollection coll = zkController.getClusterState().getCollection(collection); |
| List<Node> subShardLeaders = getSubShardLeaders(coll, cloudDesc.getShardId(), cmd.getHashableId(), cmd.getSolrInputDocument()); |
| // the list<node> will actually have only one element for an add request |
| if (subShardLeaders != null && !subShardLeaders.isEmpty()) { |
| ModifiableSolrParams params = new ModifiableSolrParams(filterParams(req.getParams())); |
| params.set(DISTRIB_UPDATE_PARAM, DistribPhase.FROMLEADER.toString()); |
| params.set(DISTRIB_FROM, ZkCoreNodeProps.getCoreUrl( |
| zkController.getBaseUrl(), req.getCore().getName())); |
| params.set(DISTRIB_FROM_PARENT, req.getCore().getCoreDescriptor().getCloudDescriptor().getShardId()); |
| for (Node subShardLeader : subShardLeaders) { |
| cmdDistrib.distribAdd(cmd, Collections.singletonList(subShardLeader), params, true); |
| } |
| } |
| List<Node> nodesByRoutingRules = getNodesByRoutingRules(zkController.getClusterState(), coll, cmd.getHashableId(), cmd.getSolrInputDocument()); |
| if (nodesByRoutingRules != null && !nodesByRoutingRules.isEmpty()) { |
| ModifiableSolrParams params = new ModifiableSolrParams(filterParams(req.getParams())); |
| params.set(DISTRIB_UPDATE_PARAM, DistribPhase.FROMLEADER.toString()); |
| params.set(DISTRIB_FROM, ZkCoreNodeProps.getCoreUrl( |
| zkController.getBaseUrl(), req.getCore().getName())); |
| |
| params.set(DISTRIB_FROM_COLLECTION, req.getCore().getCoreDescriptor().getCloudDescriptor().getCollectionName()); |
| params.set(DISTRIB_FROM_SHARD, req.getCore().getCoreDescriptor().getCloudDescriptor().getShardId()); |
| |
| for (Node nodesByRoutingRule : nodesByRoutingRules) { |
| cmdDistrib.distribAdd(cmd, Collections.singletonList(nodesByRoutingRule), params, true); |
| } |
| } |
| } |
| |
| ModifiableSolrParams params = null; |
| if (nodes != null) { |
| params = new ModifiableSolrParams(filterParams(req.getParams())); |
| params.set(DISTRIB_UPDATE_PARAM, |
| (isLeader || isSubShardLeader ? |
| DistribPhase.FROMLEADER.toString() : |
| DistribPhase.TOLEADER.toString())); |
| params.set(DISTRIB_FROM, ZkCoreNodeProps.getCoreUrl( |
| zkController.getBaseUrl(), req.getCore().getName())); |
| |
| if (replicationTracker != null && minRf > 1) |
| params.set(UpdateRequest.MIN_REPFACT, String.valueOf(minRf)); |
| |
| cmdDistrib.distribAdd(cmd, nodes, params, false, replicationTracker); |
| } |
| |
| // TODO: what to do when no idField? |
| if (returnVersions && rsp != null && idField != null) { |
| if (addsResponse == null) { |
| addsResponse = new NamedList<String>(); |
| rsp.add("adds",addsResponse); |
| } |
| if (scratch == null) scratch = new CharsRef(); |
| idField.getType().indexedToReadable(cmd.getIndexedId(), scratch); |
| addsResponse.add(scratch.toString(), cmd.getVersion()); |
| } |
| |
| // TODO: keep track of errors? needs to be done at a higher level though since |
| // an id may fail before it gets to this processor. |
| // Given that, it may also make sense to move the version reporting out of this |
| // processor too. |
| } |
| |
| // TODO: optionally fail if n replicas are not reached... |
| private void doFinish() { |
| // TODO: if not a forward and replication req is not specified, we could |
| // send in a background thread |
| |
| cmdDistrib.finish(); |
| List<Error> errors = cmdDistrib.getErrors(); |
| // TODO - we may need to tell about more than one error... |
| |
| // if its a forward, any fail is a problem - |
| // otherwise we assume things are fine if we got it locally |
| // until we start allowing min replication param |
| if (errors.size() > 0) { |
| // if one node is a RetryNode, this was a forward request |
| if (errors.get(0).req.node instanceof RetryNode) { |
| rsp.setException(errors.get(0).e); |
| } else { |
| if (log.isWarnEnabled()) { |
| for (Error error : errors) { |
| log.warn("Error sending update", error.e); |
| } |
| } |
| } |
| // else |
| // for now we don't error - we assume if it was added locally, we |
| // succeeded |
| } |
| |
| |
| // if it is not a forward request, for each fail, try to tell them to |
| // recover - the doc was already added locally, so it should have been |
| // legit |
| |
| for (final SolrCmdDistributor.Error error : errors) { |
| |
| if (error.req.node instanceof RetryNode) { |
| // we don't try to force a leader to recover |
| // when we cannot forward to it |
| continue; |
| } |
| |
| DistribPhase phase = |
| DistribPhase.parseParam(error.req.uReq.getParams().get(DISTRIB_UPDATE_PARAM)); |
| if (phase != DistribPhase.FROMLEADER) |
| continue; // don't have non-leaders try to recovery other nodes |
| |
| final String replicaUrl = error.req.node.getUrl(); |
| |
| int maxTries = 1; |
| boolean sendRecoveryCommand = true; |
| String collection = null; |
| String shardId = null; |
| |
| if (error.req.node instanceof StdNode) { |
| StdNode stdNode = (StdNode)error.req.node; |
| collection = stdNode.getCollection(); |
| shardId = stdNode.getShardId(); |
| try { |
| // if false, then the node is probably not "live" anymore |
| sendRecoveryCommand = |
| zkController.ensureReplicaInLeaderInitiatedRecovery(collection, |
| shardId, |
| replicaUrl, |
| stdNode.getNodeProps(), |
| false); |
| |
| // we want to try more than once, ~10 minutes |
| if (sendRecoveryCommand) { |
| maxTries = 120; |
| } // else the node is no longer "live" so no need to send any recovery command |
| |
| } catch (Exception e) { |
| log.error("Leader failed to set replica "+ |
| error.req.node.getUrl()+" state to DOWN due to: "+e, e); |
| } |
| } // else not a StdNode, recovery command still gets sent once |
| |
| if (!sendRecoveryCommand) |
| continue; // the replica is already in recovery handling or is not live |
| |
| Throwable rootCause = SolrException.getRootCause(error.e); |
| log.error("Setting up to try to start recovery on replica "+replicaUrl+" after: "+rootCause); |
| |
| // try to send the recovery command to the downed replica in a background thread |
| CoreContainer coreContainer = req.getCore().getCoreDescriptor().getCoreContainer(); |
| LeaderInitiatedRecoveryThread lirThread = |
| new LeaderInitiatedRecoveryThread(zkController, |
| coreContainer, |
| collection, |
| shardId, |
| error.req.node.getNodeProps(), |
| maxTries); |
| ExecutorService executor = coreContainer.getUpdateShardHandler().getUpdateExecutor(); |
| executor.execute(lirThread); |
| } |
| |
| if (replicationTracker != null) { |
| rsp.getResponseHeader().add(UpdateRequest.REPFACT, replicationTracker.getAchievedRf()); |
| rsp.getResponseHeader().add(UpdateRequest.MIN_REPFACT, replicationTracker.minRf); |
| replicationTracker = null; |
| } |
| } |
| |
| |
| // must be synchronized by bucket |
| private void doLocalAdd(AddUpdateCommand cmd) throws IOException { |
| super.processAdd(cmd); |
| } |
| |
| // must be synchronized by bucket |
| private void doLocalDelete(DeleteUpdateCommand cmd) throws IOException { |
| super.processDelete(cmd); |
| } |
| |
| /** |
| * @return whether or not to drop this cmd |
| * @throws IOException If there is a low-level I/O error. |
| */ |
| private boolean versionAdd(AddUpdateCommand cmd) throws IOException { |
| BytesRef idBytes = cmd.getIndexedId(); |
| |
| if (idBytes == null) { |
| super.processAdd(cmd); |
| return false; |
| } |
| |
| if (vinfo == null) { |
| if (isAtomicUpdate(cmd)) { |
| throw new SolrException |
| (SolrException.ErrorCode.BAD_REQUEST, |
| "Atomic document updates are not supported unless <updateLog/> is configured"); |
| } else { |
| super.processAdd(cmd); |
| return false; |
| } |
| } |
| |
| // This is only the hash for the bucket, and must be based only on the uniqueKey (i.e. do not use a pluggable hash here) |
| int bucketHash = Hash.murmurhash3_x86_32(idBytes.bytes, idBytes.offset, idBytes.length, 0); |
| |
| // at this point, there is an update we need to try and apply. |
| // we may or may not be the leader. |
| |
| // Find any existing version in the document |
| // TODO: don't reuse update commands any more! |
| long versionOnUpdate = cmd.getVersion(); |
| |
| if (versionOnUpdate == 0) { |
| SolrInputField versionField = cmd.getSolrInputDocument().getField(VersionInfo.VERSION_FIELD); |
| if (versionField != null) { |
| Object o = versionField.getValue(); |
| versionOnUpdate = o instanceof Number ? ((Number) o).longValue() : Long.parseLong(o.toString()); |
| } else { |
| // Find the version |
| String versionOnUpdateS = req.getParams().get(VERSION_FIELD); |
| versionOnUpdate = versionOnUpdateS == null ? 0 : Long.parseLong(versionOnUpdateS); |
| } |
| } |
| |
| boolean isReplayOrPeersync = (cmd.getFlags() & (UpdateCommand.REPLAY | UpdateCommand.PEER_SYNC)) != 0; |
| boolean leaderLogic = isLeader && !isReplayOrPeersync; |
| boolean forwardedFromCollection = cmd.getReq().getParams().get(DISTRIB_FROM_COLLECTION) != null; |
| |
| VersionBucket bucket = vinfo.bucket(bucketHash); |
| |
| vinfo.lockForUpdate(); |
| try { |
| synchronized (bucket) { |
| // we obtain the version when synchronized and then do the add so we can ensure that |
| // if version1 < version2 then version1 is actually added before version2. |
| |
| // even if we don't store the version field, synchronizing on the bucket |
| // will enable us to know what version happened first, and thus enable |
| // realtime-get to work reliably. |
| // TODO: if versions aren't stored, do we need to set on the cmd anyway for some reason? |
| // there may be other reasons in the future for a version on the commands |
| |
| boolean checkDeleteByQueries = false; |
| |
| if (versionsStored) { |
| |
| long bucketVersion = bucket.highest; |
| |
| if (leaderLogic) { |
| |
| if (forwardedFromCollection && ulog.getState() == UpdateLog.State.ACTIVE) { |
| // forwarded from a collection but we are not buffering so strip original version and apply our own |
| // see SOLR-5308 |
| log.info("Removing version field from doc: " + cmd.getPrintableId()); |
| cmd.solrDoc.remove(VERSION_FIELD); |
| versionOnUpdate = 0; |
| } |
| |
| boolean updated = getUpdatedDocument(cmd, versionOnUpdate); |
| |
| // leaders can also be in buffering state during "migrate" API call, see SOLR-5308 |
| if (forwardedFromCollection && ulog.getState() != UpdateLog.State.ACTIVE |
| && (cmd.getFlags() & UpdateCommand.REPLAY) == 0) { |
| // we're not in an active state, and this update isn't from a replay, so buffer it. |
| log.info("Leader logic applied but update log is buffering: " + cmd.getPrintableId()); |
| cmd.setFlags(cmd.getFlags() | UpdateCommand.BUFFERING); |
| ulog.add(cmd); |
| return true; |
| } |
| |
| if (versionOnUpdate != 0) { |
| Long lastVersion = vinfo.lookupVersion(cmd.getIndexedId()); |
| long foundVersion = lastVersion == null ? -1 : lastVersion; |
| if ( versionOnUpdate == foundVersion || (versionOnUpdate < 0 && foundVersion < 0) || (versionOnUpdate==1 && foundVersion > 0) ) { |
| // we're ok if versions match, or if both are negative (all missing docs are equal), or if cmd |
| // specified it must exist (versionOnUpdate==1) and it does. |
| } else { |
| throw new SolrException(ErrorCode.CONFLICT, "version conflict for " + cmd.getPrintableId() + " expected=" + versionOnUpdate + " actual=" + foundVersion); |
| } |
| } |
| |
| |
| long version = vinfo.getNewClock(); |
| cmd.setVersion(version); |
| cmd.getSolrInputDocument().setField(VersionInfo.VERSION_FIELD, version); |
| bucket.updateHighest(version); |
| } else { |
| // The leader forwarded us this update. |
| cmd.setVersion(versionOnUpdate); |
| |
| if (ulog.getState() != UpdateLog.State.ACTIVE && (cmd.getFlags() & UpdateCommand.REPLAY) == 0) { |
| // we're not in an active state, and this update isn't from a replay, so buffer it. |
| cmd.setFlags(cmd.getFlags() | UpdateCommand.BUFFERING); |
| ulog.add(cmd); |
| return true; |
| } |
| |
| // if we aren't the leader, then we need to check that updates were not re-ordered |
| if (bucketVersion != 0 && bucketVersion < versionOnUpdate) { |
| // we're OK... this update has a version higher than anything we've seen |
| // in this bucket so far, so we know that no reordering has yet occurred. |
| bucket.updateHighest(versionOnUpdate); |
| } else { |
| // there have been updates higher than the current update. we need to check |
| // the specific version for this id. |
| Long lastVersion = vinfo.lookupVersion(cmd.getIndexedId()); |
| if (lastVersion != null && Math.abs(lastVersion) >= versionOnUpdate) { |
| // This update is a repeat, or was reordered. We need to drop this update. |
| return true; |
| } |
| |
| // also need to re-apply newer deleteByQuery commands |
| checkDeleteByQueries = true; |
| } |
| } |
| } |
| |
| boolean willDistrib = isLeader && nodes != null && nodes.size() > 0; |
| |
| SolrInputDocument clonedDoc = null; |
| if (willDistrib) { |
| clonedDoc = cmd.solrDoc.deepCopy(); |
| } |
| |
| // TODO: possibly set checkDeleteByQueries as a flag on the command? |
| doLocalAdd(cmd); |
| |
| if (willDistrib) { |
| cmd.solrDoc = clonedDoc; |
| } |
| |
| } // end synchronized (bucket) |
| } finally { |
| vinfo.unlockForUpdate(); |
| } |
| return false; |
| } |
| |
| /** |
| * Utility method that examines the SolrInputDocument in an AddUpdateCommand |
| * and returns true if the documents contains atomic update instructions. |
| */ |
| public static boolean isAtomicUpdate(final AddUpdateCommand cmd) { |
| SolrInputDocument sdoc = cmd.getSolrInputDocument(); |
| for (SolrInputField sif : sdoc.values()) { |
| if (sif.getValue() instanceof Map) { |
| return true; |
| } |
| } |
| return false; |
| } |
| |
| // TODO: may want to switch to using optimistic locking in the future for better concurrency |
| // that's why this code is here... need to retry in a loop closely around/in versionAdd |
| boolean getUpdatedDocument(AddUpdateCommand cmd, long versionOnUpdate) throws IOException { |
| if (!isAtomicUpdate(cmd)) return false; |
| |
| SolrInputDocument sdoc = cmd.getSolrInputDocument(); |
| BytesRef id = cmd.getIndexedId(); |
| SolrInputDocument oldDoc = RealTimeGetComponent.getInputDocument(cmd.getReq().getCore(), id); |
| |
| if (oldDoc == null) { |
| // create a new doc by default if an old one wasn't found |
| if (versionOnUpdate <= 0) { |
| oldDoc = new SolrInputDocument(); |
| } else { |
| // could just let the optimistic locking throw the error |
| throw new SolrException(ErrorCode.CONFLICT, "Document not found for update. id=" + cmd.getPrintableId()); |
| } |
| } else { |
| oldDoc.remove(VERSION_FIELD); |
| } |
| |
| IndexSchema schema = cmd.getReq().getSchema(); |
| for (SolrInputField sif : sdoc.values()) { |
| Object val = sif.getValue(); |
| if (val instanceof Map) { |
| for (Entry<String,Object> entry : ((Map<String,Object>) val).entrySet()) { |
| String key = entry.getKey(); |
| Object fieldVal = entry.getValue(); |
| boolean updateField = false; |
| switch (key) { |
| case "add": |
| updateField = true; |
| oldDoc.addField(sif.getName(), fieldVal, sif.getBoost()); |
| break; |
| case "set": |
| updateField = true; |
| oldDoc.setField(sif.getName(), fieldVal, sif.getBoost()); |
| break; |
| case "remove": |
| updateField = true; |
| doRemove(oldDoc, sif, fieldVal); |
| break; |
| case "inc": |
| updateField = true; |
| doInc(oldDoc, schema, sif, fieldVal); |
| break; |
| default: |
| //Perhaps throw an error here instead? |
| log.warn("Unknown operation for the an atomic update, operation ignored: " + key); |
| break; |
| } |
| // validate that the field being modified is not the id field. |
| if (updateField && idField.getName().equals(sif.getName())) { |
| throw new SolrException(ErrorCode.BAD_REQUEST, "Invalid update of id field: " + sif); |
| } |
| |
| } |
| } else { |
| // normal fields are treated as a "set" |
| oldDoc.put(sif.getName(), sif); |
| } |
| |
| } |
| |
| cmd.solrDoc = oldDoc; |
| return true; |
| } |
| |
| private void doInc(SolrInputDocument oldDoc, IndexSchema schema, SolrInputField sif, Object fieldVal) { |
| SolrInputField numericField = oldDoc.get(sif.getName()); |
| if (numericField == null) { |
| oldDoc.setField(sif.getName(), fieldVal, sif.getBoost()); |
| } else { |
| // TODO: fieldtype needs externalToObject? |
| String oldValS = numericField.getFirstValue().toString(); |
| SchemaField sf = schema.getField(sif.getName()); |
| BytesRef term = new BytesRef(); |
| sf.getType().readableToIndexed(oldValS, term); |
| Object oldVal = sf.getType().toObject(sf, term); |
| |
| String fieldValS = fieldVal.toString(); |
| Number result; |
| if (oldVal instanceof Long) { |
| result = ((Long) oldVal).longValue() + Long.parseLong(fieldValS); |
| } else if (oldVal instanceof Float) { |
| result = ((Float) oldVal).floatValue() + Float.parseFloat(fieldValS); |
| } else if (oldVal instanceof Double) { |
| result = ((Double) oldVal).doubleValue() + Double.parseDouble(fieldValS); |
| } else { |
| // int, short, byte |
| result = ((Integer) oldVal).intValue() + Integer.parseInt(fieldValS); |
| } |
| |
| oldDoc.setField(sif.getName(), result, sif.getBoost()); |
| } |
| } |
| |
| private void doRemove(SolrInputDocument oldDoc, SolrInputField sif, Object fieldVal) { |
| final String name = sif.getName(); |
| SolrInputField existingField = oldDoc.get(name); |
| if (existingField != null) { |
| final Collection<Object> original = existingField.getValues(); |
| if (fieldVal instanceof Collection) { |
| original.removeAll((Collection) fieldVal); |
| } else { |
| original.remove(fieldVal); |
| } |
| |
| oldDoc.setField(name, original); |
| |
| } |
| } |
| |
| |
| @Override |
| public void processDelete(DeleteUpdateCommand cmd) throws IOException { |
| updateCommand = cmd; |
| |
| if (!cmd.isDeleteById()) { |
| doDeleteByQuery(cmd); |
| return; |
| } |
| |
| if (zkEnabled) { |
| zkCheck(); |
| nodes = setupRequest(cmd.getId(), null); |
| } else { |
| isLeader = getNonZkLeaderAssumption(req); |
| } |
| |
| boolean dropCmd = false; |
| if (!forwardToLeader) { |
| dropCmd = versionDelete(cmd); |
| } |
| |
| if (dropCmd) { |
| // TODO: do we need to add anything to the response? |
| return; |
| } |
| |
| if (zkEnabled && isLeader && !isSubShardLeader) { |
| DocCollection coll = zkController.getClusterState().getCollection(collection); |
| List<Node> subShardLeaders = getSubShardLeaders(coll, cloudDesc.getShardId(), cmd.getId(), null); |
| // the list<node> will actually have only one element for an add request |
| if (subShardLeaders != null && !subShardLeaders.isEmpty()) { |
| ModifiableSolrParams params = new ModifiableSolrParams(filterParams(req.getParams())); |
| params.set(DISTRIB_UPDATE_PARAM, DistribPhase.FROMLEADER.toString()); |
| params.set(DISTRIB_FROM, ZkCoreNodeProps.getCoreUrl( |
| zkController.getBaseUrl(), req.getCore().getName())); |
| params.set(DISTRIB_FROM_PARENT, cloudDesc.getShardId()); |
| cmdDistrib.distribDelete(cmd, subShardLeaders, params, true); |
| } |
| |
| List<Node> nodesByRoutingRules = getNodesByRoutingRules(zkController.getClusterState(), coll, cmd.getId(), null); |
| if (nodesByRoutingRules != null && !nodesByRoutingRules.isEmpty()) { |
| ModifiableSolrParams params = new ModifiableSolrParams(filterParams(req.getParams())); |
| params.set(DISTRIB_UPDATE_PARAM, DistribPhase.FROMLEADER.toString()); |
| params.set(DISTRIB_FROM, ZkCoreNodeProps.getCoreUrl( |
| zkController.getBaseUrl(), req.getCore().getName())); |
| params.set(DISTRIB_FROM_COLLECTION, req.getCore().getCoreDescriptor().getCloudDescriptor().getCollectionName()); |
| params.set(DISTRIB_FROM_SHARD, req.getCore().getCoreDescriptor().getCloudDescriptor().getShardId()); |
| for (Node nodesByRoutingRule : nodesByRoutingRules) { |
| cmdDistrib.distribDelete(cmd, Collections.singletonList(nodesByRoutingRule), params, true); |
| } |
| } |
| } |
| |
| |
| ModifiableSolrParams params = null; |
| if (nodes != null) { |
| |
| params = new ModifiableSolrParams(filterParams(req.getParams())); |
| params.set(DISTRIB_UPDATE_PARAM, |
| (isLeader || isSubShardLeader ? DistribPhase.FROMLEADER.toString() |
| : DistribPhase.TOLEADER.toString())); |
| params.set(DISTRIB_FROM, ZkCoreNodeProps.getCoreUrl( |
| zkController.getBaseUrl(), req.getCore().getName())); |
| |
| cmdDistrib.distribDelete(cmd, nodes, params); |
| } |
| |
| // cmd.getIndexId == null when delete by query |
| // TODO: what to do when no idField? |
| if (returnVersions && rsp != null && cmd.getIndexedId() != null && idField != null) { |
| if (deleteResponse == null) { |
| deleteResponse = new NamedList<String>(); |
| rsp.add("deletes",deleteResponse); |
| } |
| if (scratch == null) scratch = new CharsRef(); |
| idField.getType().indexedToReadable(cmd.getIndexedId(), scratch); |
| deleteResponse.add(scratch.toString(), cmd.getVersion()); // we're returning the version of the delete.. not the version of the doc we deleted. |
| } |
| } |
| |
| private ModifiableSolrParams filterParams(SolrParams params) { |
| ModifiableSolrParams fparams = new ModifiableSolrParams(); |
| passParam(params, fparams, UpdateParams.UPDATE_CHAIN); |
| passParam(params, fparams, TEST_DISTRIB_SKIP_SERVERS); |
| return fparams; |
| } |
| |
| private void passParam(SolrParams params, ModifiableSolrParams fparams, String param) { |
| String[] values = params.getParams(param); |
| if (values != null) { |
| for (String value : values) { |
| fparams.add(param, value); |
| } |
| } |
| } |
| |
| public void doDeleteByQuery(DeleteUpdateCommand cmd) throws IOException { |
| // even in non zk mode, tests simulate updates from a leader |
| if(!zkEnabled) { |
| isLeader = getNonZkLeaderAssumption(req); |
| } else { |
| zkCheck(); |
| } |
| |
| // NONE: we are the first to receive this deleteByQuery |
| // - it must be forwarded to the leader of every shard |
| // TO: we are a leader receiving a forwarded deleteByQuery... we must: |
| // - block all updates (use VersionInfo) |
| // - flush *all* updates going to our replicas |
| // - forward the DBQ to our replicas and wait for the response |
| // - log + execute the local DBQ |
| // FROM: we are a replica receiving a DBQ from our leader |
| // - log + execute the local DBQ |
| DistribPhase phase = |
| DistribPhase.parseParam(req.getParams().get(DISTRIB_UPDATE_PARAM)); |
| |
| DocCollection coll = zkEnabled |
| ? zkController.getClusterState().getCollection(collection) : null; |
| |
| if (zkEnabled && DistribPhase.NONE == phase) { |
| boolean leaderForAnyShard = false; // start off by assuming we are not a leader for any shard |
| |
| ModifiableSolrParams outParams = new ModifiableSolrParams(filterParams(req.getParams())); |
| outParams.set(DISTRIB_UPDATE_PARAM, DistribPhase.TOLEADER.toString()); |
| outParams.set(DISTRIB_FROM, ZkCoreNodeProps.getCoreUrl( |
| zkController.getBaseUrl(), req.getCore().getName())); |
| |
| SolrParams params = req.getParams(); |
| String route = params.get(ShardParams._ROUTE_); |
| if(route == null) route = params.get(ShardParams.SHARD_KEYS);// deprecated . kept for backcompat |
| Collection<Slice> slices = coll.getRouter().getSearchSlices(route, params, coll); |
| |
| List<Node> leaders = new ArrayList<>(slices.size()); |
| for (Slice slice : slices) { |
| String sliceName = slice.getName(); |
| Replica leader; |
| try { |
| leader = zkController.getZkStateReader().getLeaderRetry(collection, sliceName); |
| } catch (InterruptedException e) { |
| throw new SolrException(ErrorCode.SERVICE_UNAVAILABLE, "Exception finding leader for shard " + sliceName, e); |
| } |
| |
| // TODO: What if leaders changed in the meantime? |
| // should we send out slice-at-a-time and if a node returns "hey, I'm not a leader" (or we get an error because it went down) then look up the new leader? |
| |
| // Am I the leader for this slice? |
| ZkCoreNodeProps coreLeaderProps = new ZkCoreNodeProps(leader); |
| String leaderCoreNodeName = leader.getName(); |
| String coreNodeName = req.getCore().getCoreDescriptor().getCloudDescriptor().getCoreNodeName(); |
| isLeader = coreNodeName.equals(leaderCoreNodeName); |
| |
| if (isLeader) { |
| // don't forward to ourself |
| leaderForAnyShard = true; |
| } else { |
| leaders.add(new StdNode(coreLeaderProps, collection, sliceName)); |
| } |
| } |
| |
| outParams.remove("commit"); // this will be distributed from the local commit |
| cmdDistrib.distribDelete(cmd, leaders, outParams); |
| |
| if (!leaderForAnyShard) { |
| return; |
| } |
| |
| // change the phase to TOLEADER so we look up and forward to our own replicas (if any) |
| phase = DistribPhase.TOLEADER; |
| } |
| |
| List<Node> replicas = null; |
| |
| if (zkEnabled && DistribPhase.TOLEADER == phase) { |
| // This core should be a leader |
| isLeader = true; |
| replicas = setupRequest(); |
| } else if (DistribPhase.FROMLEADER == phase) { |
| isLeader = false; |
| } |
| |
| if (vinfo == null) { |
| super.processDelete(cmd); |
| return; |
| } |
| |
| // at this point, there is an update we need to try and apply. |
| // we may or may not be the leader. |
| |
| // Find the version |
| long versionOnUpdate = cmd.getVersion(); |
| if (versionOnUpdate == 0) { |
| String versionOnUpdateS = req.getParams().get(VERSION_FIELD); |
| versionOnUpdate = versionOnUpdateS == null ? 0 : Long.parseLong(versionOnUpdateS); |
| } |
| versionOnUpdate = Math.abs(versionOnUpdate); // normalize to positive version |
| |
| boolean isReplayOrPeersync = (cmd.getFlags() & (UpdateCommand.REPLAY | UpdateCommand.PEER_SYNC)) != 0; |
| boolean leaderLogic = isLeader && !isReplayOrPeersync; |
| |
| if (!leaderLogic && versionOnUpdate==0) { |
| throw new SolrException(ErrorCode.BAD_REQUEST, "missing _version_ on update from leader"); |
| } |
| |
| vinfo.blockUpdates(); |
| try { |
| |
| if (versionsStored) { |
| if (leaderLogic) { |
| long version = vinfo.getNewClock(); |
| cmd.setVersion(-version); |
| // TODO update versions in all buckets |
| |
| doLocalDelete(cmd); |
| |
| } else { |
| cmd.setVersion(-versionOnUpdate); |
| |
| if (ulog.getState() != UpdateLog.State.ACTIVE && (cmd.getFlags() & UpdateCommand.REPLAY) == 0) { |
| // we're not in an active state, and this update isn't from a replay, so buffer it. |
| cmd.setFlags(cmd.getFlags() | UpdateCommand.BUFFERING); |
| ulog.deleteByQuery(cmd); |
| return; |
| } |
| |
| doLocalDelete(cmd); |
| } |
| } |
| |
| // since we don't know which documents were deleted, the easiest thing to do is to invalidate |
| // all real-time caches (i.e. UpdateLog) which involves also getting a new version of the IndexReader |
| // (so cache misses will see up-to-date data) |
| |
| } finally { |
| vinfo.unblockUpdates(); |
| } |
| |
| if (zkEnabled) { |
| // forward to all replicas |
| ModifiableSolrParams params = new ModifiableSolrParams(filterParams(req.getParams())); |
| params.set(VERSION_FIELD, Long.toString(cmd.getVersion())); |
| params.set(DISTRIB_UPDATE_PARAM, DistribPhase.FROMLEADER.toString()); |
| params.set(DISTRIB_FROM, ZkCoreNodeProps.getCoreUrl( |
| zkController.getBaseUrl(), req.getCore().getName())); |
| |
| boolean someReplicas = false; |
| boolean subShardLeader = false; |
| try { |
| subShardLeader = amISubShardLeader(coll, null, null, null); |
| if (subShardLeader) { |
| String myShardId = req.getCore().getCoreDescriptor().getCloudDescriptor().getShardId(); |
| Replica leaderReplica = zkController.getZkStateReader().getLeaderRetry( |
| collection, myShardId); |
| List<ZkCoreNodeProps> replicaProps = zkController.getZkStateReader() |
| .getReplicaProps(collection, myShardId, leaderReplica.getName(), null, ZkStateReader.DOWN); |
| if (replicaProps != null) { |
| List<Node> myReplicas = new ArrayList<>(); |
| for (ZkCoreNodeProps replicaProp : replicaProps) { |
| myReplicas.add(new StdNode(replicaProp, collection, myShardId)); |
| } |
| cmdDistrib.distribDelete(cmd, myReplicas, params); |
| someReplicas = true; |
| } |
| } |
| } catch (InterruptedException e) { |
| Thread.currentThread().interrupt(); |
| throw new ZooKeeperException(ErrorCode.SERVER_ERROR, "", e); |
| } |
| |
| if (leaderLogic) { |
| List<Node> subShardLeaders = getSubShardLeaders(coll, cloudDesc.getShardId(), null, null); |
| if (subShardLeaders != null) { |
| cmdDistrib.distribDelete(cmd, subShardLeaders, params, true); |
| } |
| List<Node> nodesByRoutingRules = getNodesByRoutingRules(zkController.getClusterState(), coll, null, null); |
| if (nodesByRoutingRules != null && !nodesByRoutingRules.isEmpty()) { |
| params = new ModifiableSolrParams(filterParams(req.getParams())); |
| params.set(DISTRIB_UPDATE_PARAM, DistribPhase.FROMLEADER.toString()); |
| params.set(DISTRIB_FROM, ZkCoreNodeProps.getCoreUrl( |
| zkController.getBaseUrl(), req.getCore().getName())); |
| params.set(DISTRIB_FROM_COLLECTION, req.getCore().getCoreDescriptor().getCloudDescriptor().getCollectionName()); |
| params.set(DISTRIB_FROM_SHARD, req.getCore().getCoreDescriptor().getCloudDescriptor().getShardId()); |
| cmdDistrib.distribDelete(cmd, nodesByRoutingRules, params, true); |
| } |
| if (replicas != null) { |
| cmdDistrib.distribDelete(cmd, replicas, params); |
| someReplicas = true; |
| } |
| } |
| |
| if (someReplicas) { |
| cmdDistrib.finish(); |
| } |
| } |
| |
| |
| if (returnVersions && rsp != null) { |
| if (deleteByQueryResponse == null) { |
| deleteByQueryResponse = new NamedList<String>(); |
| rsp.add("deleteByQuery",deleteByQueryResponse); |
| } |
| deleteByQueryResponse.add(cmd.getQuery(), cmd.getVersion()); |
| } |
| } |
| |
| // internal helper method to tell if we are the leader for an add or deleteById update |
| boolean isLeader(UpdateCommand cmd) { |
| updateCommand = cmd; |
| |
| if (zkEnabled) { |
| zkCheck(); |
| if (cmd instanceof AddUpdateCommand) { |
| AddUpdateCommand acmd = (AddUpdateCommand)cmd; |
| nodes = setupRequest(acmd.getHashableId(), acmd.getSolrInputDocument()); |
| } else if (cmd instanceof DeleteUpdateCommand) { |
| DeleteUpdateCommand dcmd = (DeleteUpdateCommand)cmd; |
| nodes = setupRequest(dcmd.getId(), null); |
| } |
| } else { |
| isLeader = getNonZkLeaderAssumption(req); |
| } |
| |
| return isLeader; |
| } |
| |
| private void zkCheck() { |
| if ((updateCommand.getFlags() & (UpdateCommand.REPLAY | UpdateCommand.PEER_SYNC)) != 0) { |
| // for log reply or peer sync, we don't need to be connected to ZK |
| return; |
| } |
| |
| if (!zkController.getZkClient().getConnectionManager().isLikelyExpired()) { |
| return; |
| } |
| |
| throw new SolrException(ErrorCode.SERVICE_UNAVAILABLE, "Cannot talk to ZooKeeper - Updates are disabled."); |
| } |
| |
| private boolean versionDelete(DeleteUpdateCommand cmd) throws IOException { |
| |
| BytesRef idBytes = cmd.getIndexedId(); |
| |
| if (vinfo == null || idBytes == null) { |
| super.processDelete(cmd); |
| return false; |
| } |
| |
| // This is only the hash for the bucket, and must be based only on the uniqueKey (i.e. do not use a pluggable hash here) |
| int bucketHash = Hash.murmurhash3_x86_32(idBytes.bytes, idBytes.offset, idBytes.length, 0); |
| |
| // at this point, there is an update we need to try and apply. |
| // we may or may not be the leader. |
| |
| // Find the version |
| long versionOnUpdate = cmd.getVersion(); |
| if (versionOnUpdate == 0) { |
| String versionOnUpdateS = req.getParams().get(VERSION_FIELD); |
| versionOnUpdate = versionOnUpdateS == null ? 0 : Long.parseLong(versionOnUpdateS); |
| } |
| long signedVersionOnUpdate = versionOnUpdate; |
| versionOnUpdate = Math.abs(versionOnUpdate); // normalize to positive version |
| |
| boolean isReplayOrPeersync = (cmd.getFlags() & (UpdateCommand.REPLAY | UpdateCommand.PEER_SYNC)) != 0; |
| boolean leaderLogic = isLeader && !isReplayOrPeersync; |
| boolean forwardedFromCollection = cmd.getReq().getParams().get(DISTRIB_FROM_COLLECTION) != null; |
| |
| if (!leaderLogic && versionOnUpdate==0) { |
| throw new SolrException(ErrorCode.BAD_REQUEST, "missing _version_ on update from leader"); |
| } |
| |
| VersionBucket bucket = vinfo.bucket(bucketHash); |
| |
| vinfo.lockForUpdate(); |
| try { |
| |
| synchronized (bucket) { |
| if (versionsStored) { |
| long bucketVersion = bucket.highest; |
| |
| if (leaderLogic) { |
| |
| if (forwardedFromCollection && ulog.getState() == UpdateLog.State.ACTIVE) { |
| // forwarded from a collection but we are not buffering so strip original version and apply our own |
| // see SOLR-5308 |
| log.info("Removing version field from doc: " + cmd.getId()); |
| versionOnUpdate = signedVersionOnUpdate = 0; |
| } |
| |
| // leaders can also be in buffering state during "migrate" API call, see SOLR-5308 |
| if (forwardedFromCollection && ulog.getState() != UpdateLog.State.ACTIVE |
| && (cmd.getFlags() & UpdateCommand.REPLAY) == 0) { |
| // we're not in an active state, and this update isn't from a replay, so buffer it. |
| log.info("Leader logic applied but update log is buffering: " + cmd.getId()); |
| cmd.setFlags(cmd.getFlags() | UpdateCommand.BUFFERING); |
| ulog.delete(cmd); |
| return true; |
| } |
| |
| if (signedVersionOnUpdate != 0) { |
| Long lastVersion = vinfo.lookupVersion(cmd.getIndexedId()); |
| long foundVersion = lastVersion == null ? -1 : lastVersion; |
| if ( (signedVersionOnUpdate == foundVersion) || (signedVersionOnUpdate < 0 && foundVersion < 0) || (signedVersionOnUpdate == 1 && foundVersion > 0) ) { |
| // we're ok if versions match, or if both are negative (all missing docs are equal), or if cmd |
| // specified it must exist (versionOnUpdate==1) and it does. |
| } else { |
| throw new SolrException(ErrorCode.CONFLICT, "version conflict for " + cmd.getId() + " expected=" + signedVersionOnUpdate + " actual=" + foundVersion); |
| } |
| } |
| |
| long version = vinfo.getNewClock(); |
| cmd.setVersion(-version); |
| bucket.updateHighest(version); |
| } else { |
| cmd.setVersion(-versionOnUpdate); |
| |
| if (ulog.getState() != UpdateLog.State.ACTIVE && (cmd.getFlags() & UpdateCommand.REPLAY) == 0) { |
| // we're not in an active state, and this update isn't from a replay, so buffer it. |
| cmd.setFlags(cmd.getFlags() | UpdateCommand.BUFFERING); |
| ulog.delete(cmd); |
| return true; |
| } |
| |
| // if we aren't the leader, then we need to check that updates were not re-ordered |
| if (bucketVersion != 0 && bucketVersion < versionOnUpdate) { |
| // we're OK... this update has a version higher than anything we've seen |
| // in this bucket so far, so we know that no reordering has yet occured. |
| bucket.updateHighest(versionOnUpdate); |
| } else { |
| // there have been updates higher than the current update. we need to check |
| // the specific version for this id. |
| Long lastVersion = vinfo.lookupVersion(cmd.getIndexedId()); |
| if (lastVersion != null && Math.abs(lastVersion) >= versionOnUpdate) { |
| // This update is a repeat, or was reordered. We need to drop this update. |
| return true; |
| } |
| } |
| } |
| } |
| |
| doLocalDelete(cmd); |
| return false; |
| } // end synchronized (bucket) |
| |
| } finally { |
| vinfo.unlockForUpdate(); |
| } |
| } |
| |
| @Override |
| public void processCommit(CommitUpdateCommand cmd) throws IOException { |
| updateCommand = cmd; |
| List<Node> nodes = null; |
| boolean singleLeader = false; |
| if (zkEnabled) { |
| zkCheck(); |
| |
| nodes = getCollectionUrls(req, req.getCore().getCoreDescriptor() |
| .getCloudDescriptor().getCollectionName()); |
| if (isLeader && nodes.size() == 1) { |
| singleLeader = true; |
| } |
| } |
| |
| if (!zkEnabled || req.getParams().getBool(COMMIT_END_POINT, false) || singleLeader) { |
| doLocalCommit(cmd); |
| } else if (zkEnabled) { |
| ModifiableSolrParams params = new ModifiableSolrParams(filterParams(req.getParams())); |
| if (!req.getParams().getBool(COMMIT_END_POINT, false)) { |
| params.set(COMMIT_END_POINT, true); |
| params.set(DISTRIB_UPDATE_PARAM, DistribPhase.FROMLEADER.toString()); |
| params.set(DISTRIB_FROM, ZkCoreNodeProps.getCoreUrl( |
| zkController.getBaseUrl(), req.getCore().getName())); |
| if (nodes != null) { |
| cmdDistrib.distribCommit(cmd, nodes, params); |
| finish(); |
| } |
| } |
| } |
| } |
| |
| private void doLocalCommit(CommitUpdateCommand cmd) throws IOException { |
| if (vinfo != null) { |
| vinfo.lockForUpdate(); |
| } |
| try { |
| |
| if (ulog == null || ulog.getState() == UpdateLog.State.ACTIVE || (cmd.getFlags() & UpdateCommand.REPLAY) != 0) { |
| super.processCommit(cmd); |
| } else { |
| log.info("Ignoring commit while not ACTIVE - state: " + ulog.getState() + " replay:" + (cmd.getFlags() & UpdateCommand.REPLAY)); |
| } |
| |
| } finally { |
| if (vinfo != null) { |
| vinfo.unlockForUpdate(); |
| } |
| } |
| } |
| |
| @Override |
| public void finish() throws IOException { |
| if (zkEnabled) doFinish(); |
| |
| if (next != null && nodes == null) next.finish(); |
| } |
| |
| |
| |
| private List<Node> getCollectionUrls(SolrQueryRequest req, String collection) { |
| ClusterState clusterState = req.getCore().getCoreDescriptor() |
| .getCoreContainer().getZkController().getClusterState(); |
| List<Node> urls = new ArrayList<>(); |
| Map<String,Slice> slices = clusterState.getSlicesMap(collection); |
| if (slices == null) { |
| throw new ZooKeeperException(ErrorCode.BAD_REQUEST, |
| "Could not find collection in zk: " + clusterState); |
| } |
| for (Map.Entry<String,Slice> sliceEntry : slices.entrySet()) { |
| Slice replicas = slices.get(sliceEntry.getKey()); |
| |
| Map<String,Replica> shardMap = replicas.getReplicasMap(); |
| |
| for (Entry<String,Replica> entry : shardMap.entrySet()) { |
| ZkCoreNodeProps nodeProps = new ZkCoreNodeProps(entry.getValue()); |
| if (clusterState.liveNodesContain(nodeProps.getNodeName())) { |
| urls.add(new StdNode(nodeProps, collection, replicas.getName())); |
| } |
| } |
| } |
| if (urls.size() == 0) { |
| return null; |
| } |
| return urls; |
| } |
| |
| /** |
| * Returns a boolean indicating whether or not the caller should behave as |
| * if this is the "leader" even when ZooKeeper is not enabled. |
| * (Even in non zk mode, tests may simulate updates to/from a leader) |
| */ |
| public static boolean getNonZkLeaderAssumption(SolrQueryRequest req) { |
| DistribPhase phase = |
| DistribPhase.parseParam(req.getParams().get(DISTRIB_UPDATE_PARAM)); |
| |
| // if we have been told we are coming from a leader, then we are |
| // definitely not the leader. Otherwise assume we are. |
| return DistribPhase.FROMLEADER != phase; |
| } |
| } |
