allow to change attachments download dirpath
diff --git a/migration/.env.example b/migration/.env.example
index 842824a..4b08767 100644
--- a/migration/.env.example
+++ b/migration/.env.example
@@ -1,4 +1,5 @@
export GITHUB_PAT=
export GITHUB_REPO=
export GITHUB_ATT_REPO="apache/lucene-jira-archive"
-export GITHUB_ATT_BRANCH="main"
\ No newline at end of file
+export GITHUB_ATT_BRANCH="attachments"
+export ATTACHMENTS_DL_DIR=
\ No newline at end of file
diff --git a/migration/.gitignore b/migration/.gitignore
index a9d17ea..0c0283b 100644
--- a/migration/.gitignore
+++ b/migration/.gitignore
@@ -13,4 +13,3 @@
.env
log/
-attachments/
\ No newline at end of file
diff --git a/migration/src/common.py b/migration/src/common.py
index a6c373b..93a6a02 100644
--- a/migration/src/common.py
+++ b/migration/src/common.py
@@ -3,12 +3,13 @@
from datetime import datetime
import functools
import time
-
+import os
+import tempfile
LOG_DIRNAME = "log"
JIRA_DUMP_DIRNAME = "jira-dump"
-JIRA_ATTACHMENTS_DIRNAME = "attachments"
+JIRA_ATTACHMENTS_DIRPATH = os.getenv("ATTACHMENTS_DL_DIR", str(Path(tempfile.gettempdir()).joinpath("attachments")))
GITHUB_IMPORT_DATA_DIRNAME = "github-import-data"
MAPPINGS_DATA_DIRNAME = "mappings-data"
diff --git a/migration/src/download_jira.py b/migration/src/download_jira.py
index 7c3a5e7..92bebc3 100644
--- a/migration/src/download_jira.py
+++ b/migration/src/download_jira.py
@@ -13,7 +13,7 @@
import requests
-from common import LOG_DIRNAME, JIRA_DUMP_DIRNAME, JIRA_ATTACHMENTS_DIRNAME, logging_setup, jira_dump_file, jira_attachments_dir, jira_issue_id
+from common import LOG_DIRNAME, JIRA_DUMP_DIRNAME, JIRA_ATTACHMENTS_DIRPATH, logging_setup, jira_dump_file, jira_attachments_dir, jira_issue_id
log_dir = Path(__file__).resolve().parent.parent.joinpath(LOG_DIRNAME)
logger = logging_setup(log_dir, "download_jira")
@@ -94,7 +94,7 @@
dump_dir.mkdir()
assert dump_dir.exists()
- att_data_dir = Path(__file__).resolve().parent.parent.parent.joinpath(JIRA_ATTACHMENTS_DIRNAME)
+ att_data_dir = Path(JIRA_ATTACHMENTS_DIRPATH)
if not att_data_dir.exists():
att_data_dir.mkdir()
assert att_data_dir.exists()
@@ -108,10 +108,10 @@
else:
issues.append(args.min)
- logger.info(f"Downloading Jira issues in {dump_dir}")
+ logger.info(f"Downloading Jira issues in {dump_dir}. Attachments are saved in {att_data_dir}.")
for num in issues:
- download_issue(num, dump_dir)
- download_attachments(num, dump_dir, att_data_dir)
+ if download_issue(num, dump_dir):
+ download_attachments(num, dump_dir, att_data_dir)
time.sleep(DOWNLOAD_INTERVAL_SEC)
logger.info("Done.")
