Use appendValue() where possible to avoid temporary objects
Signed-off-by: Matt Sicker <boards@gmail.com>
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/util/StringBuilders.java b/log4j-api/src/main/java/org/apache/logging/log4j/util/StringBuilders.java
index 48fa98f..7ae03eb 100644
--- a/log4j-api/src/main/java/org/apache/logging/log4j/util/StringBuilders.java
+++ b/log4j-api/src/main/java/org/apache/logging/log4j/util/StringBuilders.java
@@ -35,7 +35,9 @@
* @return {@code "value"}
*/
public static StringBuilder appendDqValue(final StringBuilder sb, final Object value) {
- return sb.append(Chars.DQUOTE).append(value).append(Chars.DQUOTE);
+ sb.append(Chars.DQUOTE);
+ appendValue(sb, value);
+ return sb.append(Chars.DQUOTE);
}
/**
@@ -58,7 +60,8 @@
* @return the specified StringBuilder
*/
public static StringBuilder appendKeyDqValue(final StringBuilder sb, final String key, final Object value) {
- return sb.append(key).append(Chars.EQ).append(Chars.DQUOTE).append(value).append(Chars.DQUOTE);
+ sb.append(key).append(Chars.EQ);
+ return appendDqValue(sb, value);
}
/**
