LOGCXX-259: Several appenders fail to compile with VC8
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 5aadc57..7faa62b 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -22,7 +22,7 @@
<title>Apache log4cxx</title>
</properties>
<body>
-<release version="0.10.0" date="2008-04-02" description="First Apache release">
+<release version="0.10.0" date="2008-04-03" description="First Apache release">
<action issue="LOGCXX-2">logger.h includes config.h</action>
<action issue="LOGCXX-3">Missing #else</action>
<action issue="LOGCXX-4">initialization not working on many OS's</action>
@@ -226,6 +226,7 @@
<action issue="LOGCXX-256">SocketHubAppender fails after accepting connection</action>
<action issue="LOGCXX-257">ServerSocket::accept hangs on Unix</action>
<action issue="LOGCXX-258">unable to build from make dist package due to missing doxygen file</action>
+<action issue="LOGCXX-259">Several appenders fail to compile in Visual Studio 2008</action>
</release>
<release version="0.9.7" date="2004-05-10">
<action type="fix">Fixed examples source code in the "Short introduction to log4cxx".</action>
diff --git a/src/main/cpp/socketoutputstream.cpp b/src/main/cpp/socketoutputstream.cpp
index aec15a6..185f835 100644
--- a/src/main/cpp/socketoutputstream.cpp
+++ b/src/main/cpp/socketoutputstream.cpp
@@ -39,7 +39,7 @@
void SocketOutputStream::flush(Pool& /* p */) {
if (array.size() > 0) {
- ByteBuffer buf(&array[0], array.size());
+ ByteBuffer buf((char*) &array[0], array.size());
socket->write(buf);
array.resize(0);
}
diff --git a/src/main/include/log4cxx/helpers/socketoutputstream.h b/src/main/include/log4cxx/helpers/socketoutputstream.h
index 21c43a6..6bca173 100644
--- a/src/main/include/log4cxx/helpers/socketoutputstream.h
+++ b/src/main/include/log4cxx/helpers/socketoutputstream.h
@@ -49,12 +49,10 @@
virtual void flush(Pool& p);
virtual void write(ByteBuffer& buf, Pool& p);
- protected:
- LOG4CXX_LIST_DEF(ByteList, char);
+ private:
+ LOG4CXX_LIST_DEF(ByteList, unsigned char);
ByteList array;
SocketPtr socket;
-
- private:
//
// prevent copy and assignment statements
SocketOutputStream(const SocketOutputStream&);
