commit d7a3cddd217d0de513483b3a9f911d83e1eeb5d2
author Grant Henke <granthenke@apache.org> Tue Apr 21 09:49:15 2020 -0500
committer Grant Henke <granthenke@apache.org> Tue Apr 21 18:43:23 2020 +0000
tree 1d78c1fbd6a387c3f0da5651adb30df8afeb46bb
parent 98b1c5d843d4df306373a6aad4885658e07719f1

[test] Fix types-test on MacOS

In MacOS the `%F` date format pads the date with leading zeros. While
on other linux distributions it does not. It appears to be an issue for other
software as well:
https://bugs.python.org/issue32195

As a quick workaround I added special handling to the test for leading
zeros.

Change-Id: Ic11d2e1828e141f678ea8f417c57b188e322c660
Reviewed-on: http://gerrit.cloudera.org:8080/15768
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <bankim@cloudera.com>
Reviewed-by: Alexey Serbin <aserbin@cloudera.com>

src/kudu/common/types-test.cc

diff --git a/src/kudu/common/types-test.cc b/src/kudu/common/types-test.cc
index a662e03..343d8ee 100644
--- a/src/kudu/common/types-test.cc
+++ b/src/kudu/common/types-test.cc
@@ -54,7 +54,12 @@
 };
 
 TEST_F(TestTypes, TestDatePrinting) {
+#if defined(__APPLE__)
+  // On MacOS the `%F` date format pads the year with zeros.
+  TestDateToString("0001-01-01", *DataTypeTraits<DATE>::min_value());
+#else
   TestDateToString("1-01-01", *DataTypeTraits<DATE>::min_value());
+#endif
   TestDateToString("9999-12-31", *DataTypeTraits<DATE>::max_value());
   TestDateToString("1970-01-01", 0);
   TestDateToString("1942-08-16", -10000);