Google Git
Sign in
apache / kudu / 3aeb9139992eab62160b85bb1e51d44301549569 / . / src / kudu / master / master-test.cc
blob: 4652f18170d34f5081e9f516ad211ec62670f3e0 [file] [log] [blame]
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
#include "kudu/master/master.h"
#include <algorithm>
#include <atomic>
#include <cstdint>
#include <ctime>
#include <functional>
#include <map>
#include <memory>
#include <numeric>
#include <optional>
#include <ostream>
#include <set>
#include <string>
#include <thread>
#include <type_traits>
#include <unordered_map>
#include <unordered_set>
#include <utility>
#include <vector>
#include <gflags/gflags.h>
#include <glog/logging.h>
#include <gtest/gtest.h>
#include <rapidjson/document.h>
#include <rapidjson/rapidjson.h>
#include "kudu/common/common.pb.h"
#include "kudu/common/partial_row.h"
#include "kudu/common/partition.h"
#include "kudu/common/row_operations.h"
#include "kudu/common/row_operations.pb.h"
#include "kudu/common/schema.h"
#include "kudu/common/types.h"
#include "kudu/common/wire_protocol.h"
#include "kudu/common/wire_protocol.pb.h"
#include "kudu/consensus/consensus.pb.h"
#include "kudu/consensus/replica_management.pb.h"
#include "kudu/generated/version_defines.h"
#include "kudu/gutil/dynamic_annotations.h"
#include "kudu/gutil/integral_types.h"
#include "kudu/gutil/map-util.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/gutil/strings/split.h"
#include "kudu/gutil/strings/substitute.h"
#include "kudu/gutil/strings/util.h"
#include "kudu/gutil/walltime.h"
#include "kudu/integration-tests/cluster_itest_util.h"
#include "kudu/master/catalog_manager.h"
#include "kudu/master/master.pb.h"
#include "kudu/master/master.proxy.h"
#include "kudu/master/master_options.h"
#include "kudu/master/mini_master.h"
#include "kudu/master/sys_catalog.h"
#include "kudu/master/table_metrics.h"
#include "kudu/master/ts_manager.h"
#include "kudu/rpc/messenger.h"
#include "kudu/rpc/rpc_controller.h"
#include "kudu/security/tls_context.h"
#include "kudu/security/token.pb.h"
#include "kudu/security/token_verifier.h"
#include "kudu/server/monitored_task.h"
#include "kudu/server/rpc_server.h"
#include "kudu/tablet/metadata.pb.h"
#include "kudu/util/atomic.h"
#include "kudu/util/cache.h"
#include "kudu/util/countdown_latch.h"
#include "kudu/util/curl_util.h"
#include "kudu/util/env.h"
#include "kudu/util/faststring.h"
#include "kudu/util/hdr_histogram.h"
#include "kudu/util/metrics.h"
#include "kudu/util/monotime.h"
#include "kudu/util/net/net_util.h"
#include "kudu/util/net/sockaddr.h"
#include "kudu/util/path_util.h"
#include "kudu/util/pb_util.h"
#include "kudu/util/random.h"
#include "kudu/util/scoped_cleanup.h"
#include "kudu/util/status.h"
#include "kudu/util/test_macros.h"
#include "kudu/util/test_util.h"
#include "kudu/util/version_info.h"
namespace kudu {
namespace master {
class TSDescriptor;
} // namespace master
} // namespace kudu
using kudu::consensus::ReplicaManagementInfoPB;
using kudu::itest::GetClusterId;
using kudu::pb_util::SecureDebugString;
using kudu::pb_util::SecureShortDebugString;
using kudu::rpc::Messenger;
using kudu::rpc::MessengerBuilder;
using kudu::rpc::RpcController;
using std::accumulate;
using std::nullopt;
using std::optional;
using std::map;
using std::multiset;
using std::pair;
using std::shared_ptr;
using std::string;
using std::thread;
using std::unique_ptr;
using std::unordered_map;
using std::unordered_set;
using std::vector;
using strings::Substitute;
DECLARE_bool(catalog_manager_check_ts_count_for_create_table);
DECLARE_bool(enable_metadata_cleanup_for_deleted_tables_and_tablets);
DECLARE_bool(master_client_location_assignment_enabled);
DECLARE_bool(master_support_authz_tokens);
DECLARE_bool(mock_table_metrics_for_testing);
DECLARE_bool(raft_prepare_replacement_before_eviction);
DECLARE_double(sys_catalog_fail_during_write);
DECLARE_int32(catalog_manager_bg_task_wait_ms);
DECLARE_int32(default_num_replicas);
DECLARE_int32(metadata_for_deleted_table_and_tablet_reserved_secs);
DECLARE_int32(diagnostics_log_stack_traces_interval_ms);
DECLARE_int32(flush_threshold_mb);
DECLARE_int32(flush_threshold_secs);
DECLARE_int32(flush_upper_bound_ms);
DECLARE_int32(master_inject_latency_on_tablet_lookups_ms);
DECLARE_int32(max_table_comment_length);
DECLARE_int32(rpc_service_queue_length);
DECLARE_int64(live_row_count_for_testing);
DECLARE_int64(on_disk_size_for_testing);
DECLARE_string(ipki_private_key_password_cmd);
DECLARE_string(location_mapping_cmd);
DECLARE_string(log_filename);
DECLARE_string(tsk_private_key_password_cmd);
DECLARE_string(webserver_doc_root);
METRIC_DECLARE_histogram(handler_latency_kudu_master_MasterService_GetTableSchema);
namespace kudu {
namespace master {
class MasterTest : public KuduTest {
protected:
void SetUp() override {
KuduTest::SetUp();
// In this test, we create tables to test catalog manager behavior,
// but we have no tablet servers. Typically this would be disallowed.
FLAGS_catalog_manager_check_ts_count_for_create_table = false;
// Ensure the static pages are not available as tests are written based
// on this value of the flag
FLAGS_webserver_doc_root = "";
// Start master
mini_master_.reset(new MiniMaster(GetTestPath("Master"), HostPort("127.0.0.1", 0)));
ASSERT_OK(mini_master_->Start());
master_ = mini_master_->master();
ASSERT_OK(master_->WaitUntilCatalogManagerIsLeaderAndReadyForTests(
MonoDelta::FromSeconds(90)));
// Create a client proxy to it.
MessengerBuilder bld("Client");
ASSERT_OK(bld.Build(&client_messenger_));
proxy_.reset(new MasterServiceProxy(client_messenger_, mini_master_->bound_rpc_addr(),
mini_master_->bound_rpc_addr().host()));
}
void TearDown() override {
mini_master_->Shutdown();
KuduTest::TearDown();
}
struct HashDimension {
vector<string> columns;
int32_t num_buckets;
uint32_t seed;
};
typedef vector<HashDimension> HashSchema;
struct RangeWithHashSchema {
KuduPartialRow lower;
KuduPartialRow upper;
HashSchema hash_schema;
};
void DoListTables(const ListTablesRequestPB& req, ListTablesResponsePB* resp);
void DoListAllTables(ListTablesResponsePB* resp);
Status CreateTable(const string& name,
const Schema& schema,
const optional<TableTypePB>& type = nullopt,
const optional<string>& owner = nullopt,
const optional<string>& comment = nullopt);
Status CreateTable(const string& name,
const Schema& schema,
const vector<KuduPartialRow>& split_rows,
const vector<pair<KuduPartialRow, KuduPartialRow>>& bounds = {},
const vector<RangeWithHashSchema>& ranges_with_hash_schemas = {});
Status CreateTable(const string& name,
const Schema& schema,
const optional<TableTypePB>& type,
const optional<string>& owner,
const optional<string>& comment,
const vector<KuduPartialRow>& split_rows,
const vector<pair<KuduPartialRow, KuduPartialRow>>& bounds,
const vector<RangeWithHashSchema>& ranges_with_hash_schemas,
const HashSchema& table_wide_hash_schema,
CreateTableResponsePB* resp);
Status GetTablePartitionSchema(const string& table_name,
PartitionSchemaPB* ps_pb);
Status SoftDelete(const string& table_name, uint32 reserve_seconds);
Status RecallTable(const string& table_id);
shared_ptr<Messenger> client_messenger_;
unique_ptr<MiniMaster> mini_master_;
Master* master_;
unique_ptr<MasterServiceProxy> proxy_;
};
Status MasterTest::CreateTable(const string& name,
const Schema& schema,
const optional<TableTypePB>& type,
const optional<string>& owner,
const optional<string>& comment) {
KuduPartialRow split1(&schema);
RETURN_NOT_OK(split1.SetInt32("key", 10));
KuduPartialRow split2(&schema);
RETURN_NOT_OK(split2.SetInt32("key", 20));
CreateTableResponsePB resp;
return CreateTable(
name, schema, type, owner, comment, { split1, split2 }, {}, {}, {}, &resp);
}
Status MasterTest::CreateTable(
const string& name,
const Schema& schema,
const vector<KuduPartialRow>& split_rows,
const vector<pair<KuduPartialRow, KuduPartialRow>>& bounds,
const vector<RangeWithHashSchema>& ranges_with_hash_schemas) {
CreateTableResponsePB resp;
return CreateTable(name, schema, nullopt, nullopt, nullopt, split_rows, bounds,
ranges_with_hash_schemas, {}, &resp);
}
Status MasterTest::CreateTable(
const string& name,
const Schema& schema,
const optional<TableTypePB>& type,
const optional<string>& owner,
const optional<string>& comment,
const vector<KuduPartialRow>& split_rows,
const vector<pair<KuduPartialRow, KuduPartialRow>>& bounds,
const vector<RangeWithHashSchema>& ranges_with_hash_schemas,
const HashSchema& table_wide_hash_schema,
CreateTableResponsePB* resp) {
CreateTableRequestPB req;
req.set_name(name);
if (type) {
req.set_table_type(*type);
}
RETURN_NOT_OK(SchemaToPB(schema, req.mutable_schema()));
RowOperationsPBEncoder splits_encoder(req.mutable_split_rows_range_bounds());
for (const KuduPartialRow& row : split_rows) {
splits_encoder.Add(RowOperationsPB::SPLIT_ROW, row);
}
for (const pair<KuduPartialRow, KuduPartialRow>& bound : bounds) {
splits_encoder.Add(RowOperationsPB::RANGE_LOWER_BOUND, bound.first);
splits_encoder.Add(RowOperationsPB::RANGE_UPPER_BOUND, bound.second);
}
auto* ps_pb = req.mutable_partition_schema();
for (const auto& hash_dimension : table_wide_hash_schema) {
auto* hash_schema = ps_pb->add_hash_schema();
for (const string& col_name : hash_dimension.columns) {
hash_schema->add_columns()->set_name(col_name);
}
hash_schema->set_num_buckets(hash_dimension.num_buckets);
hash_schema->set_seed(hash_dimension.seed);
}
for (const auto& range_and_hs : ranges_with_hash_schemas) {
auto* range = ps_pb->add_custom_hash_schema_ranges();
RowOperationsPBEncoder encoder(range->mutable_range_bounds());
encoder.Add(RowOperationsPB::RANGE_LOWER_BOUND, range_and_hs.lower);
encoder.Add(RowOperationsPB::RANGE_UPPER_BOUND, range_and_hs.upper);
for (const auto& hash_dimension : range_and_hs.hash_schema) {
auto* hash_dimension_pb = range->add_hash_schema();
for (const string& col_name : hash_dimension.columns) {
hash_dimension_pb->add_columns()->set_name(col_name);
}
hash_dimension_pb->set_num_buckets(hash_dimension.num_buckets);
hash_dimension_pb->set_seed(hash_dimension.seed);
}
}
if (owner) {
req.set_owner(*owner);
}
if (comment) {
req.set_comment(*comment);
}
RpcController controller;
if (!bounds.empty()) {
controller.RequireServerFeature(MasterFeatures::RANGE_PARTITION_BOUNDS);
}
RETURN_NOT_OK(proxy_->CreateTable(req, resp, &controller));
if (resp->has_error()) {
RETURN_NOT_OK(StatusFromPB(resp->error().status()));
}
return Status::OK();
}
Status MasterTest::GetTablePartitionSchema(const string& table_name,
PartitionSchemaPB* ps_pb) {
DCHECK(ps_pb);
GetTableSchemaRequestPB req;
req.mutable_table()->set_table_name(table_name);
RpcController ctl;
GetTableSchemaResponsePB resp;
RETURN_NOT_OK(proxy_->GetTableSchema(req, &resp, &ctl));
if (resp.has_error()) {
return StatusFromPB(resp.error().status());
}
if (!resp.has_partition_schema()) {
return Status::IllegalState("partition schema information is missing");
}
*ps_pb = resp.partition_schema();
return Status::OK();
}
Status MasterTest::SoftDelete(const string& table_name, uint32 reserve_seconds) {
DeleteTableRequestPB req;
DeleteTableResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_name(table_name);
req.set_reserve_seconds(reserve_seconds);
return master_->catalog_manager()->SoftDeleteTableRpc(req, &resp, nullptr);
}
Status MasterTest::RecallTable(const string& table_id) {
RecallDeletedTableRequestPB req;
RecallDeletedTableResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_id(table_id);
return master_->catalog_manager()->RecallDeletedTableRpc(req, &resp, nullptr);
}
void MasterTest::DoListTables(const ListTablesRequestPB& req, ListTablesResponsePB* resp) {
RpcController controller;
ASSERT_OK(proxy_->ListTables(req, resp, &controller));
SCOPED_TRACE(SecureDebugString(*resp));
ASSERT_FALSE(resp->has_error());
}
void MasterTest::DoListAllTables(ListTablesResponsePB* resp) {
ListTablesRequestPB req;
DoListTables(req, resp);
}
static void MakeHostPortPB(const string& host, uint32_t port, HostPortPB* pb) {
pb->set_host(host);
pb->set_port(port);
}
TEST_F(MasterTest, TestPingServer) {
// Ping the server.
PingRequestPB req;
PingResponsePB resp;
RpcController controller;
ASSERT_OK(proxy_->Ping(req, &resp, &controller));
}
// Test that shutting down a MiniMaster without starting it does not
// SEGV.
TEST_F(MasterTest, TestShutdownWithoutStart) {
MiniMaster m("/xxxx", HostPort("127.0.0.1", 0));
m.Shutdown();
}
// Test that ensures that, when specified, restarting a master from within the
// same process can correctly instantiate proper block cache metrics.
TEST_F(MasterTest, TestResetBlockCacheMetricsInSameProcess) {
mini_master_->Shutdown();
// Make sure we flush quickly so we start using the block cache ASAP.
FLAGS_flush_threshold_mb = 1;
FLAGS_flush_threshold_secs = 1;
FLAGS_flush_upper_bound_ms = 0;
// If implemented incorrectly, since the BlockCache is a singleton, we could
// end up with incorrect block cache metrics upon resetting the master
// because we register metrics twice. Ensure that's not the case when we
// supply the option to reset metrics.
mini_master_->mutable_options()->set_block_cache_metrics_policy(
Cache::ExistingMetricsPolicy::kReset);
ASSERT_OK(mini_master_->Restart());
// Keep on creating tables until we flush, at which point we'll use the block
// cache and increment metrics.
// NOTE: we could examine the master's metric_entity() directly, but that
// could itself interfere with the reported metrics, e.g. by calling
// FindOrCreateCount(). Going through the web UI is more organic anyway.
const Schema kTableSchema({ ColumnSchema("key", INT32), ColumnSchema("v", STRING) }, 1);
constexpr const char* kTablePrefix = "testtb";
EasyCurl c;
int i = 0;
ASSERT_EVENTUALLY([&] {
ASSERT_OK(CreateTable(Substitute("$0-$1", kTablePrefix, i++), kTableSchema));
faststring buf;
ASSERT_OK(c.FetchURL(
Substitute("http://$0/metrics?ids=kudu.master&metrics=block_cache_inserts",
mini_master_->bound_http_addr().ToString()),
&buf));
string raw = buf.ToString();
// If instrumented correctly, the new master should eventually display
// non-zero metrics for the block cache.
ASSERT_STR_MATCHES(raw, ".*\"value\": [1-9].*");
});
}
TEST_F(MasterTest, TestRegisterAndHeartbeat) {
const char* const kTsUUID = "my-ts-uuid";
TSToMasterCommonPB common;
common.mutable_ts_instance()->set_permanent_uuid(kTsUUID);
common.mutable_ts_instance()->set_instance_seqno(1);
// Try a heartbeat. The server hasn't heard of us, so should ask us
// to re-register.
{
RpcController rpc;
TSHeartbeatRequestPB req;
TSHeartbeatResponsePB resp;
req.mutable_common()->CopyFrom(common);
ASSERT_OK(proxy_->TSHeartbeat(req, &resp, &rpc));
ASSERT_FALSE(resp.has_error());
ASSERT_TRUE(resp.leader_master());
ASSERT_TRUE(resp.needs_reregister());
ASSERT_TRUE(resp.needs_full_tablet_report());
ASSERT_FALSE(resp.has_tablet_report());
}
vector<shared_ptr<TSDescriptor> > descs;
master_->ts_manager()->GetAllDescriptors(&descs);
ASSERT_EQ(0, descs.size()) << "Should not have registered anything";
shared_ptr<TSDescriptor> ts_desc;
ASSERT_FALSE(master_->ts_manager()->LookupTSByUUID(kTsUUID, &ts_desc));
// Register the fake TS, without sending any tablet report.
ServerRegistrationPB fake_reg;
MakeHostPortPB("localhost", 1000, fake_reg.add_rpc_addresses());
MakeHostPortPB("localhost", 2000, fake_reg.add_http_addresses());
fake_reg.set_software_version(VersionInfo::GetVersionInfo());
fake_reg.set_start_time(10000);
// Information on replica management scheme.
ReplicaManagementInfoPB rmi;
rmi.set_replacement_scheme(FLAGS_raft_prepare_replacement_before_eviction
? ReplicaManagementInfoPB::PREPARE_REPLACEMENT_BEFORE_EVICTION
: ReplicaManagementInfoPB::EVICT_FIRST);
{
TSHeartbeatRequestPB req;
TSHeartbeatResponsePB resp;
RpcController rpc;
req.mutable_common()->CopyFrom(common);
req.mutable_registration()->CopyFrom(fake_reg);
req.mutable_replica_management_info()->CopyFrom(rmi);
ASSERT_OK(proxy_->TSHeartbeat(req, &resp, &rpc));
ASSERT_FALSE(resp.has_error());
ASSERT_TRUE(resp.leader_master());
ASSERT_FALSE(resp.needs_reregister());
ASSERT_FALSE(resp.needs_full_tablet_report());
ASSERT_FALSE(resp.has_tablet_report());
}
master_->ts_manager()->GetAllDescriptors(&descs);
ASSERT_EQ(1, descs.size()) << "Should have registered the TS";
ServerRegistrationPB reg;
ASSERT_OK(descs[0]->GetRegistration(&reg));
ASSERT_EQ(SecureDebugString(fake_reg), SecureDebugString(reg))
<< "Master got different registration";
ASSERT_TRUE(master_->ts_manager()->LookupTSByUUID(kTsUUID, &ts_desc));
ASSERT_EQ(ts_desc, descs[0]);
// If the tablet server somehow lost the response to its registration RPC, it would
// attempt to register again. In that case, we shouldn't reject it -- we should
// just respond the same.
{
TSHeartbeatRequestPB req;
TSHeartbeatResponsePB resp;
RpcController rpc;
req.mutable_common()->CopyFrom(common);
req.mutable_registration()->CopyFrom(fake_reg);
req.mutable_replica_management_info()->CopyFrom(rmi);
ASSERT_OK(proxy_->TSHeartbeat(req, &resp, &rpc));
ASSERT_FALSE(resp.has_error());
ASSERT_TRUE(resp.leader_master());
ASSERT_FALSE(resp.needs_reregister());
ASSERT_FALSE(resp.needs_full_tablet_report());
ASSERT_FALSE(resp.has_tablet_report());
}
// If we send the registration RPC while the master isn't the leader, it
// shouldn't ask for a full tablet report.
{
CatalogManager::ScopedLeaderDisablerForTests o(master_->catalog_manager());
TSHeartbeatRequestPB req;
TSHeartbeatResponsePB resp;
RpcController rpc;
req.mutable_common()->CopyFrom(common);
req.mutable_registration()->CopyFrom(fake_reg);
req.mutable_replica_management_info()->CopyFrom(rmi);
ASSERT_OK(proxy_->TSHeartbeat(req, &resp, &rpc));
ASSERT_FALSE(resp.has_error());
ASSERT_FALSE(resp.leader_master());
ASSERT_FALSE(resp.needs_reregister());
ASSERT_FALSE(resp.needs_full_tablet_report());
ASSERT_FALSE(resp.has_tablet_report());
}
// Send a full tablet report, but with the master as a follower. The
// report will be ignored.
{
CatalogManager::ScopedLeaderDisablerForTests o(master_->catalog_manager());
TSHeartbeatRequestPB req;
TSHeartbeatResponsePB resp;
RpcController rpc;
req.mutable_common()->CopyFrom(common);
TabletReportPB* tr = req.mutable_tablet_report();
tr->set_is_incremental(false);
tr->set_sequence_number(0);
ASSERT_OK(proxy_->TSHeartbeat(req, &resp, &rpc));
ASSERT_FALSE(resp.has_error());
ASSERT_FALSE(resp.leader_master());
ASSERT_FALSE(resp.needs_reregister());
ASSERT_FALSE(resp.needs_full_tablet_report());
ASSERT_FALSE(resp.has_tablet_report());
}
// Now send a full report with the master as leader. The master will process
// it; this is reflected in the response.
{
TSHeartbeatRequestPB req;
TSHeartbeatResponsePB resp;
RpcController rpc;
req.mutable_common()->CopyFrom(common);
TabletReportPB* tr = req.mutable_tablet_report();
tr->set_is_incremental(false);
tr->set_sequence_number(0);
ASSERT_OK(proxy_->TSHeartbeat(req, &resp, &rpc));
ASSERT_FALSE(resp.has_error());
ASSERT_TRUE(resp.leader_master());
ASSERT_FALSE(resp.needs_reregister());
ASSERT_FALSE(resp.needs_full_tablet_report());
ASSERT_TRUE(resp.has_tablet_report());
}
// Having sent a full report, an incremental report will also be processed.
{
TSHeartbeatRequestPB req;
TSHeartbeatResponsePB resp;
RpcController rpc;
req.mutable_common()->CopyFrom(common);
TabletReportPB* tr = req.mutable_tablet_report();
tr->set_is_incremental(true);
tr->set_sequence_number(0);
ASSERT_OK(proxy_->TSHeartbeat(req, &resp, &rpc));
ASSERT_FALSE(resp.has_error());
ASSERT_TRUE(resp.leader_master());
ASSERT_FALSE(resp.needs_reregister());
ASSERT_FALSE(resp.needs_full_tablet_report());
ASSERT_TRUE(resp.has_tablet_report());
}
master_->ts_manager()->GetAllDescriptors(&descs);
ASSERT_EQ(1, descs.size()) << "Should still only have one TS registered";
ASSERT_TRUE(master_->ts_manager()->LookupTSByUUID(kTsUUID, &ts_desc));
ASSERT_EQ(ts_desc, descs[0]);
// Ensure that the ListTabletServers shows the faked server.
{
ListTabletServersRequestPB req;
ListTabletServersResponsePB resp;
RpcController rpc;
ASSERT_OK(proxy_->ListTabletServers(req, &resp, &rpc));
LOG(INFO) << SecureDebugString(resp);
ASSERT_FALSE(resp.has_error());
ASSERT_EQ(1, resp.servers_size());
ASSERT_EQ("my-ts-uuid", resp.servers(0).instance_id().permanent_uuid());
ASSERT_EQ(1, resp.servers(0).instance_id().instance_seqno());
}
// Ensure that /dump-entities endpoint also shows the faked server.
{
EasyCurl c;
faststring buf;
string addr = mini_master_->bound_http_addr().ToString();
ASSERT_OK(c.FetchURL(Substitute("http://$0/dump-entities", addr), &buf));
rapidjson::Document doc;
doc.Parse<0>(buf.ToString().c_str());
const rapidjson::Value& tablet_servers = doc["tablet_servers"];
ASSERT_EQ(tablet_servers.Size(), 1);
const rapidjson::Value& tablet_server = tablet_servers[rapidjson::SizeType(0)];
ASSERT_STREQ("localhost:1000",
tablet_server["rpc_addrs"][rapidjson::SizeType(0)].GetString());
ASSERT_STREQ("http://localhost:2000",
tablet_server["http_addrs"][rapidjson::SizeType(0)].GetString());
ASSERT_STREQ("my-ts-uuid", tablet_server["uuid"].GetString());
ASSERT_TRUE(tablet_server["millis_since_heartbeat"].GetInt64() >= 0);
ASSERT_EQ(true, tablet_server["live"].GetBool());
ASSERT_STREQ(VersionInfo::GetVersionInfo().c_str(),
tablet_server["version"].GetString());
string start_time;
StringAppendStrftime(&start_time, "%Y-%m-%d %H:%M:%S %Z", static_cast<time_t>(10000), true);
ASSERT_STREQ(start_time.c_str(), tablet_server["start_time"].GetString());
}
// Ensure that trying to re-register with a different version is OK.
{
TSHeartbeatRequestPB req;
TSHeartbeatResponsePB resp;
RpcController rpc;
req.mutable_common()->CopyFrom(common);
req.mutable_registration()->CopyFrom(fake_reg);
req.mutable_replica_management_info()->CopyFrom(rmi);
// This string should never match the actual VersionInfo string, although
// the numeric portion will match.
req.mutable_registration()->set_software_version(Substitute("kudu $0 (rev SOME_NON_GIT_HASH)",
KUDU_VERSION_STRING));
ASSERT_OK(proxy_->TSHeartbeat(req, &resp, &rpc));
ASSERT_FALSE(resp.has_error());
}
// Ensure that trying to re-register with a different start_time is OK.
{
TSHeartbeatRequestPB req;
TSHeartbeatResponsePB resp;
RpcController rpc;
req.mutable_common()->CopyFrom(common);
req.mutable_registration()->CopyFrom(fake_reg);
req.mutable_replica_management_info()->CopyFrom(rmi);
// 10 minutes later.
req.mutable_registration()->set_start_time(10600);
ASSERT_OK(proxy_->TSHeartbeat(req, &resp, &rpc));
ASSERT_FALSE(resp.has_error());
}
// Ensure that trying to re-register with a different port fails.
{
TSHeartbeatRequestPB req;
TSHeartbeatResponsePB resp;
RpcController rpc;
req.mutable_common()->CopyFrom(common);
req.mutable_registration()->CopyFrom(fake_reg);
req.mutable_replica_management_info()->CopyFrom(rmi);
req.mutable_registration()->mutable_rpc_addresses(0)->set_port(1001);
Status s = proxy_->TSHeartbeat(req, &resp, &rpc);
ASSERT_TRUE(s.IsRemoteError()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(),
"Tablet server my-ts-uuid is attempting to re-register "
"with a different host/port.");
}
// Ensure an attempt to register fails if the tablet server uses the replica
// management scheme which is different from the scheme that
// the catalog manager uses.
{
ServerRegistrationPB fake_reg;
MakeHostPortPB("localhost", 3000, fake_reg.add_rpc_addresses());
MakeHostPortPB("localhost", 4000, fake_reg.add_http_addresses());
// Set replica management scheme to something different that master uses
// (here, it's just inverted).
ReplicaManagementInfoPB rmi;
rmi.set_replacement_scheme(FLAGS_raft_prepare_replacement_before_eviction
? ReplicaManagementInfoPB::EVICT_FIRST
: ReplicaManagementInfoPB::PREPARE_REPLACEMENT_BEFORE_EVICTION);
TSHeartbeatRequestPB req;
req.mutable_common()->CopyFrom(common);
req.mutable_registration()->CopyFrom(fake_reg);
req.mutable_replica_management_info()->CopyFrom(rmi);
TSHeartbeatResponsePB resp;
RpcController rpc;
ASSERT_OK(proxy_->TSHeartbeat(req, &resp, &rpc));
ASSERT_TRUE(resp.has_error());
const Status s = StatusFromPB(resp.error().status());
ASSERT_TRUE(s.IsConfigurationError()) << s.ToString();
const string msg = Substitute(
"replica replacement scheme (.*) of the tablet server $0 "
"at .*:[0-9]+ differs from the catalog manager's (.*); "
"they must be run with the same scheme", kTsUUID);
ASSERT_STR_MATCHES(s.ToString(), msg);
}
// Ensure that the TS doesn't register if location mapping fails.
{
// Set a command that always fails.
FLAGS_location_mapping_cmd = "false";
// Restarting the master to take into account the new setting for the
// --location_mapping_cmd flag.
mini_master_->Shutdown();
ASSERT_OK(mini_master_->Restart());
// Set a new UUID so registration is for the first time.
auto new_common = common;
new_common.mutable_ts_instance()->set_permanent_uuid("lmc-fail-ts");
TSHeartbeatRequestPB hb_req;
TSHeartbeatResponsePB hb_resp;
RpcController rpc;
hb_req.mutable_common()->CopyFrom(new_common);
hb_req.mutable_registration()->CopyFrom(fake_reg);
hb_req.mutable_replica_management_info()->CopyFrom(rmi);
// Registration should fail.
Status s = proxy_->TSHeartbeat(hb_req, &hb_resp, &rpc);
ASSERT_TRUE(s.IsRemoteError()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(), "failed to run location mapping command");
// Make sure the tablet server isn't returned to clients.
ListTabletServersRequestPB list_ts_req;
ListTabletServersResponsePB list_ts_resp;
rpc.Reset();
ASSERT_OK(proxy_->ListTabletServers(list_ts_req, &list_ts_resp, &rpc));
LOG(INFO) << SecureDebugString(list_ts_resp);
ASSERT_FALSE(list_ts_resp.has_error());
ASSERT_EQ(0, list_ts_resp.servers_size());
}
}
TEST_F(MasterTest, TestCatalog) {
const char *kTableName = "testtb";
const char *kOtherTableName = "tbtest";
const Schema kTableSchema({ ColumnSchema("key", INT32),
ColumnSchema("v1", UINT64),
ColumnSchema("v2", STRING) },
1);
ASSERT_OK(CreateTable(kTableName, kTableSchema));
ListTablesResponsePB tables;
NO_FATALS(DoListAllTables(&tables));
ASSERT_EQ(1, tables.tables_size());
ASSERT_EQ(kTableName, tables.tables(0).name());
// Delete the table
{
DeleteTableRequestPB req;
DeleteTableResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_name(kTableName);
ASSERT_OK(proxy_->DeleteTable(req, &resp, &controller));
SCOPED_TRACE(SecureDebugString(resp));
ASSERT_FALSE(resp.has_error());
}
// List tables, should show no table
NO_FATALS(DoListAllTables(&tables));
ASSERT_EQ(0, tables.tables_size());
// Re-create the table
ASSERT_OK(CreateTable(kTableName, kTableSchema));
// Restart the master, verify the table still shows up.
mini_master_->Shutdown();
ASSERT_OK(mini_master_->Restart());
ASSERT_OK(mini_master_->master()->
WaitUntilCatalogManagerIsLeaderAndReadyForTests(MonoDelta::FromSeconds(5)));
NO_FATALS(DoListAllTables(&tables));
ASSERT_EQ(1, tables.tables_size());
ASSERT_EQ(kTableName, tables.tables(0).name());
// Test listing tables with a filter.
ASSERT_OK(CreateTable(kOtherTableName, kTableSchema));
{
ListTablesRequestPB req;
req.set_name_filter("test");
DoListTables(req, &tables);
ASSERT_EQ(2, tables.tables_size());
}
{
ListTablesRequestPB req;
req.set_name_filter("tb");
DoListTables(req, &tables);
ASSERT_EQ(2, tables.tables_size());
}
{
ListTablesRequestPB req;
req.set_name_filter(kTableName);
DoListTables(req, &tables);
ASSERT_EQ(1, tables.tables_size());
ASSERT_EQ(kTableName, tables.tables(0).name());
}
{
ListTablesRequestPB req;
req.set_name_filter("btes");
DoListTables(req, &tables);
ASSERT_EQ(1, tables.tables_size());
ASSERT_EQ(kOtherTableName, tables.tables(0).name());
}
{
ListTablesRequestPB req;
req.set_name_filter("randomname");
DoListTables(req, &tables);
ASSERT_EQ(0, tables.tables_size());
}
}
TEST_F(MasterTest, ListTablesWithTableFilter) {
static const char* const kUserTableName = "user_table";
static const char* const kSystemTableName = "system_table";
const Schema kSchema({ColumnSchema("key", INT32), ColumnSchema("v1", INT8)}, 1);
// Make sure this test scenario stays valid
ASSERT_EQ(TableTypePB_MAX, TableTypePB::TXN_STATUS_TABLE);
// Given there is not any tablet server in the cluster, there should be no
// tables out there yet, so a request with an empty (default) filter should
// return empty list of tables.
{
ListTablesRequestPB req;
ListTablesResponsePB resp;
NO_FATALS(DoListTables(req, &resp));
ASSERT_EQ(0, resp.tables_size());
}
// The same reasoning as above, but supply filter with all known table types
// in the 'table_type' field.
{
ListTablesRequestPB req;
req.add_type_filter(TableTypePB::DEFAULT_TABLE);
req.add_type_filter(TableTypePB::TXN_STATUS_TABLE);
ListTablesResponsePB resp;
NO_FATALS(DoListTables(req, &resp));
ASSERT_EQ(0, resp.tables_size());
}
ASSERT_OK(CreateTable(kUserTableName, kSchema));
// An empty 'filter_type' field is equivalent to setting the 'filter_type'
// to [TableTypePB::DEFAULT_TABLE].
{
ListTablesRequestPB req;
ListTablesResponsePB resp;
NO_FATALS(DoListTables(req, &resp));
ASSERT_EQ(1, resp.tables_size());
ASSERT_EQ(kUserTableName, resp.tables(0).name());
}
// Specify the table type filter explicitly.
{
ListTablesRequestPB req;
req.add_type_filter(TableTypePB::DEFAULT_TABLE);
ListTablesResponsePB resp;
NO_FATALS(DoListTables(req, &resp));
ASSERT_EQ(1, resp.tables_size());
ASSERT_EQ(kUserTableName, resp.tables(0).name());
}
// No system tables are present at this point.
{
ListTablesRequestPB req;
req.add_type_filter(TableTypePB::TXN_STATUS_TABLE);
ListTablesResponsePB resp;
NO_FATALS(DoListTables(req, &resp));
ASSERT_EQ(0, resp.tables_size());
}
ASSERT_OK(CreateTable(
kSystemTableName, kSchema, TableTypePB::TXN_STATUS_TABLE));
// Only user tables should be listed because the explicitly specified
// 'type_filter' is set to [TableTypePB::DEFAULT_TABLE].
{
ListTablesRequestPB req;
req.add_type_filter(TableTypePB::DEFAULT_TABLE);
ListTablesResponsePB resp;
NO_FATALS(DoListTables(req, &resp));
ASSERT_EQ(1, resp.tables_size());
ASSERT_EQ(kUserTableName, resp.tables(0).name());
}
// Only the txn status system table should be listed because the explicitly
// specified 'type_filter' is set to [TableTypePB::TXN_STATUS_TABLE].
{
ListTablesRequestPB req;
req.add_type_filter(TableTypePB::TXN_STATUS_TABLE);
ListTablesResponsePB resp;
NO_FATALS(DoListTables(req, &resp));
ASSERT_EQ(1, resp.tables_size());
ASSERT_EQ(kSystemTableName, resp.tables(0).name());
}
// Both tables should be output when the filter is set to
// [TableTypePB::DEFAULT_TABLE, TableTypePB::TXN_STATUS_TABLE].
{
ListTablesRequestPB req;
req.add_type_filter(TableTypePB::DEFAULT_TABLE);
req.add_type_filter(TableTypePB::TXN_STATUS_TABLE);
ListTablesResponsePB resp;
NO_FATALS(DoListTables(req, &resp));
ASSERT_EQ(2, resp.tables_size());
unordered_set<string> table_names;
table_names.emplace(resp.tables(0).name());
table_names.emplace(resp.tables(1).name());
ASSERT_EQ(2, table_names.size());
ASSERT_TRUE(ContainsKey(table_names, kUserTableName));
ASSERT_TRUE(ContainsKey(table_names, kSystemTableName));
}
}
class AlterTableWithRangeSpecificHashSchema : public MasterTest,
public ::testing::WithParamInterface<bool> {};
TEST_P(AlterTableWithRangeSpecificHashSchema, TestAlterTableWithDifferentHashDimensions) {
constexpr const char* const kTableName = "testtb";
const Schema kTableSchema({ColumnSchema("key", INT32),
ColumnSchema("val", INT32)}, 2);
FLAGS_default_num_replicas = 1;
// Create a table with one partition
KuduPartialRow a_lower(&kTableSchema);
KuduPartialRow a_upper(&kTableSchema);
ASSERT_OK(a_lower.SetInt32("key", 0));
ASSERT_OK(a_upper.SetInt32("key", 100));
CreateTableResponsePB create_table_resp;
ASSERT_OK(CreateTable(
kTableName, kTableSchema, nullopt, nullopt, nullopt, {}, {{a_lower, a_upper}},
{}, {{{"key"}, 2, 0}}, &create_table_resp));
// Populate the custom hash schemas with different hash dimension count based on
// the test case
HashSchema custom_range_hash_schema;
const bool has_different_dimensions_count = GetParam();
if (has_different_dimensions_count) {
custom_range_hash_schema = {{{"key"}, 3, 0},
{{"val"}, 3, 0}};
} else {
custom_range_hash_schema = {{{"key"}, 3, 0}};
}
// Create AlterTableRequestPB and populate it for the alter table operation
AlterTableRequestPB req;
AlterTableResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_name(kTableName);
req.mutable_table()->set_table_id(create_table_resp.table_id());
AlterTableRequestPB::Step* step = req.add_alter_schema_steps();
step->set_type(AlterTableRequestPB::ADD_RANGE_PARTITION);
KuduPartialRow lower(&kTableSchema);
ASSERT_OK(lower.SetInt32("key", 200));
KuduPartialRow upper(&kTableSchema);
ASSERT_OK(upper.SetInt32("key", 300));
RowOperationsPBEncoder splits_encoder(
step->mutable_add_range_partition()->mutable_range_bounds());
splits_encoder.Add(RowOperationsPB::RANGE_LOWER_BOUND, lower);
splits_encoder.Add(RowOperationsPB::RANGE_UPPER_BOUND, upper);
for (const auto& hash_dimension: custom_range_hash_schema) {
auto* hash_dimension_pb =
step->mutable_add_range_partition()->mutable_custom_hash_schema()->
add_hash_schema();
for (const string& col_name: hash_dimension.columns) {
hash_dimension_pb->add_columns()->set_name(col_name);
}
hash_dimension_pb->set_num_buckets(hash_dimension.num_buckets);
hash_dimension_pb->set_seed(hash_dimension.seed);
}
{
auto* col = req.mutable_schema()->add_columns();
col->set_name("key");
col->set_type(INT32);
col->set_is_key(true);
}
{
auto* col = req.mutable_schema()->add_columns();
col->set_name("val");
col->set_type(INT32);
col->set_is_key(true);
}
// Check the number of tablets in the table
std::vector<scoped_refptr<TableInfo>> tables;
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
master_->catalog_manager()->GetAllTables(&tables);
}
ASSERT_EQ(1, tables.size());
ASSERT_EQ(2, tables.front()->num_tablets());
// Submit the alter table request
ASSERT_OK(proxy_->AlterTable(req, &resp, &controller));
if (has_different_dimensions_count) {
ASSERT_TRUE(resp.has_error());
ASSERT_STR_CONTAINS(resp.error().status().DebugString(),
"varying number of hash dimensions per range is not yet supported");
} else {
ASSERT_FALSE(resp.has_error());
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
master_->catalog_manager()->GetAllTables(&tables);
}
ASSERT_EQ(1, tables.size());
ASSERT_EQ(5, tables.front()->num_tablets());
}
}
INSTANTIATE_TEST_SUITE_P(AlterTableWithCustomHashSchema,
AlterTableWithRangeSpecificHashSchema, ::testing::Bool());
TEST_F(MasterTest, AlterTableAddAndDropRangeWithSpecificHashSchema) {
constexpr const char* const kTableName = "alter_table_custom_hash_schema";
constexpr const char* const kCol0 = "c_int32";
constexpr const char* const kCol1 = "c_int64";
const Schema kTableSchema({ColumnSchema(kCol0, INT32),
ColumnSchema(kCol1, INT64)}, 2);
FLAGS_default_num_replicas = 1;
// Create a table with one range partition based on the table-wide hash schema.
CreateTableResponsePB create_table_resp;
{
KuduPartialRow lower(&kTableSchema);
ASSERT_OK(lower.SetInt32(kCol0, 0));
KuduPartialRow upper(&kTableSchema);
ASSERT_OK(upper.SetInt32(kCol0, 100));
ASSERT_OK(CreateTable(
kTableName, kTableSchema, nullopt, nullopt, nullopt, {}, {{lower, upper}},
{}, {{{kCol0}, 2, 0}}, &create_table_resp));
}
// Check the number of tablets in the table before ALTER TABLE.
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
std::vector<scoped_refptr<TableInfo>> tables;
master_->catalog_manager()->GetAllTables(&tables);
ASSERT_EQ(1, tables.size());
// 2 tablets (because of 2 hash buckets) for already existing range.
ASSERT_EQ(2, tables.front()->num_tablets());
// Check the partition schema stored in the system catalog.
PartitionSchemaPB ps_pb;
ASSERT_OK(GetTablePartitionSchema(kTableName, &ps_pb));
ASSERT_EQ(0, ps_pb.custom_hash_schema_ranges_size());
}
const auto& table_id = create_table_resp.table_id();
const HashSchema custom_hash_schema{{{kCol0,kCol1}, 5, 1}};
// Alter the table, adding a new range with custom hash schema.
{
AlterTableRequestPB req;
AlterTableResponsePB resp;
req.mutable_table()->set_table_name(kTableName);
req.mutable_table()->set_table_id(table_id);
// Add the required information on the table's schema:
// key and non-null columns must be present in the request.
{
auto* col = req.mutable_schema()->add_columns();
col->set_name(kCol0);
col->set_type(INT32);
col->set_is_key(true);
}
{
auto* col = req.mutable_schema()->add_columns();
col->set_name(kCol1);
col->set_type(INT64);
col->set_is_key(true);
}
AlterTableRequestPB::Step* step = req.add_alter_schema_steps();
step->set_type(AlterTableRequestPB::ADD_RANGE_PARTITION);
KuduPartialRow lower(&kTableSchema);
ASSERT_OK(lower.SetInt32(kCol0, 100));
KuduPartialRow upper(&kTableSchema);
ASSERT_OK(upper.SetInt32(kCol0, 200));
RowOperationsPBEncoder enc(
step->mutable_add_range_partition()->mutable_range_bounds());
enc.Add(RowOperationsPB::RANGE_LOWER_BOUND, lower);
enc.Add(RowOperationsPB::RANGE_UPPER_BOUND, upper);
for (const auto& hash_dimension: custom_hash_schema) {
auto* hash_dimension_pb = step->mutable_add_range_partition()->
mutable_custom_hash_schema()->add_hash_schema();
for (const auto& col_name: hash_dimension.columns) {
hash_dimension_pb->add_columns()->set_name(col_name);
}
hash_dimension_pb->set_num_buckets(hash_dimension.num_buckets);
hash_dimension_pb->set_seed(hash_dimension.seed);
}
RpcController ctl;
ASSERT_OK(proxy_->AlterTable(req, &resp, &ctl));
ASSERT_FALSE(resp.has_error())
<< StatusFromPB(resp.error().status()).ToString();
}
// Check the number of tablets in the table after ALTER TABLE.
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
std::vector<scoped_refptr<TableInfo>> tables;
master_->catalog_manager()->GetAllTables(&tables);
ASSERT_EQ(1, tables.size());
// Extra 5 tablets (because of 5 hash buckets) for newly added range.
ASSERT_EQ(7, tables.front()->num_tablets());
// Check the partition schema stored in the system catalog.
PartitionSchemaPB ps_pb;
ASSERT_OK(GetTablePartitionSchema(kTableName, &ps_pb));
ASSERT_EQ(1, ps_pb.custom_hash_schema_ranges_size());
// Check the hash schema parameters (i.e. columns and number of hash
// buckets) are stored and read back by the client as expected.
const auto& range = ps_pb.custom_hash_schema_ranges(0);
ASSERT_EQ(1, range.hash_schema_size());
const auto& hash_schema = range.hash_schema(0);
ASSERT_EQ(5, hash_schema.num_buckets());
ASSERT_EQ(1, hash_schema.seed());
ASSERT_EQ(2, hash_schema.columns_size());
const auto schema = kTableSchema.CopyWithColumnIds();
const auto ref_col_0_id = int32_t(schema.column_id(0));
const auto& col_0 = hash_schema.columns(0);
ASSERT_TRUE(col_0.has_id());
ASSERT_EQ(ref_col_0_id, col_0.id());
const auto ref_col_1_id = int32_t(schema.column_id(1));
const auto& col_1 = hash_schema.columns(1);
ASSERT_TRUE(col_1.has_id());
ASSERT_EQ(ref_col_1_id, col_1.id());
}
// Verify the table's schema: fetch the information on the altered
// table and make sure the schema contains information on the newly added
// range partition with the custom hash schema.
{
GetTableSchemaRequestPB req;
req.mutable_table()->set_table_name(kTableName);
RpcController ctl;
GetTableSchemaResponsePB resp;
ASSERT_OK(proxy_->GetTableSchema(req, &resp, &ctl));
ASSERT_FALSE(resp.has_error())
<< StatusFromPB(resp.error().status()).ToString();
Schema received_schema;
ASSERT_TRUE(resp.has_schema());
ASSERT_OK(SchemaFromPB(resp.schema(), &received_schema));
ASSERT_TRUE(kTableSchema == received_schema) << Substitute(
"$0 not equal to $1", kTableSchema.ToString(), received_schema.ToString());
ASSERT_TRUE(resp.has_table_id());
ASSERT_EQ(table_id, resp.table_id());
ASSERT_TRUE(resp.has_table_name());
ASSERT_EQ(kTableName, resp.table_name());
ASSERT_TRUE(resp.has_partition_schema());
PartitionSchema ps;
ASSERT_OK(PartitionSchema::FromPB(
resp.partition_schema(), received_schema, &ps));
ASSERT_TRUE(ps.HasCustomHashSchemas());
// Verify that PartitionSchema::FromPB() translated/retrieved the data
// from PartitionSchemaPB as expected.
const auto& table_wide_hash_schema = ps.hash_schema();
ASSERT_EQ(1, table_wide_hash_schema.size());
ASSERT_EQ(2, table_wide_hash_schema.front().num_buckets);
const auto& ranges_with_hash_schemas = ps.ranges_with_custom_hash_schemas();
ASSERT_EQ(1, ranges_with_hash_schemas.size());
const auto& custom_hash_schema = ranges_with_hash_schemas.front().hash_schema;
ASSERT_EQ(1, custom_hash_schema.size());
const auto& hash_dimension = custom_hash_schema.front();
ASSERT_EQ(5, hash_dimension.num_buckets);
ASSERT_EQ(1, hash_dimension.seed);
ASSERT_EQ(2, hash_dimension.column_ids.size());
const auto& column_ids = hash_dimension.column_ids;
const auto schema = kTableSchema.CopyWithColumnIds();
const ColumnId ref_col_0_id = schema.column_id(0);
ASSERT_EQ(ref_col_0_id, column_ids[0]);
const ColumnId ref_col_1_id = schema.column_id(1);
ASSERT_EQ(ref_col_1_id, column_ids[1]);
}
// Verify that everything works as expected when dropping a range
// partition with custom hash schema.
{
AlterTableRequestPB req;
req.mutable_table()->set_table_name(kTableName);
req.mutable_table()->set_table_id(table_id);
// Add the required information on the table's schema:
// key and non-null columns must be present in the request.
{
auto* col = req.mutable_schema()->add_columns();
col->set_name(kCol0);
col->set_type(INT32);
col->set_is_key(true);
}
{
auto* col = req.mutable_schema()->add_columns();
col->set_name(kCol1);
col->set_type(INT64);
col->set_is_key(true);
}
AlterTableRequestPB::Step* step = req.add_alter_schema_steps();
step->set_type(AlterTableRequestPB::DROP_RANGE_PARTITION);
KuduPartialRow lower(&kTableSchema);
ASSERT_OK(lower.SetInt32(kCol0, 100));
KuduPartialRow upper(&kTableSchema);
ASSERT_OK(upper.SetInt32(kCol0, 200));
RowOperationsPBEncoder enc(
step->mutable_drop_range_partition()->mutable_range_bounds());
enc.Add(RowOperationsPB::RANGE_LOWER_BOUND, lower);
enc.Add(RowOperationsPB::RANGE_UPPER_BOUND, upper);
// Check the number of tablets in the table before ALTER TABLE.
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
std::vector<scoped_refptr<TableInfo>> tables;
master_->catalog_manager()->GetAllTables(&tables);
ASSERT_EQ(1, tables.size());
// Extra 5 tablets (because of 5 hash buckets) for newly added range.
ASSERT_EQ(7, tables.front()->num_tablets());
// Check the partition schema stored in the system catalog.
PartitionSchemaPB ps_pb;
ASSERT_OK(GetTablePartitionSchema(kTableName, &ps_pb));
ASSERT_EQ(1, ps_pb.custom_hash_schema_ranges_size());
}
RpcController ctl;
AlterTableResponsePB resp;
ASSERT_OK(proxy_->AlterTable(req, &resp, &ctl));
ASSERT_FALSE(resp.has_error())
<< StatusFromPB(resp.error().status()).ToString();
// Check the number of tablets in the table after ALTER TABLE.
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
std::vector<scoped_refptr<TableInfo>> tables;
master_->catalog_manager()->GetAllTables(&tables);
ASSERT_EQ(1, tables.size());
// 2 tablets (because of 2 hash buckets) for already existing range.
ASSERT_EQ(2, tables.front()->num_tablets());
// Check the partition schema stored in the system catalog.
PartitionSchemaPB ps_pb;
ASSERT_OK(GetTablePartitionSchema(kTableName, &ps_pb));
ASSERT_EQ(0, ps_pb.custom_hash_schema_ranges_size());
}
}
}
TEST_F(MasterTest, AlterTableAddRangeWithSpecificHashSchemaWrongBucketNumber) {
constexpr const char* const kTableName = "wrong_bucket_number_in_hash_schema";
constexpr const char* const kCol0 = "c_int32";
constexpr const char* const kCol1 = "c_int64";
const Schema kTableSchema({ColumnSchema(kCol0, INT32),
ColumnSchema(kCol1, INT64)}, 1);
FLAGS_default_num_replicas = 1;
// Create a table with one range partition based on the table-wide hash schema.
CreateTableResponsePB create_table_resp;
{
KuduPartialRow lower(&kTableSchema);
ASSERT_OK(lower.SetInt32(kCol0, 0));
KuduPartialRow upper(&kTableSchema);
ASSERT_OK(upper.SetInt32(kCol0, 100));
ASSERT_OK(CreateTable(
kTableName, kTableSchema, nullopt, nullopt, nullopt, {}, {{lower, upper}},
{}, {{{kCol0}, 2, 0}}, &create_table_resp));
}
// Check the number of tablets in the table before ALTER TABLE.
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
std::vector<scoped_refptr<TableInfo>> tables;
master_->catalog_manager()->GetAllTables(&tables);
ASSERT_EQ(1, tables.size());
ASSERT_EQ(2, tables.front()->num_tablets());
}
const auto& table_id = create_table_resp.table_id();
// Try altering the table, adding a new range with custom hash schema where
// the number of hash buckets is incorrect.
for (auto bucket_num = -1; bucket_num < 2; ++bucket_num) {
SCOPED_TRACE(Substitute("number of hash buckets: $0", bucket_num));
const HashSchema custom_hash_schema{{{kCol0}, bucket_num, 222}};
AlterTableRequestPB req;
AlterTableResponsePB resp;
req.mutable_table()->set_table_name(kTableName);
req.mutable_table()->set_table_id(table_id);
// Add the required information on the table's schema:
// key and non-null columns must be present in the request.
{
auto* col = req.mutable_schema()->add_columns();
col->set_name(kCol0);
col->set_type(INT32);
col->set_is_key(true);
}
{
auto* col = req.mutable_schema()->add_columns();
col->set_name(kCol1);
col->set_type(INT64);
}
AlterTableRequestPB::Step* step = req.add_alter_schema_steps();
step->set_type(AlterTableRequestPB::ADD_RANGE_PARTITION);
KuduPartialRow lower(&kTableSchema);
ASSERT_OK(lower.SetInt32(kCol0, 100));
KuduPartialRow upper(&kTableSchema);
ASSERT_OK(upper.SetInt32(kCol0, 200));
RowOperationsPBEncoder enc(
step->mutable_add_range_partition()->mutable_range_bounds());
enc.Add(RowOperationsPB::RANGE_LOWER_BOUND, lower);
enc.Add(RowOperationsPB::RANGE_UPPER_BOUND, upper);
for (const auto& hash_dimension: custom_hash_schema) {
auto* hash_dimension_pb = step->mutable_add_range_partition()->
mutable_custom_hash_schema()->add_hash_schema();
for (const auto& col_name: hash_dimension.columns) {
hash_dimension_pb->add_columns()->set_name(col_name);
}
hash_dimension_pb->set_num_buckets(hash_dimension.num_buckets);
hash_dimension_pb->set_seed(hash_dimension.seed);
}
RpcController ctl;
ASSERT_OK(proxy_->AlterTable(req, &resp, &ctl));
ASSERT_TRUE(resp.has_error());
const auto s = StatusFromPB(resp.error().status());
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(), "must have at least two hash buckets");
}
// One more sanity check: the number of tablets in the table after
// attempted, but failed ALTER TABLE should stay the same as before.
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
std::vector<scoped_refptr<TableInfo>> tables;
master_->catalog_manager()->GetAllTables(&tables);
ASSERT_EQ(1, tables.size());
ASSERT_EQ(2, tables.front()->num_tablets());
}
}
// This scenario verifies that when the support for range-specific hash schemas
// is enabled, adding and dropping range partitions with table-wide hash schemas
// works as expected.
TEST_F(MasterTest, AlterTableAddDropRangeWithTableWideHashSchema) {
constexpr const char* const kTableName = "alter_with_table_wide_hash_schema";
constexpr const char* const kCol0 = "c_int32";
constexpr const char* const kCol1 = "c_int64";
constexpr const char* const kCol2 = "c_string";
const Schema kTableSchema({ColumnSchema(kCol0, INT32),
ColumnSchema(kCol1, INT64),
ColumnSchema(kCol2, STRING)}, 2);
FLAGS_default_num_replicas = 1;
// Create a table with one range partition based on the table-wide hash schema.
CreateTableResponsePB create_table_resp;
{
KuduPartialRow lower(&kTableSchema);
ASSERT_OK(lower.SetInt32(kCol0, 0));
KuduPartialRow upper(&kTableSchema);
ASSERT_OK(upper.SetInt32(kCol0, 100));
ASSERT_OK(CreateTable(
kTableName, kTableSchema, nullopt, nullopt, nullopt, {},
{{lower, upper}}, {}, {{{kCol0, kCol1}, 3, 5}}, &create_table_resp));
}
const auto& table_id = create_table_resp.table_id();
// Check the number of tablets in the newly created table.
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
std::vector<scoped_refptr<TableInfo>> tables;
master_->catalog_manager()->GetAllTables(&tables);
ASSERT_EQ(1, tables.size());
// There should be 3 tablets (because of 3 hash buckets) for
// already existing range added upon the creation of a table.
ASSERT_EQ(3, tables.front()->num_tablets());
PartitionSchemaPB ps_pb;
ASSERT_OK(GetTablePartitionSchema(kTableName, &ps_pb));
ASSERT_EQ(0, ps_pb.custom_hash_schema_ranges_size());
ASSERT_EQ(1, ps_pb.hash_schema_size());
}
// Alter the table, adding a new range with table-wide hash schema.
{
AlterTableRequestPB req;
req.mutable_table()->set_table_name(kTableName);
req.mutable_table()->set_table_id(table_id);
// Add the required information on the table's schema:
// key and non-null columns must be present in the request.
{
auto* col = req.mutable_schema()->add_columns();
col->set_name(kCol0);
col->set_type(INT32);
col->set_is_key(true);
}
{
auto* col = req.mutable_schema()->add_columns();
col->set_name(kCol1);
col->set_type(INT64);
col->set_is_key(true);
}
{
auto* col = req.mutable_schema()->add_columns();
col->set_name(kCol2);
col->set_type(STRING);
}
AlterTableRequestPB::Step* step = req.add_alter_schema_steps();
step->set_type(AlterTableRequestPB::ADD_RANGE_PARTITION);
KuduPartialRow lower(&kTableSchema);
ASSERT_OK(lower.SetInt32(kCol0, 100));
KuduPartialRow upper(&kTableSchema);
ASSERT_OK(upper.SetInt32(kCol0, 200));
RowOperationsPBEncoder enc(
step->mutable_add_range_partition()->mutable_range_bounds());
enc.Add(RowOperationsPB::RANGE_LOWER_BOUND, lower);
enc.Add(RowOperationsPB::RANGE_UPPER_BOUND, upper);
RpcController ctl;
AlterTableResponsePB resp;
ASSERT_OK(proxy_->AlterTable(req, &resp, &ctl));
ASSERT_FALSE(resp.has_error())
<< StatusFromPB(resp.error().status()).ToString();
}
// Check the number of tablets in the table after adding a new range.
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
std::vector<scoped_refptr<TableInfo>> tables;
master_->catalog_manager()->GetAllTables(&tables);
ASSERT_EQ(1, tables.size());
// Extra 3 tablets (because of 3 hash buckets) for the newly added range.
ASSERT_EQ(6, tables.front()->num_tablets());
// Check the partition schema stored in the system catalog.
PartitionSchemaPB ps_pb;
ASSERT_OK(GetTablePartitionSchema(kTableName, &ps_pb));
ASSERT_EQ(0, ps_pb.custom_hash_schema_ranges_size());
// Check the parameters of the table-wide hash schema.
ASSERT_EQ(1, ps_pb.hash_schema_size());
const auto& hash_schema = ps_pb.hash_schema(0);
ASSERT_EQ(3, hash_schema.num_buckets());
//ASSERT_EQ(5, hash_schema.seed());
ASSERT_EQ(2, hash_schema.columns_size());
const auto schema = kTableSchema.CopyWithColumnIds();
const auto ref_col_0_id = int32_t(schema.column_id(0));
const auto& col_0 = hash_schema.columns(0);
ASSERT_TRUE(col_0.has_id());
ASSERT_EQ(ref_col_0_id, col_0.id());
const auto ref_col_1_id = int32_t(schema.column_id(1));
const auto& col_1 = hash_schema.columns(1);
ASSERT_TRUE(col_1.has_id());
ASSERT_EQ(ref_col_1_id, col_1.id());
}
{
AlterTableRequestPB req;
req.mutable_table()->set_table_name(kTableName);
req.mutable_table()->set_table_id(table_id);
// Add the required information on the table's schema:
// key and non-null columns must be present in the request.
{
auto* col = req.mutable_schema()->add_columns();
col->set_name(kCol0);
col->set_type(INT32);
col->set_is_key(true);
}
{
auto* col = req.mutable_schema()->add_columns();
col->set_name(kCol1);
col->set_type(INT64);
col->set_is_key(true);
}
{
auto* col = req.mutable_schema()->add_columns();
col->set_name(kCol2);
col->set_type(STRING);
}
AlterTableRequestPB::Step* step = req.add_alter_schema_steps();
step->set_type(AlterTableRequestPB::DROP_RANGE_PARTITION);
KuduPartialRow lower(&kTableSchema);
ASSERT_OK(lower.SetInt32(kCol0, 100));
KuduPartialRow upper(&kTableSchema);
ASSERT_OK(upper.SetInt32(kCol0, 200));
RowOperationsPBEncoder enc(
step->mutable_drop_range_partition()->mutable_range_bounds());
enc.Add(RowOperationsPB::RANGE_LOWER_BOUND, lower);
enc.Add(RowOperationsPB::RANGE_UPPER_BOUND, upper);
RpcController ctl;
AlterTableResponsePB resp;
ASSERT_OK(proxy_->AlterTable(req, &resp, &ctl));
ASSERT_FALSE(resp.has_error())
<< StatusFromPB(resp.error().status()).ToString();
}
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
std::vector<scoped_refptr<TableInfo>> tables;
master_->catalog_manager()->GetAllTables(&tables);
ASSERT_EQ(1, tables.size());
// There should be just 3 tablets left since the range has been dropped.
ASSERT_EQ(3, tables.front()->num_tablets());
}
}
TEST_F(MasterTest, MasterWebUIWithCustomHashPartitioning) {
constexpr const char* const kTableName = "master_webui_custom_hash_ps";
constexpr const char* const kCol0 = "c_int32";
constexpr const char* const kCol1 = "c_int64";
const Schema kTableSchema({ColumnSchema(kCol0, INT32),
ColumnSchema(kCol1, INT64)}, 2);
FLAGS_default_num_replicas = 1;
// Create a table with one range partition based on the table-wide hash schema.
CreateTableResponsePB create_table_resp;
{
KuduPartialRow lower(&kTableSchema);
ASSERT_OK(lower.SetInt32(kCol0, 0));
ASSERT_OK(lower.SetInt64(kCol1, 0));
KuduPartialRow upper(&kTableSchema);
ASSERT_OK(upper.SetInt32(kCol0, 100));
ASSERT_OK(upper.SetInt64(kCol1, 100));
ASSERT_OK(CreateTable(
kTableName, kTableSchema, nullopt, nullopt, nullopt, {}, {{lower, upper}},
{}, {{{kCol0}, 2, 0}, {{kCol1}, 2, 0}}, &create_table_resp));
}
// Get all the tablets of this table
std::vector<scoped_refptr<TableInfo>> tables;
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
master_->catalog_manager()->GetAllTables(&tables);
}
ASSERT_EQ(1, tables.size());
vector<scoped_refptr<TabletInfo>> tablets;
tables.front()->GetAllTablets(&tablets);
ASSERT_EQ(4, tablets.size());
EasyCurl c;
faststring buf;
ASSERT_OK(c.FetchURL(Substitute("http://$0/table?id=$1",
mini_master_->bound_http_addr().ToString(),
create_table_resp.table_id()),
&buf));
string raw = buf.ToString();
// Check the "Partition Schema" section
ASSERT_STR_CONTAINS(raw,
"\"partition_schema\":\""
"HASH (c_int32) PARTITIONS 2,\\n"
"HASH (c_int64) PARTITIONS 2,\\n"
"RANGE (c_int32, c_int64) (\\n"
" PARTITION (0, 0) <= VALUES < (100, 100)\\n"
")\"");
// Check the "Detail" table section
{
int k = 0;
for (int i = 0; i < 2; i++) {
for (int j = 0; j < 2; j++) {
ASSERT_STR_CONTAINS(raw,
Substitute(
"\"id\":\"$0\",\"partition_cols\":\"<td>Table Wide</td>"
"<td>HASH (c_int32) PARTITIONS 2<br>"
"HASH (c_int64) PARTITIONS 2<br></td>"
"<td>HASH (c_int32) PARTITION: $1<br>"
"HASH (c_int64) PARTITION: $2<br></td>"
"<td>(0, 0) &lt;= VALUES &lt; (100, 100)</td>\"",
tablets[k++]->id(), i, j));
}
}
}
const auto& table_id = create_table_resp.table_id();
const HashSchema custom_hash_schema{{{kCol0}, 2, 0}, {{kCol1}, 3, 0}};
// Alter the table, adding a new range with custom hash schema.
{
AlterTableRequestPB req;
AlterTableResponsePB resp;
req.mutable_table()->set_table_name(kTableName);
req.mutable_table()->set_table_id(table_id);
// Add the required information on the table's schema:
// key and non-null columns must be present in the request.
{
ColumnSchemaPB* col0 = req.mutable_schema()->add_columns();
col0->set_name(kCol0);
col0->set_type(INT32);
col0->set_is_key(true);
ColumnSchemaPB* col1 = req.mutable_schema()->add_columns();
col1->set_name(kCol1);
col1->set_type(INT64);
col1->set_is_key(true);
}
AlterTableRequestPB::Step* step = req.add_alter_schema_steps();
step->set_type(AlterTableRequestPB::ADD_RANGE_PARTITION);
KuduPartialRow lower(&kTableSchema);
ASSERT_OK(lower.SetInt32(kCol0, 100));
ASSERT_OK(lower.SetInt64(kCol1, 100));
KuduPartialRow upper(&kTableSchema);
ASSERT_OK(upper.SetInt32(kCol0, 200));
ASSERT_OK(upper.SetInt64(kCol1, 200));
RowOperationsPBEncoder enc(
step->mutable_add_range_partition()->mutable_range_bounds());
enc.Add(RowOperationsPB::RANGE_LOWER_BOUND, lower);
enc.Add(RowOperationsPB::RANGE_UPPER_BOUND, upper);
for (const auto& hash_dimension: custom_hash_schema) {
auto* hash_dimension_pb = step->mutable_add_range_partition()->
mutable_custom_hash_schema()->add_hash_schema();
for (const auto& col_name: hash_dimension.columns) {
hash_dimension_pb->add_columns()->set_name(col_name);
}
hash_dimension_pb->set_num_buckets(hash_dimension.num_buckets);
hash_dimension_pb->set_seed(hash_dimension.seed);
}
RpcController ctl;
ASSERT_OK(proxy_->AlterTable(req, &resp, &ctl));
ASSERT_FALSE(resp.has_error())
<< StatusFromPB(resp.error().status()).ToString();
}
ASSERT_OK(c.FetchURL(Substitute("http://$0/table?id=$1",
mini_master_->bound_http_addr().ToString(),
create_table_resp.table_id()),
&buf));
raw = buf.ToString();
// Check the "Partition Schema" section
ASSERT_STR_CONTAINS(raw, "\"partition_schema\":\""
"HASH (c_int32) PARTITIONS 2,\\n"
"HASH (c_int64) PARTITIONS 2,\\n"
"RANGE (c_int32, c_int64) (\\n"
" PARTITION (0, 0) <= VALUES < (100, 100),\\n"
" PARTITION (100, 100) <= VALUES < (200, 200) "
"HASH(c_int32) PARTITIONS 2 HASH(c_int64) PARTITIONS 3\\n)");
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
master_->catalog_manager()->GetAllTables(&tables);
}
ASSERT_EQ(1, tables.size());
tables.front()->GetAllTablets(&tablets);
// At this point we have the previously created 4 tables and now added 6 tablets
ASSERT_EQ(10, tablets.size());
// Check the "Detail" table section of all the 10 tablets present
for (int i = 0; i < 2; i++) {
ASSERT_STR_CONTAINS(raw,Substitute(
"\"id\":\"$0\",\"partition_cols\":\"<td>Table Wide</td>"
"<td>HASH (c_int32) PARTITIONS 2<br>"
"HASH (c_int64) PARTITIONS 2<br></td>"
"<td>HASH (c_int32) PARTITION: $1<br>"
"HASH (c_int64) PARTITION: 0<br></td>"
"<td>(0, 0) &lt;= VALUES &lt; (100, 100)</td>\"",
tablets[i*5+0]->id(), i));
ASSERT_STR_CONTAINS(raw,Substitute(
"\"id\":\"$0\",\"partition_cols\":\"<td>Range Specific</td>"
"<td>HASH (c_int32) PARTITIONS 2<br>"
"HASH (c_int64) PARTITIONS 3<br></td>"
"<td>HASH (c_int32) PARTITION: $1<br>"
"HASH (c_int64) PARTITION: 0<br></td>"
"<td>(100, 100) &lt;= VALUES &lt; (200, 200)</td>\"",
tablets[i*5+1]->id(), i));
ASSERT_STR_CONTAINS(raw,Substitute(
"\"id\":\"$0\",\"partition_cols\":\"<td>Table Wide</td>"
"<td>HASH (c_int32) PARTITIONS 2<br>"
"HASH (c_int64) PARTITIONS 2<br></td>"
"<td>HASH (c_int32) PARTITION: $1<br>"
"HASH (c_int64) PARTITION: 1<br></td>"
"<td>(0, 0) &lt;= VALUES &lt; (100, 100)</td>\"",
tablets[i*5+2]->id(), i));
ASSERT_STR_CONTAINS(raw,Substitute(
"\"id\":\"$0\",\"partition_cols\":\"<td>Range Specific</td>"
"<td>HASH (c_int32) PARTITIONS 2<br>"
"HASH (c_int64) PARTITIONS 3<br></td>"
"<td>HASH (c_int32) PARTITION: $1<br>"
"HASH (c_int64) PARTITION: 1<br></td>"
"<td>(100, 100) &lt;= VALUES &lt; (200, 200)</td>\"",
tablets[i*5+3]->id(), i));
ASSERT_STR_CONTAINS(raw,Substitute(
"\"id\":\"$0\",\"partition_cols\":\"<td>Range Specific</td>"
"<td>HASH (c_int32) PARTITIONS 2<br>"
"HASH (c_int64) PARTITIONS 3<br></td>"
"<td>HASH (c_int32) PARTITION: $1<br>"
"HASH (c_int64) PARTITION: 2<br></td>"
"<td>(100, 100) &lt;= VALUES &lt; (200, 200)</td>\"",
tablets[i*5+4]->id(), i));
}
}
TEST_F(MasterTest, TestCreateTableCheckRangeInvariants) {
constexpr const char* const kTableName = "testtb";
const Schema kTableSchema({ ColumnSchema("key", INT32), ColumnSchema("val", INT32) }, 1);
// No duplicate split rows.
{
KuduPartialRow split1(&kTableSchema);
ASSERT_OK(split1.SetInt32("key", 1));
KuduPartialRow split2(&kTableSchema);
ASSERT_OK(split2.SetInt32("key", 2));
Status s = CreateTable(kTableName, kTableSchema, { split1, split1, split2 });
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(), "duplicate split row");
}
// No empty split rows.
{
KuduPartialRow split1(&kTableSchema);
ASSERT_OK(split1.SetInt32("key", 1));
KuduPartialRow split2(&kTableSchema);
Status s = CreateTable(kTableName, kTableSchema, { split1, split2 });
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(),
"split rows must contain a value for at "
"least one range partition column");
}
// In case of custom hash schemas per range, don't supply the information
// on split rows.
{
google::FlagSaver flag_saver;
KuduPartialRow split1(&kTableSchema);
ASSERT_OK(split1.SetInt32("key", 1));
KuduPartialRow a_lower(&kTableSchema);
KuduPartialRow a_upper(&kTableSchema);
ASSERT_OK(a_lower.SetInt32("key", 0));
ASSERT_OK(a_upper.SetInt32("key", 100));
const auto s = CreateTable(kTableName,
kTableSchema,
{split1},
{},
{{ a_lower, a_upper, {}}});
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(),
"both split rows and custom hash schema ranges "
"must not be populated at the same time");
}
// In case of custom hash schemas per range, don't supply the information
// on the range partition boundaries via both the
// CreateTableRequestPB::split_rows_range_bounds and the
// CreateTableRequestPB::partition_schema::custom_hash_schema_ranges fields.
{
google::FlagSaver flag_saver;
KuduPartialRow a_lower(&kTableSchema);
KuduPartialRow a_upper(&kTableSchema);
ASSERT_OK(a_lower.SetInt32("key", 0));
ASSERT_OK(a_upper.SetInt32("key", 100));
vector<HashSchema> range_hash_schemas = {{}};
const auto s = CreateTable(kTableName,
kTableSchema,
vector<KuduPartialRow>(),
{{ a_lower, a_upper }},
{{ a_lower, a_upper, {}}});
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(),
"both range bounds and custom hash schema ranges "
"must not be populated at the same time");
}
// No non-range columns.
{
KuduPartialRow split(&kTableSchema);
ASSERT_OK(split.SetInt32("key", 1));
ASSERT_OK(split.SetInt32("val", 1));
Status s = CreateTable(kTableName, kTableSchema, { split });
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(),
"split rows may only contain values for "
"range partition columns: val");
}
{ // Overlapping bounds.
KuduPartialRow a_lower(&kTableSchema);
KuduPartialRow a_upper(&kTableSchema);
KuduPartialRow b_lower(&kTableSchema);
KuduPartialRow b_upper(&kTableSchema);
ASSERT_OK(a_lower.SetInt32("key", 0));
ASSERT_OK(a_upper.SetInt32("key", 100));
ASSERT_OK(b_lower.SetInt32("key", 50));
ASSERT_OK(b_upper.SetInt32("key", 150));
Status s = CreateTable(kTableName,
kTableSchema,
{},
{ { a_lower, a_upper }, { b_lower, b_upper } });
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(), "overlapping range partition");
}
{ // Split row out of bounds (above).
KuduPartialRow bound_lower(&kTableSchema);
KuduPartialRow bound_upper(&kTableSchema);
ASSERT_OK(bound_lower.SetInt32("key", 0));
ASSERT_OK(bound_upper.SetInt32("key", 150));
KuduPartialRow split(&kTableSchema);
ASSERT_OK(split.SetInt32("key", 200));
Status s = CreateTable(
kTableName, kTableSchema, { split }, { { bound_lower, bound_upper } });
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(), "split out of bounds");
}
{ // Split row out of bounds (below).
KuduPartialRow bound_lower(&kTableSchema);
KuduPartialRow bound_upper(&kTableSchema);
ASSERT_OK(bound_lower.SetInt32("key", 0));
ASSERT_OK(bound_upper.SetInt32("key", 150));
KuduPartialRow split(&kTableSchema);
ASSERT_OK(split.SetInt32("key", -120));
Status s = CreateTable(
kTableName, kTableSchema, { split }, { { bound_lower, bound_upper } });
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(), "split out of bounds");
}
{ // Lower bound greater than upper bound.
KuduPartialRow bound_lower(&kTableSchema);
KuduPartialRow bound_upper(&kTableSchema);
ASSERT_OK(bound_lower.SetInt32("key", 150));
ASSERT_OK(bound_upper.SetInt32("key", 0));
Status s = CreateTable(
kTableName, kTableSchema, vector<KuduPartialRow>{},
{ { bound_lower, bound_upper } });
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(
s.ToString(),
"range partition lower bound must be less than the upper bound");
}
{ // Lower bound equals upper bound.
KuduPartialRow bound_lower(&kTableSchema);
KuduPartialRow bound_upper(&kTableSchema);
ASSERT_OK(bound_lower.SetInt32("key", 0));
ASSERT_OK(bound_upper.SetInt32("key", 0));
Status s = CreateTable(
kTableName, kTableSchema,
vector<KuduPartialRow>{}, { { bound_lower, bound_upper } });
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(
s.ToString(),
"range partition lower bound must be less than the upper bound");
}
{ // Split equals lower bound
KuduPartialRow bound_lower(&kTableSchema);
KuduPartialRow bound_upper(&kTableSchema);
ASSERT_OK(bound_lower.SetInt32("key", 0));
ASSERT_OK(bound_upper.SetInt32("key", 10));
KuduPartialRow split(&kTableSchema);
ASSERT_OK(split.SetInt32("key", 0));
Status s = CreateTable(
kTableName, kTableSchema, { split }, { { bound_lower, bound_upper } });
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(), "split matches lower or upper bound");
}
{ // Split equals upper bound
KuduPartialRow bound_lower(&kTableSchema);
KuduPartialRow bound_upper(&kTableSchema);
ASSERT_OK(bound_lower.SetInt32("key", 0));
ASSERT_OK(bound_upper.SetInt32("key", 10));
KuduPartialRow split(&kTableSchema);
ASSERT_OK(split.SetInt32("key", 10));
Status s = CreateTable(
kTableName, kTableSchema, { split }, { { bound_lower, bound_upper } });
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(), "split matches lower or upper bound");
}
}
TEST_F(MasterTest, TestCreateTableInvalidKeyType) {
const char *kTableName = "testtb";
const DataType types[] = { BOOL, FLOAT, DOUBLE };
for (DataType type : types) {
const Schema kTableSchema({ ColumnSchema("key", type) }, 1);
Status s = CreateTable(kTableName, kTableSchema, vector<KuduPartialRow>());
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(),
"key column may not have type of BOOL, FLOAT, or DOUBLE");
}
}
TEST_F(MasterTest, TestCreateTableOwnerNameTooLong) {
constexpr const char* const kTableName = "testb";
const string kOwnerName =
"abcdefghijklmnopqrstuvwxyz01234567899"
"abcdefghijklmnopqrstuvwxyz01234567899"
"abcdefghijklmnopqrstuvwxyz01234567899"
"abcdefghijklmnopqrstuvwxyz01234567899";
const Schema kTableSchema({ ColumnSchema("key", INT32), ColumnSchema("val", INT32) }, 1);
Status s = CreateTable(kTableName, kTableSchema, nullopt, kOwnerName);
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(), "invalid owner name");
}
TEST_F(MasterTest, TestCreateTableCommentTooLong) {
constexpr const char* const kTableName = "testb";
const string kComment = string(FLAGS_max_table_comment_length + 1, 'x');
const Schema kTableSchema({ ColumnSchema("key", INT32), ColumnSchema("val", INT32) }, 1);
Status s = CreateTable(kTableName, kTableSchema, nullopt, nullopt, kComment);
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(), "invalid table comment");
}
// Regression test for KUDU-253/KUDU-592: crash if the schema passed to CreateTable
// is invalid.
TEST_F(MasterTest, TestCreateTableInvalidSchema) {
CreateTableRequestPB req;
CreateTableResponsePB resp;
RpcController controller;
req.set_name("table");
for (int i = 0; i < 2; i++) {
ColumnSchemaPB* col = req.mutable_schema()->add_columns();
col->set_name("col");
col->set_type(INT32);
col->set_is_key(true);
}
ASSERT_OK(proxy_->CreateTable(req, &resp, &controller));
SCOPED_TRACE(SecureDebugString(resp));
ASSERT_TRUE(resp.has_error());
ASSERT_EQ("code: INVALID_ARGUMENT message: \"Duplicate column name: col\"",
SecureShortDebugString(resp.error().status()));
}
TEST_F(MasterTest, TestVirtualColumns) {
CreateTableRequestPB req;
CreateTableResponsePB resp;
RpcController controller;
req.set_name("table");
ColumnSchemaPB* col = req.mutable_schema()->add_columns();
col->set_name("foo");
col->set_type(INT8);
col->set_is_key(true);
col = req.mutable_schema()->add_columns();
col->set_name("bar");
col->set_type(IS_DELETED);
bool read_default = true;
col->set_read_default_value(&read_default, sizeof(read_default));
ASSERT_OK(proxy_->CreateTable(req, &resp, &controller));
SCOPED_TRACE(SecureDebugString(resp));
ASSERT_TRUE(resp.has_error());
ASSERT_EQ(Substitute(
"code: INVALID_ARGUMENT message: \"may not create virtual column of type "
"\\'$0\\' (column \\'bar\\')\"", GetTypeInfo(IS_DELETED)->name()),
SecureShortDebugString(resp.error().status()));
}
// Test that, if the client specifies mismatched read and write defaults,
// we return an error.
TEST_F(MasterTest, TestCreateTableMismatchedDefaults) {
CreateTableRequestPB req;
CreateTableResponsePB resp;
RpcController controller;
req.set_name("table");
ColumnSchemaPB* col = req.mutable_schema()->add_columns();
col->set_name("key");
col->set_type(INT32);
col->set_is_key(true);
col = req.mutable_schema()->add_columns();
col->set_name("col");
col->set_type(BINARY);
col->set_is_nullable(true);
req.mutable_schema()->mutable_columns(1)->set_read_default_value("hello");
req.mutable_schema()->mutable_columns(1)->set_write_default_value("bye");
ASSERT_OK(proxy_->CreateTable(req, &resp, &controller));
SCOPED_TRACE(SecureDebugString(resp));
ASSERT_TRUE(resp.has_error());
ASSERT_EQ("code: INVALID_ARGUMENT message: \"column \\'col\\' has "
"mismatched read/write defaults\"",
SecureShortDebugString(resp.error().status()));
}
// Non-PK columns cannot be used for per-range custom hash bucket schemas.
TEST_F(MasterTest, NonPrimaryKeyColumnsForPerRangeCustomHashSchema) {
constexpr const char* const kTableName = "nicetry";
const Schema kTableSchema(
{ ColumnSchema("key", INT32), ColumnSchema("int32_val", INT32) }, 1);
// For simplicity, a single tablet replica is enough.
FLAGS_default_num_replicas = 1;
KuduPartialRow lower(&kTableSchema);
KuduPartialRow upper(&kTableSchema);
ASSERT_OK(lower.SetInt32("key", 0));
ASSERT_OK(upper.SetInt32("key", 100));
const auto s = CreateTable(kTableName,
kTableSchema,
{},
{},
{{ lower, upper, {{{"int32_val"}, 2, 0}}}});
ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(),
"must specify only primary key columns for "
"hash bucket partition components");
}
// Regression test for KUDU-253/KUDU-592: crash if the GetTableLocations RPC call is
// invalid.
TEST_F(MasterTest, TestInvalidGetTableLocations) {
const string kTableName = "test";
Schema schema({ ColumnSchema("key", INT32) }, 1);
ASSERT_OK(CreateTable(kTableName, schema));
{
GetTableLocationsRequestPB req;
GetTableLocationsResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_name(kTableName);
// Set the "start" key greater than the "end" key.
req.set_partition_key_start("zzzz");
req.set_partition_key_end("aaaa");
ASSERT_OK(proxy_->GetTableLocations(req, &resp, &controller));
SCOPED_TRACE(SecureDebugString(resp));
ASSERT_TRUE(resp.has_error());
ASSERT_EQ("code: INVALID_ARGUMENT message: "
"\"start partition key is greater than the end partition key\"",
SecureShortDebugString(resp.error().status()));
}
}
#ifndef __APPLE__
// Test that, if the master's RPC service queue overflows, thread stack traces
// are dumped to the diagnostics log.
//
// This test is not relevant on OS X where stack trace dumping is not supported.
TEST_F(MasterTest, TestDumpStacksOnRpcQueueOverflow) {
mini_master_->mutable_options()->rpc_opts.num_service_threads = 1;
mini_master_->mutable_options()->rpc_opts.service_queue_length = 1;
// Disable periodic stack tracing, since we want to be asserting only for the
// overflow-triggered stack traces. If we don't disable it, it's possible that
// the overflow will happen during the middle of an unrelated scheduled trace,
// in which case it will be ignored.
ANNOTATE_BENIGN_RACE(&FLAGS_diagnostics_log_stack_traces_interval_ms,
"modified at runtime for test");
FLAGS_diagnostics_log_stack_traces_interval_ms = 0;
FLAGS_master_inject_latency_on_tablet_lookups_ms = 1000;
// Use a new log directory so that the tserver and master don't share the
// same one. This allows us to isolate the diagnostics log from the master.
FLAGS_log_dir = JoinPathSegments(GetTestDataDirectory(), "master-logs");
FLAGS_log_filename = "kudu-master";
Status s = env_->CreateDir(FLAGS_log_dir);
ASSERT_TRUE(s.ok() || s.IsAlreadyPresent()) << s.ToString();
mini_master_->Shutdown();
ASSERT_OK(mini_master_->Restart());
ASSERT_OK(mini_master_->master()->
WaitUntilCatalogManagerIsLeaderAndReadyForTests(MonoDelta::FromSeconds(5)));
// Send a bunch of RPCs which will cause the service queue to overflow. We can send a
// bogus request since the latency will be injected even if the table doesn't exist.
GetTableLocationsRequestPB req;
req.mutable_table()->set_table_name("abc");
const int kNumRpcs = 20;
GetTableLocationsResponsePB resps[kNumRpcs];
RpcController rpcs[kNumRpcs];
CountDownLatch latch(kNumRpcs);
for (int i = 0; i < kNumRpcs; i++) {
proxy_->GetTableLocationsAsync(req, &resps[i], &rpcs[i],
[&latch]() { latch.CountDown(); });
}
latch.Wait();
// Ensure that the metrics log contains a single trace dump for the overflowed service
// queue. Even though we may have overflowed the queue many times, we throttle the dumping
// so there should only be one.
vector<string> log_paths;
ASSERT_OK(env_->Glob(FLAGS_log_dir + "/*diagnostics*", &log_paths));
ASSERT_EQ(1, log_paths.size());
// The dump may not arrive immediately since symbolization may take a few seconds,
// especially in TSAN builds, etc.
ASSERT_EVENTUALLY([&]() {
faststring log_contents;
ASSERT_OK(ReadFileToString(env_, log_paths[0], &log_contents));
vector<string> lines = strings::Split(log_contents.ToString(), "\n");
int dump_count = std::count_if(lines.begin(), lines.end(), [](const string& line) {
return MatchPattern(line, "*service queue overflowed for kudu.master.MasterService*");
});
ASSERT_EQ(dump_count, 1) << log_contents.ToString();
});
}
#endif // #ifndef __APPLE__
// Tests that if the master is shutdown while a table visitor is active, the
// shutdown waits for the visitor to finish, avoiding racing and crashing.
TEST_F(MasterTest, TestShutdownDuringTableVisit) {
ASSERT_OK(master_->catalog_manager()->ElectedAsLeaderCb());
// Master will now shut down, potentially racing with
// CatalogManager::PrepareForLeadershipTask().
}
// Tests that the catalog manager handles spurious calls to ElectedAsLeaderCb()
// (i.e. those without a term change) correctly by ignoring them. If they
// aren't ignored, a concurrent GetTableLocations() call may trigger a
// use-after-free.
TEST_F(MasterTest, TestGetTableLocationsDuringRepeatedTableVisit) {
const char* kTableName = "test";
Schema schema({ ColumnSchema("key", INT32) }, 1);
ASSERT_OK(CreateTable(kTableName, schema));
AtomicBool done(false);
// Hammers the master with GetTableLocations() calls.
thread t([&]() {
GetTableLocationsRequestPB req;
GetTableLocationsResponsePB resp;
req.mutable_table()->set_table_name(kTableName);
while (!done.Load()) {
RpcController controller;
CHECK_OK(proxy_->GetTableLocations(req, &resp, &controller));
}
});
// Call ElectedAsLeaderCb() repeatedly. If these spurious calls aren't
// ignored, the concurrent GetTableLocations() calls may crash the master.
for (int i = 0; i < 100; i++) {
master_->catalog_manager()->ElectedAsLeaderCb();
}
done.Store(true);
t.join();
}
// The catalog manager had a bug wherein GetTableSchema() interleaved with
// CreateTable() could expose intermediate uncommitted state to clients. This
// test ensures that bug does not regress.
TEST_F(MasterTest, TestGetTableSchemaIsAtomicWithCreateTable) {
const char* kTableName = "testtb";
const Schema kTableSchema({ ColumnSchema("key", INT32),
ColumnSchema("v1", UINT64),
ColumnSchema("v2", STRING) },
1);
CountDownLatch started(1);
AtomicBool done(false);
// Kick off a thread that hammers the master with GetTableSchema() calls,
// checking that the results make sense.
thread t([&]() {
GetTableSchemaRequestPB req;
GetTableSchemaResponsePB resp;
req.mutable_table()->set_table_name(kTableName);
started.CountDown();
while (!done.Load()) {
RpcController controller;
CHECK_OK(proxy_->GetTableSchema(req, &resp, &controller));
SCOPED_TRACE(SecureDebugString(resp));
// There are two possible outcomes:
//
// 1. GetTableSchema() happened before CreateTable(): we expect to see a
// TABLE_NOT_FOUND error.
// 2. GetTableSchema() happened after CreateTable(): we expect to see the
// full table schema.
//
// Any other outcome is an error.
if (resp.has_error()) {
CHECK_EQ(MasterErrorPB::TABLE_NOT_FOUND, resp.error().code());
} else {
Schema receivedSchema;
CHECK_OK(SchemaFromPB(resp.schema(), &receivedSchema));
CHECK(kTableSchema == receivedSchema) <<
strings::Substitute("$0 not equal to $1",
kTableSchema.ToString(), receivedSchema.ToString());
CHECK_EQ(kTableName, resp.table_name());
}
}
});
// Only create the table after the thread has started.
started.Wait();
EXPECT_OK(CreateTable(kTableName, kTableSchema));
done.Store(true);
t.join();
}
class ConcurrentGetTableSchemaTest :
public MasterTest,
public ::testing::WithParamInterface<bool> {
protected:
ConcurrentGetTableSchemaTest()
: supports_authz_(GetParam()) {
}
void SetUp() override {
MasterTest::SetUp();
FLAGS_master_support_authz_tokens = supports_authz_;
}
const bool supports_authz_;
static const MonoDelta kRunInterval;
static const Schema kTableSchema;
static const string kTableNamePattern;
};
const MonoDelta ConcurrentGetTableSchemaTest::kRunInterval =
MonoDelta::FromSeconds(5);
const Schema ConcurrentGetTableSchemaTest::kTableSchema = {
{
ColumnSchema("key", INT32),
ColumnSchema("v1", UINT64),
ColumnSchema("v2", STRING)
}, 1 };
const string ConcurrentGetTableSchemaTest::kTableNamePattern = "test_table_$0"; // NOLINT
// Send multiple GetTableSchema() RPC requests for different tables.
TEST_P(ConcurrentGetTableSchemaTest, Rpc) {
SKIP_IF_SLOW_NOT_ALLOWED();
// kNumTables corresponds to the number of threads sending GetTableSchema
// RPCs. If setting a bit higher than the RPC queue size limit, there is
// a chance of overflowing the RPC queue.
const int kNumTables = FLAGS_rpc_service_queue_length;
for (auto idx = 0; idx < kNumTables; ++idx) {
EXPECT_OK(CreateTable(Substitute(kTableNamePattern, idx), kTableSchema));
}
AtomicBool done(false);
// Using multiple proxies to emulate multiple clients working concurrently,
// one proxy per a worker thread below. If using single proxy for all the
// threads instead, GetTableSchema() calls issued by the threads below
// would be serialized by that single proxy, not providing the required level
// of concurrency.
vector<unique_ptr<MasterServiceProxy>> proxies;
proxies.reserve(kNumTables);
for (auto i = 0; i < kNumTables; ++i) {
// No more than one reactor is needed since every worker thread below sends
// out a single GetTableSchema() request at a time; no other
// incoming/outgoing requests are handled by a worked thread.
MessengerBuilder bld("Client");
bld.set_num_reactors(1);
shared_ptr<Messenger> msg;
ASSERT_OK(bld.Build(&msg));
const auto& addr = mini_master_->bound_rpc_addr();
proxies.emplace_back(new MasterServiceProxy(std::move(msg), addr, addr.host()));
}
// Start many threads that hammer the master with GetTableSchema() calls
// for various tables.
vector<thread> caller_threads;
caller_threads.reserve(kNumTables);
vector<uint64_t> call_counters(kNumTables, 0);
vector<uint64_t> error_counters(kNumTables, 0);
for (auto idx = 0; idx < kNumTables; ++idx) {
caller_threads.emplace_back([&, idx]() {
auto table_name = Substitute(kTableNamePattern, idx);
GetTableSchemaRequestPB req;
req.mutable_table()->set_table_name(table_name);
GetTableSchemaResponsePB resp;
while (!done.Load()) {
RpcController controller;
resp.Clear();
CHECK_OK(proxies[idx]->GetTableSchema(req, &resp, &controller));
++call_counters[idx];
if (resp.has_error()) {
LOG(WARNING) << "GetTableSchema failed: " << SecureDebugString(resp);
++error_counters[idx];
break;
}
}
});
}
SCOPED_CLEANUP({
for (auto& t : caller_threads) {
t.join();
}
});
SleepFor(kRunInterval);
done.Store(true);
const auto errors = accumulate(error_counters.begin(), error_counters.end(), 0UL);
if (errors != 0) {
FAIL() << Substitute("detected $0 errors", errors);
}
const auto& ent = master_->metric_entity();
auto hist = METRIC_handler_latency_kudu_master_MasterService_GetTableSchema
.Instantiate(ent);
hist->histogram()->DumpHumanReadable(&LOG(INFO));
const double total = accumulate(call_counters.begin(), call_counters.end(), 0UL);
LOG(INFO) << Substitute(
"GetTableSchema RPC: $0 req/sec (authz $1)",
total / kRunInterval.ToSeconds(), supports_authz_ ? "enabled" : "disabled");
}
// Validate the hostname and the UUID of the server from the metrics webpage
TEST_F(MasterTest, ServerAttributes) {
EasyCurl c;
faststring buf;
ASSERT_OK(c.FetchURL(Substitute("http://$0/metrics?ids=kudu.master",
mini_master_->bound_http_addr().ToString()),
&buf));
string raw = buf.ToString();
string server_hostname;
ASSERT_STR_CONTAINS(raw, "\"uuid\": \"" + mini_master_->permanent_uuid() + "\"");
ASSERT_OK(GetFQDN(&server_hostname));
ASSERT_STR_CONTAINS(raw, "\"hostname\": \"" + server_hostname + "\"");
}
// Run multiple threads calling GetTableSchema() directly to system catalog.
TEST_P(ConcurrentGetTableSchemaTest, DirectMethodCall) {
SKIP_IF_SLOW_NOT_ALLOWED();
constexpr int kNumTables = 200;
static const string kUserName = "test-user";
for (auto idx = 0; idx < kNumTables; ++idx) {
EXPECT_OK(CreateTable(Substitute(kTableNamePattern, idx), kTableSchema));
}
AtomicBool done(false);
CatalogManager* cm = mini_master_->master()->catalog_manager();
const auto* token_signer = supports_authz_
? mini_master_->master()->token_signer() : nullptr;
optional<string> username;
if (supports_authz_) {
username = kUserName;
}
// Start many threads that hammer the master with GetTableSchema() calls
// for various tables.
vector<thread> caller_threads;
caller_threads.reserve(kNumTables);
vector<uint64_t> call_counters(kNumTables, 0);
vector<uint64_t> error_counters(kNumTables, 0);
for (auto idx = 0; idx < kNumTables; ++idx) {
caller_threads.emplace_back([&, idx]() {
GetTableSchemaRequestPB req;
req.mutable_table()->set_table_name(Substitute(kTableNamePattern, idx));
while (!done.Load()) {
RpcController controller;
GetTableSchemaResponsePB resp;
{
CatalogManager::ScopedLeaderSharedLock l(cm);
CHECK_OK(cm->GetTableSchema(&req, &resp, username, token_signer));
}
++call_counters[idx];
if (resp.has_error()) {
LOG(WARNING) << "GetTableSchema failed: " << SecureDebugString(resp);
++error_counters[idx];
break;
}
}
});
}
SleepFor(kRunInterval);
done.Store(true);
for (auto& t : caller_threads) {
t.join();
}
const auto errors = accumulate(error_counters.begin(), error_counters.end(), 0UL);
if (errors != 0) {
FAIL() << Substitute("detected $0 errors", errors);
}
const double total = accumulate(call_counters.begin(), call_counters.end(), 0UL);
LOG(INFO) << Substitute(
"GetTableSchema function: $0 req/sec (authz $1)",
total / kRunInterval.ToSeconds(), supports_authz_ ? "enabled" : "disabled");
}
INSTANTIATE_TEST_SUITE_P(SupportsAuthzTokens,
ConcurrentGetTableSchemaTest, ::testing::Bool());
// Verifies that on-disk master metadata is self-consistent and matches a set
// of expected contents.
//
// Sample usage:
//
// MasterMetadataVerifier v(live, dead);
// sys_catalog->VisitTables(&v);
// sys_catalog->VisitTablets(&v);
// ASSERT_OK(v.Verify());
//
class MasterMetadataVerifier : public TableVisitor,
public TabletVisitor {
public:
MasterMetadataVerifier(unordered_set<string> live_table_names,
multiset<string> dead_table_names)
: live_table_names_(std::move(live_table_names)),
dead_table_names_(std::move(dead_table_names)) {
}
Status VisitTable(const std::string& table_id,
const SysTablesEntryPB& metadata) override {
InsertOrDie(&visited_tables_by_id_, table_id,
{ table_id, metadata.name(), metadata.state() });
return Status::OK();
}
Status VisitTablet(const std::string& table_id,
const std::string& tablet_id,
const SysTabletsEntryPB& metadata) override {
InsertOrDie(&visited_tablets_by_id_, tablet_id,
{ tablet_id, table_id, metadata.state() });
return Status::OK();
}
Status Verify() {
RETURN_NOT_OK(VerifyTables());
RETURN_NOT_OK(VerifyTablets());
return Status::OK();
}
private:
Status VerifyTables() {
unordered_set<string> live_visited_table_names;
multiset<string> dead_visited_table_names;
for (const auto& entry : visited_tables_by_id_) {
const Table& table = entry.second;
switch (table.state) {
case SysTablesEntryPB::RUNNING:
case SysTablesEntryPB::ALTERING:
InsertOrDie(&live_visited_table_names, table.name);
break;
case SysTablesEntryPB::REMOVED:
// InsertOrDie() doesn't work on multisets, where the returned
// element is not an std::pair.
dead_visited_table_names.insert(table.name);
break;
default:
return Status::Corruption(
Substitute("Table $0 has unexpected state $1",
table.id,
SysTablesEntryPB::State_Name(table.state)));
}
}
if (live_visited_table_names != live_table_names_) {
return Status::Corruption("Live table name set mismatch");
}
if (dead_visited_table_names != dead_table_names_) {
return Status::Corruption("Dead table name set mismatch");
}
return Status::OK();
}
Status VerifyTablets() {
// Each table should be referenced by exactly this number of tablets.
const int kNumExpectedReferences = 3;
// Build table ID --> table map for use in verification below.
unordered_map<string, const Table*> tables_by_id;
for (const auto& entry : visited_tables_by_id_) {
InsertOrDie(&tables_by_id, entry.second.id, &entry.second);
}
map<string, int> referenced_tables;
for (const auto& entry : visited_tablets_by_id_) {
const Tablet& tablet = entry.second;
switch (tablet.state) {
case SysTabletsEntryPB::PREPARING:
case SysTabletsEntryPB::CREATING:
case SysTabletsEntryPB::DELETED:
{
const Table* table = FindPtrOrNull(tables_by_id, tablet.table_id);
if (!table) {
return Status::Corruption(Substitute(
"Tablet $0 belongs to non-existent table $1",
tablet.id, tablet.table_id));
}
string table_state_str = SysTablesEntryPB_State_Name(table->state);
string tablet_state_str = SysTabletsEntryPB_State_Name(tablet.state);
// PREPARING or CREATING tablets must be members of RUNNING or
// ALTERING tables.
//
// DELETED tablets must be members of REMOVED tables.
if (((tablet.state == SysTabletsEntryPB::PREPARING ||
tablet.state == SysTabletsEntryPB::CREATING) &&
(table->state != SysTablesEntryPB::RUNNING &&
table->state != SysTablesEntryPB::ALTERING)) ||
(tablet.state == SysTabletsEntryPB::DELETED &&
table->state != SysTablesEntryPB::REMOVED)) {
return Status::Corruption(
Substitute("Unexpected states: table $0=$1, tablet $2=$3",
table->id, table_state_str,
tablet.id, tablet_state_str));
}
referenced_tables[tablet.table_id]++;
break;
}
default:
return Status::Corruption(
Substitute("Tablet $0 has unexpected state $1",
tablet.id,
SysTabletsEntryPB::State_Name(tablet.state)));
}
}
for (const auto& entry : referenced_tables) {
if (entry.second != kNumExpectedReferences) {
return Status::Corruption(
Substitute("Table $0 has bad reference count ($1 instead of $2)",
entry.first, entry.second, kNumExpectedReferences));
}
}
return Status::OK();
}
// Names of tables that are thought to be created and never deleted.
const unordered_set<string> live_table_names_;
// Names of tables that are thought to be deleted. A table with a given name
// could be deleted more than once.
const multiset<string> dead_table_names_;
// Table ID to table map populated during VisitTables().
struct Table {
string id;
string name;
SysTablesEntryPB::State state;
};
unordered_map<string, Table> visited_tables_by_id_;
// Tablet ID to tablet map populated during VisitTablets().
struct Tablet {
string id;
string table_id;
SysTabletsEntryPB::State state;
};
unordered_map<string, Tablet> visited_tablets_by_id_;
};
TEST_F(MasterTest, TestMasterMetadataConsistentDespiteFailures) {
const Schema kTableSchema({ ColumnSchema("key", INT32),
ColumnSchema("v1", UINT64),
ColumnSchema("v2", STRING) },
1);
// When generating random table names, we use a uniform distribution so
// as to generate the occasional name collision; the test should cope.
const int kUniformBound = 25;
// Ensure some portion of the attempted operations fail.
FLAGS_sys_catalog_fail_during_write = 0.25;
int num_injected_failures = 0;
// Tracks all "live" tables (i.e. created and not yet deleted).
vector<string> table_names;
// Tracks all deleted tables. A given name may have been deleted more
// than once.
multiset<string> deleted_table_names;
Random r(SeedRandom());
// Spend some time hammering the master with create/alter/delete operations.
MonoDelta time_to_run = MonoDelta::FromSeconds(AllowSlowTests() ? 10 : 1);
MonoTime deadline = MonoTime::Now() + time_to_run;
while (MonoTime::Now() < deadline) {
int next_action = r.Uniform(3);
switch (next_action) {
case 0:
{
// Create a new table with a random name and three tablets.
//
// No name collision checking, so this table may already exist.
CreateTableRequestPB req;
CreateTableResponsePB resp;
RpcController controller;
req.set_name(Substitute("table-$0", r.Uniform(kUniformBound)));
ASSERT_OK(SchemaToPB(kTableSchema, req.mutable_schema()));
RowOperationsPBEncoder encoder(req.mutable_split_rows_range_bounds());
KuduPartialRow row(&kTableSchema);
ASSERT_OK(row.SetInt32("key", 10));
encoder.Add(RowOperationsPB::SPLIT_ROW, row);
ASSERT_OK(row.SetInt32("key", 20));
encoder.Add(RowOperationsPB::SPLIT_ROW, row);
ASSERT_OK(proxy_->CreateTable(req, &resp, &controller));
if (resp.has_error()) {
Status s = StatusFromPB(resp.error().status());
ASSERT_TRUE(s.IsAlreadyPresent() || s.IsRuntimeError()) << s.ToString();
if (s.IsRuntimeError()) {
ASSERT_STR_CONTAINS(s.ToString(),
SysCatalogTable::kInjectedFailureStatusMsg);
num_injected_failures++;
}
} else {
table_names.push_back(req.name());
}
break;
}
case 1:
{
// Rename a random table to some random name.
//
// No name collision checking, so the new table name may already exist.
int num_tables = table_names.size();
if (num_tables == 0) {
break;
}
int table_idx = r.Uniform(num_tables);
AlterTableRequestPB req;
AlterTableResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_name(table_names[table_idx]);
req.set_new_table_name(Substitute("table-$0", r.Uniform(kUniformBound)));
ASSERT_OK(proxy_->AlterTable(req, &resp, &controller));
if (resp.has_error()) {
Status s = StatusFromPB(resp.error().status());
ASSERT_TRUE(s.IsAlreadyPresent() || s.IsRuntimeError()) << s.ToString();
if (s.IsRuntimeError()) {
ASSERT_STR_CONTAINS(s.ToString(),
SysCatalogTable::kInjectedFailureStatusMsg);
num_injected_failures++;
}
} else {
table_names[table_idx] = req.new_table_name();
}
break;
}
case 2:
{
// Delete a random table.
int num_tables = table_names.size();
if (num_tables == 0) {
break;
}
int table_idx = r.Uniform(num_tables);
DeleteTableRequestPB req;
DeleteTableResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_name(table_names[table_idx]);
ASSERT_OK(proxy_->DeleteTable(req, &resp, &controller));
if (resp.has_error()) {
Status s = StatusFromPB(resp.error().status());
ASSERT_TRUE(s.IsRuntimeError()) << s.ToString();
ASSERT_STR_CONTAINS(s.ToString(),
SysCatalogTable::kInjectedFailureStatusMsg);
num_injected_failures++;
} else {
deleted_table_names.insert(table_names[table_idx]);
table_names[table_idx] = table_names.back();
table_names.pop_back();
}
break;
}
default:
LOG(FATAL) << "Cannot reach here!";
}
}
// Injected failures are random, but given the number of operations we did,
// we should expect to have seen at least one.
ASSERT_GE(num_injected_failures, 1);
// Restart the catalog manager to ensure that it can survive reloading the
// metadata we wrote to disk. Make sure failure injection is disabled as
// restarting may issue several catalog writes.
mini_master_->Shutdown();
FLAGS_sys_catalog_fail_during_write = 0.0;
ASSERT_OK(mini_master_->Restart());
// Reload the metadata again, this time verifying its consistency.
unordered_set<string> live_table_names(table_names.begin(),
table_names.end());
MasterMetadataVerifier verifier(live_table_names, deleted_table_names);
SysCatalogTable* sys_catalog =
mini_master_->master()->catalog_manager()->sys_catalog();
ASSERT_OK(sys_catalog->VisitTables(&verifier));
ASSERT_OK(sys_catalog->VisitTablets(&verifier));
ASSERT_OK(verifier.Verify());
}
TEST_F(MasterTest, TestConcurrentCreateOfSameTable) {
const char* kTableName = "testtb";
const Schema kTableSchema({ ColumnSchema("key", INT32),
ColumnSchema("v1", UINT64),
ColumnSchema("v2", STRING) },
1);
// Kick off a bunch of threads all trying to create the same table.
vector<thread> threads;
for (int i = 0; i < 10; i++) {
threads.emplace_back([&]() {
CreateTableRequestPB req;
CreateTableResponsePB resp;
RpcController controller;
req.set_name(kTableName);
CHECK_OK(SchemaToPB(kTableSchema, req.mutable_schema()));
CHECK_OK(proxy_->CreateTable(req, &resp, &controller));
SCOPED_TRACE(SecureDebugString(resp));
// There are three expected outcomes:
//
// 1. This thread won the CreateTable() race: no error.
// 2. This thread lost the CreateTable() race, but the table is still
// in the process of being created: TABLE_ALREADY_PRESENT error with
// ServiceUnavailable status.
// 3. This thread arrived after the CreateTable() race was already over:
// TABLE_ALREADY_PRESENT error with AlreadyPresent status.
if (resp.has_error()) {
Status s = StatusFromPB(resp.error().status());
string failure_msg = Substitute("Unexpected response: $0",
SecureDebugString(resp));
if (resp.error().code() == MasterErrorPB::TABLE_ALREADY_PRESENT) {
CHECK(s.IsServiceUnavailable() || s.IsAlreadyPresent()) << failure_msg;
} else {
FAIL() << failure_msg;
}
}
});
}
for (auto& t : threads) {
t.join();
}
}
TEST_F(MasterTest, TestConcurrentRenameOfSameTable) {
const char* kOldName = "testtb";
const char* kNewName = "testtb-new";
const Schema kTableSchema({ ColumnSchema("key", INT32),
ColumnSchema("v1", UINT64),
ColumnSchema("v2", STRING) },
1);
ASSERT_OK(CreateTable(kOldName, kTableSchema));
// Kick off a bunch of threads all trying to rename the same table.
vector<thread> threads;
for (int i = 0; i < 10; i++) {
threads.emplace_back([&]() {
AlterTableRequestPB req;
AlterTableResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_name(kOldName);
req.set_new_table_name(kNewName);
CHECK_OK(proxy_->AlterTable(req, &resp, &controller));
SCOPED_TRACE(SecureDebugString(resp));
// There are two expected outcomes:
//
// 1. This thread won the AlterTable() race: no error.
// 2. This thread lost the AlterTable() race: TABLE_NOT_FOUND error
// with NotFound status.
if (resp.has_error()) {
Status s = StatusFromPB(resp.error().status());
string failure_msg = Substitute("Unexpected response: $0",
SecureDebugString(resp));
CHECK_EQ(MasterErrorPB::TABLE_NOT_FOUND, resp.error().code()) << failure_msg;
CHECK(s.IsNotFound()) << failure_msg;
}
});
}
for (auto& t : threads) {
t.join();
}
}
TEST_F(MasterTest, TestConcurrentCreateAndRenameOfSameTable) {
const char* kOldName = "testtb";
const char* kNewName = "testtb-new";
const Schema kTableSchema({ ColumnSchema("key", INT32),
ColumnSchema("v1", UINT64),
ColumnSchema("v2", STRING) },
1);
ASSERT_OK(CreateTable(kOldName, kTableSchema));
AtomicBool create_success(false);
AtomicBool rename_success(false);
vector<thread> threads;
for (int i = 0; i < 10; i++) {
if (i % 2) {
threads.emplace_back([&]() {
CreateTableRequestPB req;
CreateTableResponsePB resp;
RpcController controller;
req.set_name(kNewName);
RowOperationsPBEncoder encoder(req.mutable_split_rows_range_bounds());
KuduPartialRow split1(&kTableSchema);
CHECK_OK(split1.SetInt32("key", 10));
encoder.Add(RowOperationsPB::SPLIT_ROW, split1);
KuduPartialRow split2(&kTableSchema);
CHECK_OK(split2.SetInt32("key", 20));
encoder.Add(RowOperationsPB::SPLIT_ROW, split2);
CHECK_OK(SchemaToPB(kTableSchema, req.mutable_schema()));
CHECK_OK(proxy_->CreateTable(req, &resp, &controller));
SCOPED_TRACE(SecureDebugString(resp));
// There are three expected outcomes:
//
// 1. This thread finished well before the others: no error.
// 2. This thread raced with CreateTable() or AlterTable():
// TABLE_ALREADY_PRESENT error with ServiceUnavailable status.
// 3. This thread finished well after the others:
// TABLE_ALREADY_PRESENT error with AlreadyPresent status.
if (resp.has_error()) {
Status s = StatusFromPB(resp.error().status());
string failure_msg = Substitute("Unexpected response: $0", SecureDebugString(resp));
if (resp.error().code() == MasterErrorPB::TABLE_ALREADY_PRESENT) {
CHECK(s.IsServiceUnavailable() || s.IsAlreadyPresent()) << failure_msg;
} else {
FAIL() << failure_msg;
}
} else {
// Creating the table should only succeed once.
CHECK(!create_success.Exchange(true));
}
});
} else {
threads.emplace_back([&]() {
AlterTableRequestPB req;
AlterTableResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_name(kOldName);
req.set_new_table_name(kNewName);
CHECK_OK(proxy_->AlterTable(req, &resp, &controller));
SCOPED_TRACE(SecureDebugString(resp));
// There are four expected outcomes:
//
// 1. This thread finished well before the others: no error.
// 2. This thread raced with CreateTable() or AlterTable():
// TABLE_ALREADY_PRESENT error with ServiceUnavailable status.
// 3. This thread completed well after a CreateTable():
// TABLE_ALREADY_PRESENT error with AlreadyPresent status.
// 4. This thread completed well after an AlterTable():
// TABLE_NOT_FOUND error with NotFound status.
if (resp.has_error()) {
Status s = StatusFromPB(resp.error().status());
string failure_msg = Substitute("Unexpected response: $0",
SecureDebugString(resp));
switch (resp.error().code()) {
case MasterErrorPB::TABLE_ALREADY_PRESENT:
CHECK(s.IsServiceUnavailable() || s.IsAlreadyPresent()) << failure_msg;
break;
case MasterErrorPB::TABLE_NOT_FOUND:
CHECK(s.IsNotFound()) << failure_msg;
break;
default:
FAIL() << failure_msg;
}
} else {
// Renaming the table should only succeed once.
CHECK(!rename_success.Exchange(true));
}
});
}
}
for (auto& t : threads) {
t.join();
}
// At least one of rename or create should have failed; if both succeeded
// there must be some sort of race.
CHECK(!rename_success.Load() || !create_success.Load());
unordered_set<string> live_tables;
live_tables.insert(kNewName);
if (create_success.Load()) {
live_tables.insert(kOldName);
}
MasterMetadataVerifier verifier(live_tables, {});
SysCatalogTable* sys_catalog =
mini_master_->master()->catalog_manager()->sys_catalog();
ASSERT_OK(sys_catalog->VisitTables(&verifier));
ASSERT_OK(sys_catalog->VisitTablets(&verifier));
ASSERT_OK(verifier.Verify());
}
TEST_F(MasterTest, TestConcurrentRenameAndDeleteOfSameTable) {
const char* kTableName = "testtb";
const Schema kTableSchema({ ColumnSchema("key", INT32) }, 1);
ASSERT_OK(CreateTable(kTableName, kTableSchema));
bool renamed = false;
bool deleted = false;
thread renamer([&] {
AlterTableRequestPB req;
AlterTableResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_name(kTableName);
req.set_new_table_name("testtb-renamed");
CHECK_OK(proxy_->AlterTable(req, &resp, &controller));
// There are two expected outcomes:
//
// 1. This thread won the race: no error.
// 2. This thread lost the race: TABLE_NOT_FOUND error with NotFound status.
if (resp.has_error()) {
Status s = StatusFromPB(resp.error().status());
string failure_msg = Substitute("Unexpected response: $0",
SecureDebugString(resp));
CHECK_EQ(MasterErrorPB::TABLE_NOT_FOUND, resp.error().code()) << failure_msg;
CHECK(s.IsNotFound()) << failure_msg;
} else {
renamed = true;
}
});
thread dropper([&] {
DeleteTableRequestPB req;
DeleteTableResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_name(kTableName);
CHECK_OK(proxy_->DeleteTable(req, &resp, &controller));
// There are two expected outcomes:
//
// 1. This thread won the race: no error.
// 2. This thread lost the race: TABLE_NOT_FOUND error with NotFound status.
if (resp.has_error()) {
Status s = StatusFromPB(resp.error().status());
string failure_msg = Substitute("Unexpected response: $0",
SecureDebugString(resp));
CHECK_EQ(MasterErrorPB::TABLE_NOT_FOUND, resp.error().code()) << failure_msg;
CHECK(s.IsNotFound()) << failure_msg;
} else {
deleted = true;
}
});
renamer.join();
dropper.join();
ASSERT_TRUE(renamed ^ deleted);
}
class MasterWithEncryptedKeysTest : public MasterTest,
public ::testing::WithParamInterface<bool> {
public:
void SetUp() override {
if (GetParam()) {
FLAGS_ipki_private_key_password_cmd = "echo test";
FLAGS_tsk_private_key_password_cmd = "echo foo";
}
MasterTest::SetUp();
}
};
// Unit tests for the ConnectToMaster() RPC:
// should issue authentication tokens and the master CA cert.
TEST_P(MasterWithEncryptedKeysTest, TestConnectToMaster) {
ConnectToMasterRequestPB req;
ConnectToMasterResponsePB resp;
RpcController rpc;
ASSERT_OK(proxy_->ConnectToMaster(req, &resp, &rpc));
SCOPED_TRACE(resp.DebugString());
EXPECT_EQ(consensus::LEADER, resp.role()) << "should be leader";
ASSERT_EQ(1, resp.ca_cert_der_size()) << "should have one cert";
EXPECT_GT(resp.ca_cert_der(0).size(), 100) << "CA cert should be at least 100 bytes";
ASSERT_TRUE(resp.has_authn_token()) << "should return an authn token";
// Using 512 bit RSA key and SHA256 digest results in 64 byte signature. If
// large keys are used, we use 2048 bit RSA keys so the signature is 256
// bytes.
int signature_size = UseLargeKeys() ? 256 : 64;
EXPECT_EQ(signature_size, resp.authn_token().signature().size());
ASSERT_TRUE(resp.authn_token().has_signing_key_seq_num());
EXPECT_GT(resp.authn_token().signing_key_seq_num(), -1);
security::TokenPB token;
ASSERT_TRUE(token.ParseFromString(resp.authn_token().token_data()));
ASSERT_TRUE(token.authn().has_username());
ASSERT_EQ(1, resp.master_addrs_size());
ASSERT_EQ("127.0.0.1", resp.master_addrs(0).host());
ASSERT_NE(0, resp.master_addrs(0).port());
// The returned location should be empty because no location mapping command
// is defined.
ASSERT_TRUE(resp.client_location().empty());
// The cluster ID should match the masters cluster ID.
string cluster_id;
const std::shared_ptr<MasterServiceProxy> master_proxy = std::move(proxy_);
ASSERT_OK(GetClusterId(master_proxy, MonoDelta::FromSeconds(30), &cluster_id));
ASSERT_TRUE(!cluster_id.empty());
ASSERT_EQ(cluster_id, resp.cluster_id());
}
INSTANTIATE_TEST_SUITE_P(SupportsEncryptedKeys, MasterWithEncryptedKeysTest, ::testing::Bool());
TEST_F(MasterTest, TestConnectToMasterAndAssignLocation) {
// Test first with a valid location mapping command.
const string kLocationCmdPath = JoinPathSegments(GetTestExecutableDirectory(),
"testdata/first_argument.sh");
const string location = "/foo";
FLAGS_location_mapping_cmd = Substitute("$0 $1", kLocationCmdPath, location);
FLAGS_master_client_location_assignment_enabled = true;
{
// Restarting the master to take into account the new setting for the
// --location_mapping_cmd flag.
mini_master_->Shutdown();
ASSERT_OK(mini_master_->Restart());
ConnectToMasterRequestPB req;
ConnectToMasterResponsePB resp;
RpcController rpc;
ASSERT_OK(proxy_->ConnectToMaster(req, &resp, &rpc));
ASSERT_FALSE(resp.has_error());
ASSERT_EQ(location, resp.client_location());
}
// Now try again with an invalid command. The RPC should succeed but no
// location should be assigned.
FLAGS_location_mapping_cmd = "false";
{
// Restarting the master to take into account the new setting for the
// --location_mapping_cmd flag.
mini_master_->Shutdown();
ASSERT_OK(mini_master_->Restart());
ConnectToMasterRequestPB req;
ConnectToMasterResponsePB resp;
RpcController rpc;
ASSERT_OK(proxy_->ConnectToMaster(req, &resp, &rpc));
ASSERT_FALSE(resp.has_error());
ASSERT_TRUE(resp.client_location().empty());
}
// Finally, use a command returning a different location.
const string new_location = "/bar";
FLAGS_location_mapping_cmd = Substitute("$0 $1", kLocationCmdPath, new_location);
{
// Restarting the master to take into account the new setting for the
// --location_mapping_cmd flag.
mini_master_->Shutdown();
ASSERT_OK(mini_master_->Restart());
ConnectToMasterRequestPB req;
ConnectToMasterResponsePB resp;
RpcController rpc;
ASSERT_OK(proxy_->ConnectToMaster(req, &resp, &rpc));
ASSERT_FALSE(resp.has_error());
ASSERT_EQ(new_location, resp.client_location());
}
}
// Test that the master signs its own server certificate when it becomes the leader,
// and also that it loads TSKs into the messenger's verifier.
TEST_P(MasterWithEncryptedKeysTest, TestSignOwnCertAndLoadTSKs) {
ASSERT_EVENTUALLY([&]() {
ASSERT_TRUE(master_->tls_context().has_signed_cert());
ASSERT_GT(master_->messenger()->token_verifier().GetMaxKnownKeySequenceNumber(), -1);
});
}
TEST_F(MasterTest, TestTableIdentifierWithIdAndName) {
const char *kTableName = "testtb";
const Schema kTableSchema({ ColumnSchema("key", INT32) }, 1);
ASSERT_OK(CreateTable(kTableName, kTableSchema));
ListTablesResponsePB tables;
NO_FATALS(DoListAllTables(&tables));
ASSERT_EQ(1, tables.tables_size());
ASSERT_EQ(kTableName, tables.tables(0).name());
string table_id = tables.tables(0).id();
ASSERT_FALSE(table_id.empty());
// Delete the table with an invalid ID.
{
DeleteTableRequestPB req;
DeleteTableResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_name(kTableName);
req.mutable_table()->set_table_id("abc123");
ASSERT_OK(proxy_->DeleteTable(req, &resp, &controller));
ASSERT_TRUE(resp.has_error());
ASSERT_EQ(MasterErrorPB::TABLE_NOT_FOUND, resp.error().code());
}
// Delete the table with an invalid name.
{
DeleteTableRequestPB req;
DeleteTableResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_name("abc123");
req.mutable_table()->set_table_id(table_id);
ASSERT_OK(proxy_->DeleteTable(req, &resp, &controller));
ASSERT_TRUE(resp.has_error());
ASSERT_EQ(MasterErrorPB::TABLE_NOT_FOUND, resp.error().code());
}
// Delete the table with an invalid ID and name.
{
DeleteTableRequestPB req;
DeleteTableResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_name("abc123");
req.mutable_table()->set_table_id("abc123");
ASSERT_OK(proxy_->DeleteTable(req, &resp, &controller));
ASSERT_TRUE(resp.has_error());
ASSERT_EQ(MasterErrorPB::TABLE_NOT_FOUND, resp.error().code());
}
{
DeleteTableRequestPB req;
DeleteTableResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_name(kTableName);
req.mutable_table()->set_table_id(table_id);
ASSERT_OK(proxy_->DeleteTable(req, &resp, &controller));
ASSERT_FALSE(resp.has_error()) << resp.error().DebugString();
}
}
TEST_F(MasterTest, TestDuplicateRequest) {
const char* const kTsUUID = "my-ts-uuid";
TSToMasterCommonPB common;
common.mutable_ts_instance()->set_permanent_uuid(kTsUUID);
common.mutable_ts_instance()->set_instance_seqno(1);
// Register the fake TS, without sending any tablet report.
ServerRegistrationPB fake_reg;
MakeHostPortPB("localhost", 1000, fake_reg.add_rpc_addresses());
MakeHostPortPB("localhost", 2000, fake_reg.add_http_addresses());
fake_reg.set_software_version(VersionInfo::GetVersionInfo());
fake_reg.set_start_time(10000);
// Information on replica management scheme.
ReplicaManagementInfoPB rmi;
rmi.set_replacement_scheme(ReplicaManagementInfoPB::PREPARE_REPLACEMENT_BEFORE_EVICTION);
{
TSHeartbeatRequestPB req;
TSHeartbeatResponsePB resp;
RpcController rpc;
req.mutable_common()->CopyFrom(common);
req.mutable_registration()->CopyFrom(fake_reg);
req.mutable_replica_management_info()->CopyFrom(rmi);
ASSERT_OK(proxy_->TSHeartbeat(req, &resp, &rpc));
ASSERT_FALSE(resp.has_error());
ASSERT_TRUE(resp.leader_master());
ASSERT_FALSE(resp.needs_reregister());
ASSERT_FALSE(resp.needs_full_tablet_report());
ASSERT_FALSE(resp.has_tablet_report());
}
vector<shared_ptr<TSDescriptor> > descs;
master_->ts_manager()->GetAllDescriptors(&descs);
ASSERT_EQ(1, descs.size()) << "Should have registered the TS";
ServerRegistrationPB reg;
ASSERT_OK(descs[0]->GetRegistration(&reg));
ASSERT_EQ(SecureDebugString(fake_reg), SecureDebugString(reg))
<< "Master got different registration";
shared_ptr<TSDescriptor> ts_desc;
ASSERT_TRUE(master_->ts_manager()->LookupTSByUUID(kTsUUID, &ts_desc));
ASSERT_EQ(ts_desc, descs[0]);
// Create a table with three tablets.
const char *kTableName = "test_table";
const Schema kTableSchema({ ColumnSchema("key", INT32) }, 1);
ASSERT_OK(CreateTable(kTableName, kTableSchema));
vector<scoped_refptr<TableInfo>> tables;
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
master_->catalog_manager()->GetAllTables(&tables);
ASSERT_EQ(1, tables.size());
}
scoped_refptr<TableInfo> table = tables[0];
vector<scoped_refptr<TabletInfo>> tablets;
table->GetAllTablets(&tablets);
ASSERT_EQ(tablets.size(), 3);
// Delete the table.
{
DeleteTableRequestPB req;
DeleteTableResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_name(kTableName);
ASSERT_OK(proxy_->DeleteTable(req, &resp, &controller));
SCOPED_TRACE(SecureDebugString(resp));
ASSERT_FALSE(resp.has_error());
}
// The table has no pending task.
// The master would not send DeleteTablet requests for no consensus state for tablets.
vector<scoped_refptr<MonitoredTask>> task_list;
tables[0]->GetTaskList(&task_list);
ASSERT_EQ(task_list.size(), 0);
// Now the tserver send a full report with a deleted tablet.
// The master will process it and send 'DeleteTablet' request to the tserver.
{
TSHeartbeatRequestPB req;
TSHeartbeatResponsePB resp;
RpcController rpc;
req.mutable_common()->CopyFrom(common);
TabletReportPB* tr = req.mutable_tablet_report();
tr->set_is_incremental(false);
tr->set_sequence_number(0);
tr->add_updated_tablets()->set_tablet_id(tablets[0]->id());
ASSERT_OK(proxy_->TSHeartbeat(req, &resp, &rpc));
ASSERT_TRUE(resp.has_tablet_report());
}
// The 'DeleteTablet' task is running for the master will continue
// retrying to connect to the fake TS.
tables[0]->GetTaskList(&task_list);
ASSERT_EQ(task_list.size(), 1);
ASSERT_EQ(task_list[0]->state(), MonitoredTask::kStateRunning);
// Now the tserver send a full report with two deleted tablets.
// The master will not send duplicate DeleteTablet request to the tserver.
{
TSHeartbeatRequestPB req;
TSHeartbeatResponsePB resp;
RpcController rpc;
req.mutable_common()->CopyFrom(common);
TabletReportPB* tr = req.mutable_tablet_report();
tr->set_is_incremental(true);
tr->set_sequence_number(0);
tr->add_updated_tablets()->set_tablet_id(tablets[0]->id());
tr->add_updated_tablets()->set_tablet_id(tablets[1]->id());
ASSERT_OK(proxy_->TSHeartbeat(req, &resp, &rpc));
ASSERT_TRUE(resp.has_tablet_report());
}
tables[0]->GetTaskList(&task_list);
ASSERT_EQ(task_list.size(), 2);
}
TEST_F(MasterTest, TestHideLiveRowCountInTableMetrics) {
const char* kTableName = "testtable";
const Schema kTableSchema({ ColumnSchema("key", INT32) }, 1);
ASSERT_OK(CreateTable(kTableName, kTableSchema));
vector<scoped_refptr<TableInfo>> tables;
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
master_->catalog_manager()->GetAllTables(&tables);
ASSERT_EQ(1, tables.size());
}
vector<scoped_refptr<TabletInfo>> tablets;
tables[0]->GetAllTablets(&tablets);
const auto call_update_metrics = [&] (
scoped_refptr<TabletInfo>& tablet,
bool support_live_row_count) {
tablet::ReportedTabletStatsPB old_stats;
tablet::ReportedTabletStatsPB new_stats;
new_stats.set_on_disk_size(1);
if (support_live_row_count) {
old_stats.set_live_row_count(1);
new_stats.set_live_row_count(1);
}
tables[0]->UpdateStatsMetrics(tablet->id(), old_stats, new_stats);
};
// Trigger to cause 'live_row_count' invisible.
{
for (int i = 0; i < 100; ++i) {
for (int j = 0; j < tablets.size(); ++j) {
NO_FATALS(call_update_metrics(tablets[j], (tablets.size() - 1 != j)));
}
}
EasyCurl c;
faststring buf;
ASSERT_OK(c.FetchURL(Substitute("http://$0/metrics?ids=$1",
mini_master_->bound_http_addr().ToString(),
tables[0]->id()),
&buf));
string raw = buf.ToString();
ASSERT_STR_CONTAINS(raw, kTableName);
ASSERT_STR_CONTAINS(raw, "on_disk_size");
ASSERT_STR_NOT_CONTAINS(raw, "live_row_count");
}
// Trigger to cause 'live_row_count' visible.
{
for (int i = 0; i < 100; ++i) {
for (int j = 0; j < tablets.size(); ++j) {
NO_FATALS(call_update_metrics(tablets[j], true));
}
}
EasyCurl c;
faststring buf;
ASSERT_OK(c.FetchURL(Substitute("http://$0/metrics?ids=$1",
mini_master_->bound_http_addr().ToString(),
tables[0]->id()),
&buf));
string raw = buf.ToString();
ASSERT_STR_CONTAINS(raw, kTableName);
ASSERT_STR_CONTAINS(raw, "on_disk_size");
ASSERT_STR_CONTAINS(raw, "live_row_count");
}
}
TEST_F(MasterTest, TestTableStatisticsWithOldVersion) {
const char* kTableName = "testtable";
const Schema kTableSchema({ ColumnSchema("key", INT32) }, 1);
ASSERT_OK(CreateTable(kTableName, kTableSchema));
vector<scoped_refptr<TableInfo>> tables;
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
master_->catalog_manager()->GetAllTables(&tables);
ASSERT_EQ(1, tables.size());
}
const auto& table = tables[0];
vector<scoped_refptr<TabletInfo>> tablets;
table->GetAllTablets(&tablets);
ASSERT_FALSE(tablets.empty());
{
table->InvalidateMetrics(tablets.back()->id());
ASSERT_FALSE(table->GetMetrics()->TableSupportsOnDiskSize());
ASSERT_FALSE(table->GetMetrics()->TableSupportsLiveRowCount());
}
{
tablet::ReportedTabletStatsPB old_stats;
tablet::ReportedTabletStatsPB new_stats;
new_stats.set_on_disk_size(1024);
new_stats.set_live_row_count(1000);
table->UpdateStatsMetrics(tablets.back()->id(), old_stats, new_stats);
ASSERT_TRUE(table->GetMetrics()->TableSupportsOnDiskSize());
ASSERT_TRUE(table->GetMetrics()->TableSupportsLiveRowCount());
ASSERT_EQ(1024, table->GetMetrics()->on_disk_size->value());
ASSERT_EQ(1000, table->GetMetrics()->live_row_count->value());
}
}
TEST_F(MasterTest, TestDeletedTablesAndTabletsCleanup) {
FLAGS_enable_metadata_cleanup_for_deleted_tables_and_tablets = true;
FLAGS_metadata_for_deleted_table_and_tablet_reserved_secs = 1;
FLAGS_catalog_manager_bg_task_wait_ms = 10;
constexpr const char* const kTableName = "testtable";
const Schema kTableSchema({ColumnSchema("key", INT32)}, 1);
ASSERT_OK(CreateTable(kTableName, kTableSchema));
vector<scoped_refptr<TableInfo>> tables;
vector<scoped_refptr<TabletInfo>> tablets;
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
master_->catalog_manager()->GetAllTables(&tables);
ASSERT_EQ(1, tables.size());
master_->catalog_manager()->GetAllTabletsForTests(&tablets);
ASSERT_EQ(3, tablets.size());
}
// Replace a tablet.
{
const string& tablet_id = tablets[0]->id();
ReplaceTabletRequestPB req;
ReplaceTabletResponsePB resp;
req.set_tablet_id(tablet_id);
RpcController controller;
ASSERT_OK(proxy_->ReplaceTablet(req, &resp, &controller));
SCOPED_TRACE(SecureDebugString(resp));
ASSERT_FALSE(resp.has_error());
}
// The replaced tablet should be cleaned up.
ASSERT_EVENTUALLY([&] {
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
master_->catalog_manager()->GetAllTabletsForTests(&tablets);
ASSERT_EQ(3, tablets.size());
});
// Delete the table.
{
DeleteTableRequestPB req;
DeleteTableResponsePB resp;
RpcController controller;
req.mutable_table()->set_table_name(kTableName);
ASSERT_OK(proxy_->DeleteTable(req, &resp, &controller));
SCOPED_TRACE(SecureDebugString(resp));
ASSERT_FALSE(resp.has_error());
}
// The deleted table and tablets should be cleaned up.
ASSERT_EVENTUALLY([&] {
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
master_->catalog_manager()->GetAllTables(&tables);
ASSERT_EQ(0, tables.size());
master_->catalog_manager()->GetAllTabletsForTests(&tablets);
ASSERT_EQ(0, tablets.size());
});
}
TEST_F(MasterTest, TestTableSchemaMetrics) {
const char* kTableName = "testtable";
const Schema kTableSchema({ ColumnSchema("key", INT32) }, 1);
ASSERT_OK(CreateTable(kTableName, kTableSchema));
vector<scoped_refptr<TableInfo>> tables;
{
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
master_->catalog_manager()->GetAllTables(&tables);
ASSERT_EQ(1, tables.size());
}
const auto& table = tables[0];
ASSERT_EQ(1, table->GetMetrics()->column_count->value());
ASSERT_EQ(0, table->GetMetrics()->schema_version->value());
{
AlterTableRequestPB req;
req.mutable_table()->set_table_name(kTableName);
AlterTableRequestPB::Step* step = req.add_alter_schema_steps();
step->set_type(AlterTableRequestPB::ADD_COLUMN);
ColumnSchemaToPB(ColumnSchema("c1", INT32, true),
step->mutable_add_column()->mutable_schema());
AlterTableResponsePB resp;
RpcController controller;
ASSERT_OK(proxy_->AlterTable(req, &resp, &controller));
ASSERT_FALSE(resp.has_error());
ASSERT_EQ(2, table->GetMetrics()->column_count->value());
ASSERT_EQ(1, table->GetMetrics()->schema_version->value());
}
{
AlterTableRequestPB req;
req.mutable_table()->set_table_name(kTableName);
AlterTableRequestPB::Step* step = req.add_alter_schema_steps();
step->set_type(AlterTableRequestPB::DROP_COLUMN);
step->mutable_drop_column()->set_name("c1");
AlterTableResponsePB resp;
RpcController controller;
ASSERT_OK(proxy_->AlterTable(req, &resp, &controller));
ASSERT_FALSE(resp.has_error());
ASSERT_EQ(1, table->GetMetrics()->column_count->value());
ASSERT_EQ(2, table->GetMetrics()->schema_version->value());
}
}
class AuthzTokenMasterTest : public MasterTest,
public ::testing::WithParamInterface<bool> {};
// Some basic verifications that we get authz tokens when we expect.
TEST_P(AuthzTokenMasterTest, TestGenerateAuthzTokens) {
bool supports_authz = GetParam();
FLAGS_master_support_authz_tokens = supports_authz;
const char* kTableName = "testtb";
const Schema kTableSchema({ ColumnSchema("key", INT32) }, 1);
const auto send_req = [&] (GetTableSchemaResponsePB* resp) {
RpcController rpc;
GetTableSchemaRequestPB req;
req.mutable_table()->set_table_name(kTableName);
return proxy_->GetTableSchema(req, resp, &rpc);
};
// Send a request for which there is no table. Whether or not authz tokens are
// supported, the response should have an error.
{
GetTableSchemaResponsePB resp;
ASSERT_OK(send_req(&resp));
ASSERT_TRUE(resp.has_error());
const Status s = StatusFromPB(resp.error().status());
ASSERT_TRUE(s.IsNotFound()) << s.ToString();
}
// Now create the table and check that we only get tokens when we expect.
ASSERT_OK(CreateTable(kTableName, kTableSchema));
{
GetTableSchemaResponsePB resp;
ASSERT_OK(send_req(&resp));
ASSERT_EQ(supports_authz, resp.has_authz_token());
}
}
INSTANTIATE_TEST_SUITE_P(SupportsAuthzTokens, AuthzTokenMasterTest, ::testing::Bool());
class MasterStartupTest : public KuduTest {
protected:
void SetUp() override {
KuduTest::SetUp();
// The embedded webserver renders the contents of the generated pages
// according to mustache's mappings found under the directory pointed to by
// the --webserver_doc_root flag, which is set to $KUDU_HOME/www by default.
// Since this test assumes to fetch the pre-rendered output for the startup
// page, it would fail if the KUDU_HOME environment variable were set and
// pointed to the location where 'www' subdirectory contained the required
// mustache mappings. Let's explicitly point the document root to nowhere,
// so no mustache-based rendering is done.
FLAGS_webserver_doc_root = "";
mini_master_.reset(new MiniMaster(GetTestPath("Master"), HostPort("127.0.0.1", 0)));
ASSERT_OK(mini_master_->Start());
}
void TearDown() override {
mini_master_->Shutdown();
KuduTest::TearDown();
}
unique_ptr<MiniMaster> mini_master_;
};
TEST_F(MasterStartupTest, StartupWebPage) {
const string addr = mini_master_->bound_http_addr().ToString();
mini_master_->Shutdown();
std::atomic<bool> run_status_reader = true;
thread status_reader([&] {
EasyCurl c;
faststring buf;
while (run_status_reader) {
SleepFor(MonoDelta::FromMilliseconds(10));
if (!c.FetchURL(strings::Substitute("http://$0/startup", addr), &buf).ok()) {
continue;
}
ASSERT_STR_MATCHES(buf.ToString(), "\"init_status\":(100|0)( |,)");
ASSERT_STR_MATCHES(buf.ToString(), "\"read_filesystem_status\":(100|0)( |,)");
ASSERT_STR_MATCHES(buf.ToString(), "\"read_instance_metadatafiles_status\""
":(100|0)( |,)");
ASSERT_STR_MATCHES(buf.ToString(), "\"read_data_directories_status\":"
"([0-9]|[1-9][0-9]|100)( |,)");
ASSERT_STR_MATCHES(buf.ToString(), "\"initialize_master_catalog_status\":"
"([0-9]|[1-9][0-9]|100)( |,)");
ASSERT_STR_MATCHES(buf.ToString(), "\"start_rpc_server_status\":(100|0)( |,)");
}
});
SCOPED_CLEANUP({
run_status_reader = false;
status_reader.join();
});
ASSERT_OK(mini_master_->Restart());
ASSERT_OK(mini_master_->WaitForCatalogManagerInit());
run_status_reader = false;
// After all the steps have been completed, ensure every startup step has 100 percent status
EasyCurl c;
faststring buf;
ASSERT_OK(c.FetchURL(strings::Substitute("http://$0/startup", addr), &buf));
ASSERT_STR_CONTAINS(buf.ToString(), "\"init_status\":100");
ASSERT_STR_CONTAINS(buf.ToString(), "\"read_filesystem_status\":100");
ASSERT_STR_CONTAINS(buf.ToString(), "\"read_instance_metadatafiles_status\":100");
ASSERT_STR_CONTAINS(buf.ToString(), "\"read_data_directories_status\":100");
ASSERT_STR_CONTAINS(buf.ToString(), "\"initialize_master_catalog_status\":100");
ASSERT_STR_CONTAINS(buf.ToString(), "\"start_rpc_server_status\":100");
}
TEST_F(MasterTest, GetTableStatesWithName) {
const char* kTableName = "testtable";
const Schema kTableSchema({ ColumnSchema("key", INT32) }, 1);
bool is_soft_deleted_table = false;
bool is_expired_table = false;
TableIdentifierPB table_identifier;
table_identifier.set_table_name(kTableName);
// Create a new table.
ASSERT_OK(CreateTable(kTableName, kTableSchema));
ListTablesResponsePB tables;
NO_FATALS(DoListAllTables(&tables));
ASSERT_EQ(1, tables.tables_size());
ASSERT_EQ(kTableName, tables.tables(0).name());
string table_id = tables.tables(0).id();
ASSERT_FALSE(table_id.empty());
{
// Default table is not expired.
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
ASSERT_OK(master_->catalog_manager()->GetTableStates(
table_identifier, CatalogManager::TableInfoMapType::kAllTableType,
&is_soft_deleted_table, &is_expired_table));
ASSERT_FALSE(is_soft_deleted_table);
ASSERT_FALSE(is_expired_table);
}
{
// In reserve time, table is not expired.
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
ASSERT_OK(SoftDelete(kTableName, 100));
ASSERT_OK(master_->catalog_manager()->GetTableStates(
table_identifier, CatalogManager::TableInfoMapType::kAllTableType,
&is_soft_deleted_table, &is_expired_table));
ASSERT_TRUE(is_soft_deleted_table);
ASSERT_FALSE(is_expired_table);
ASSERT_OK(RecallTable(table_id));
}
{
// After reserve time, table is expired.
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
ASSERT_OK(SoftDelete(kTableName, 1));
SleepFor(MonoDelta::FromSeconds(1));
ASSERT_OK(master_->catalog_manager()->GetTableStates(
table_identifier, CatalogManager::TableInfoMapType::kAllTableType,
&is_soft_deleted_table, &is_expired_table));
ASSERT_TRUE(is_soft_deleted_table);
ASSERT_TRUE(is_expired_table);
}
}
TEST_F(MasterTest, GetTableStatesWithId) {
const char* kTableName = "testtable";
const Schema kTableSchema({ ColumnSchema("key", INT32) }, 1);
bool is_soft_deleted_table = false;
bool is_expired_table = false;
// Create a new table.
ASSERT_OK(CreateTable(kTableName, kTableSchema));
ListTablesResponsePB tables;
NO_FATALS(DoListAllTables(&tables));
ASSERT_EQ(1, tables.tables_size());
ASSERT_EQ(kTableName, tables.tables(0).name());
string table_id = tables.tables(0).id();
ASSERT_FALSE(table_id.empty());
TableIdentifierPB table_identifier;
table_identifier.set_table_id(table_id);
{
// Default table is not expired.
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
ASSERT_OK(master_->catalog_manager()->GetTableStates(
table_identifier, CatalogManager::TableInfoMapType::kAllTableType,
&is_soft_deleted_table, &is_expired_table));
ASSERT_FALSE(is_soft_deleted_table);
ASSERT_FALSE(is_expired_table);
}
{
// In reserve time, table is not expired.
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
ASSERT_OK(SoftDelete(kTableName, 100));
ASSERT_OK(master_->catalog_manager()->GetTableStates(
table_identifier, CatalogManager::TableInfoMapType::kAllTableType,
&is_soft_deleted_table, &is_expired_table));
ASSERT_TRUE(is_soft_deleted_table);
ASSERT_FALSE(is_expired_table);
ASSERT_OK(RecallTable(table_id));
}
{
// After reserve time, table is expired.
CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager());
ASSERT_OK(SoftDelete(kTableName, 1));
SleepFor(MonoDelta::FromSeconds(1));
ASSERT_OK(master_->catalog_manager()->GetTableStates(
table_identifier, CatalogManager::TableInfoMapType::kAllTableType,
&is_soft_deleted_table, &is_expired_table));
ASSERT_TRUE(is_soft_deleted_table);
ASSERT_TRUE(is_expired_table);
}
}
} // namespace master
} // namespace kudu