blob: aa9c32843af64ff37917ea08ee8764f7965ef158 [file] [log] [blame]
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with this
* work for additional information regarding copyright ownership. The ASF
* licenses this file to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* <p>
* http://www.apache.org/licenses/LICENSE-2.0
* <p>
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations under
* the License.
*/
package org.apache.knox.gateway.service.config.remote.zk;
import org.apache.commons.io.FileUtils;
import org.apache.knox.gateway.config.ConfigurationException;
import org.apache.knox.gateway.config.GatewayConfig;
import org.apache.knox.gateway.service.config.remote.RemoteConfigurationRegistryConfig;
import org.apache.knox.gateway.services.security.AliasService;
import org.easymock.EasyMock;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.junit.rules.TemporaryFolder;
import javax.security.auth.login.AppConfigurationEntry;
import javax.security.auth.login.Configuration;
import java.io.File;
import java.io.IOException;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import static org.hamcrest.CoreMatchers.endsWith;
import static org.hamcrest.CoreMatchers.startsWith;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
public class RemoteConfigurationRegistryJAASConfigTest {
@Rule
public final TemporaryFolder testFolder = new TemporaryFolder();
@Rule
public final ExpectedException expectedException = ExpectedException.none();
@Test
public void testZooKeeperDigestContextEntry() throws Exception {
List<RemoteConfigurationRegistryConfig> registryConfigs = new ArrayList<>();
final String ENTRY_NAME = "my_digest_context";
final String DIGEST_PRINCIPAL = "myIdentity";
final String DIGEST_PWD_ALIAS = "myAlias";
final String DIGEST_PWD = "mysecret";
AliasService aliasService = EasyMock.createNiceMock(AliasService.class);
EasyMock.expect(aliasService.getPasswordFromAliasForGateway(DIGEST_PWD_ALIAS)).andReturn(DIGEST_PWD.toCharArray()).anyTimes();
EasyMock.replay(aliasService);
registryConfigs.add(createDigestConfig(ENTRY_NAME, DIGEST_PRINCIPAL, DIGEST_PWD_ALIAS));
try {
RemoteConfigurationRegistryJAASConfig jaasConfig =
RemoteConfigurationRegistryJAASConfig.configure(registryConfigs, aliasService);
// Make sure there are no entries for an invalid context entry name
assertNull(jaasConfig.getAppConfigurationEntry("invalid"));
// Validate the intended context entry
validateDigestContext(jaasConfig,
ENTRY_NAME,
RemoteConfigurationRegistryJAASConfig.digestLoginModules.get("ZOOKEEPER"),
DIGEST_PRINCIPAL,
DIGEST_PWD);
} finally {
Configuration.setConfiguration(null);
}
}
@Test
public void testKerberosContextEntry() throws Exception {
List<RemoteConfigurationRegistryConfig> registryConfigs = new ArrayList<>();
final String ENTRY_NAME = "my_kerberos_context";
final String PRINCIPAL = "myIdentity";
final String dummyKeyTab = createTempKeytabFile("dummyKeytab1");
registryConfigs.add(createKerberosConfig(ENTRY_NAME, PRINCIPAL, dummyKeyTab));
try {
RemoteConfigurationRegistryJAASConfig jaasConfig =
RemoteConfigurationRegistryJAASConfig.configure(registryConfigs, null);
// Make sure there are no entries for an invalid context entry name
assertNull(jaasConfig.getAppConfigurationEntry("invalid"));
// Validate the intended context entry
validateKerberosContext(jaasConfig,
ENTRY_NAME,
PRINCIPAL,
dummyKeyTab,
true,
false);
} finally {
Configuration.setConfiguration(null);
}
}
@Test
public void testZooKeeperMultipleContextEntries() throws Exception {
List<RemoteConfigurationRegistryConfig> registryConfigs = new ArrayList<>();
final String KERBEROS_ENTRY_NAME = "my_kerberos_context";
final String KERBEROS_PRINCIPAL = "myKerberosIdentity";
final String DIGEST_ENTRY_NAME = "my_digest_context";
final String DIGEST_PRINCIPAL = "myDigestIdentity";
final String DIGEST_PWD_ALIAS = "myAlias";
final String DIGEST_PWD = "mysecret";
AliasService aliasService = EasyMock.createNiceMock(AliasService.class);
EasyMock.expect(aliasService.getPasswordFromAliasForGateway(DIGEST_PWD_ALIAS)).andReturn(DIGEST_PWD.toCharArray()).anyTimes();
EasyMock.replay(aliasService);
final String dummyKeyTab = createTempKeytabFile("dummyKeytab2");
registryConfigs.add(createKerberosConfig(KERBEROS_ENTRY_NAME, KERBEROS_PRINCIPAL, dummyKeyTab));
registryConfigs.add(createDigestConfig(DIGEST_ENTRY_NAME, DIGEST_PRINCIPAL, DIGEST_PWD_ALIAS));
try {
RemoteConfigurationRegistryJAASConfig jaasConfig =
RemoteConfigurationRegistryJAASConfig.configure(registryConfigs, aliasService);
// Make sure there are no entries for an invalid context entry name
assertNull(jaasConfig.getAppConfigurationEntry("invalid"));
// Validate the kerberos context entry
validateKerberosContext(jaasConfig,
KERBEROS_ENTRY_NAME,
KERBEROS_PRINCIPAL,
dummyKeyTab,
true,
false);
// Validate the digest context entry
validateDigestContext(jaasConfig,
DIGEST_ENTRY_NAME,
RemoteConfigurationRegistryJAASConfig.digestLoginModules.get("ZOOKEEPER"),
DIGEST_PRINCIPAL,
DIGEST_PWD);
} finally {
Configuration.setConfiguration(null);
}
}
@Test
public void testZooKeeperDigestContextEntryWithoutAliasService() throws Exception {
List<RemoteConfigurationRegistryConfig> registryConfigs = new ArrayList<>();
final String ENTRY_NAME = "my_digest_context";
final String DIGEST_PRINCIPAL = "myIdentity";
final String DIGEST_PWD_ALIAS = "myAlias";
registryConfigs.add(createDigestConfig(ENTRY_NAME, DIGEST_PRINCIPAL, DIGEST_PWD_ALIAS));
try {
RemoteConfigurationRegistryJAASConfig jaasConfig =
RemoteConfigurationRegistryJAASConfig.configure(registryConfigs, null);
assertNotNull(jaasConfig);
fail("Expected IllegalArgumentException because the AliasService is not available.");
} catch (IllegalArgumentException e) {
// Expected
assertTrue(e.getMessage().contains("AliasService"));
} catch (Throwable e) {
fail("Wrong exception encountered: " + e.getClass().getName() + ", " + e.getMessage());
} finally {
Configuration.setConfiguration(null);
}
}
@Test
public void shouldRaiseAnErrorWithMeaningfulErrorMessageInCaseOfJAASConfigError() throws Exception {
shouldRaiseAnErrorWithMeaningfulErrorMessageIfAuthLoginConfigCannotBeRead();
shouldRaiseAnErrorWithMeaningfulErrorMessageIfAuthLoginConfigCannotBeParsed();
shouldRaiseAnErrorWithMeaningfulErrorMessageIfReferencedKeytabFileDoesNotExists();
}
private void shouldRaiseAnErrorWithMeaningfulErrorMessageIfAuthLoginConfigCannotBeRead() throws Exception {
final List<RemoteConfigurationRegistryConfig> registryConfigs = new ArrayList<>();
System.setProperty(GatewayConfig.KRB5_LOGIN_CONFIG, "nonExistingFilePath");
expectedException.expect(ConfigurationException.class);
expectedException.expectMessage(startsWith(RemoteConfigurationRegistryJAASConfig.JAAS_CONFIG_ERRROR_PREFIX));
try {
RemoteConfigurationRegistryJAASConfig.configure(registryConfigs, null);
} finally {
System.clearProperty(GatewayConfig.KRB5_LOGIN_CONFIG);
Configuration.setConfiguration(null);
}
}
private void shouldRaiseAnErrorWithMeaningfulErrorMessageIfAuthLoginConfigCannotBeParsed() throws Exception {
final List<RemoteConfigurationRegistryConfig> registryConfigs = new ArrayList<>();
final String jaasConfigFilePath = writeInvalidJaasConf(false, "jaasConfWithInvalidKeytab", createTempKeytabFile("invalidKeytab"));
System.setProperty(GatewayConfig.KRB5_LOGIN_CONFIG, jaasConfigFilePath);
expectedException.expect(ConfigurationException.class);
expectedException.expectMessage(startsWith(RemoteConfigurationRegistryJAASConfig.JAAS_CONFIG_ERRROR_PREFIX));
try {
RemoteConfigurationRegistryJAASConfig.configure(registryConfigs, null);
} finally {
System.clearProperty(GatewayConfig.KRB5_LOGIN_CONFIG);
Configuration.setConfiguration(null);
}
}
private void shouldRaiseAnErrorWithMeaningfulErrorMessageIfReferencedKeytabFileDoesNotExists() throws Exception {
final String jaasConfigFilePath = writeInvalidJaasConf(true, "jaasConfWithMissingKeytab", "nonExistingKeytabFile");
System.setProperty(GatewayConfig.KRB5_LOGIN_CONFIG, jaasConfigFilePath);
expectedException.expect(ConfigurationException.class);
expectedException.expectMessage(startsWith("The specified keytab file"));
expectedException.expectMessage(endsWith("is either non-existing or cannot be read!"));
try {
RemoteConfigurationRegistryJAASConfig.configure(new ArrayList<>(), null);
} finally {
System.clearProperty(GatewayConfig.KRB5_LOGIN_CONFIG);
Configuration.setConfiguration(null);
}
}
private String createTempKeytabFile(String keytabFileName) throws IOException {
final File keytabFile = testFolder.newFile(keytabFileName);
FileUtils.writeStringToFile(keytabFile, "dummyBinaryContent", StandardCharsets.UTF_8);
return keytabFile.getAbsolutePath();
}
private String writeInvalidJaasConf(boolean valid, String jaasConfFileName, String keytabFileName) throws IOException {
final File jaasConfigFile = testFolder.newFile(jaasConfFileName);
final String jaasConfig = "com.sun.security.jgss.initiate {\n" +
"com.sun.security.auth.module.Krb5LoginModule required\n" +
"renewTGT=false\n" +
"doNotPrompt=true\n" +
"useKeyTab=true\n" +
"keyTab=" + (valid ? "\"" : "" ) + keytabFileName + (valid ? "\"" : "" ) + "\n" + //note the missing quotes in case valid=false; it should be keyTab="/etc/security/keytabs/knox.service.keytab"
"principal=\"knox/myHost@myRealm\"\n" +
"storeKey=true\n" +
"useTicketCache=false;\n" +
"};";
FileUtils.writeStringToFile(jaasConfigFile, jaasConfig, StandardCharsets.UTF_8);
return jaasConfigFile.getAbsolutePath();
}
private static RemoteConfigurationRegistryConfig createDigestConfig(String entryName,
String principal,
String credentialAlias) {
return createDigestConfig(entryName, principal, credentialAlias, "ZooKeeper");
}
private static RemoteConfigurationRegistryConfig createDigestConfig(String entryName,
String principal,
String credentialAlias,
String registryType) {
RemoteConfigurationRegistryConfig rc = EasyMock.createNiceMock(RemoteConfigurationRegistryConfig.class);
EasyMock.expect(rc.getRegistryType()).andReturn(registryType).anyTimes();
EasyMock.expect(rc.getName()).andReturn(entryName).anyTimes();
EasyMock.expect(rc.isSecureRegistry()).andReturn(true).anyTimes();
EasyMock.expect(rc.getAuthType()).andReturn("digest").anyTimes();
EasyMock.expect(rc.getPrincipal()).andReturn(principal).anyTimes();
EasyMock.expect(rc.getCredentialAlias()).andReturn(credentialAlias).anyTimes();
EasyMock.replay(rc);
return rc;
}
private static RemoteConfigurationRegistryConfig createKerberosConfig(String entryName,
String principal,
String keyTabPath) {
return createKerberosConfig(entryName, principal, keyTabPath, "ZooKeeper");
}
private static RemoteConfigurationRegistryConfig createKerberosConfig(String entryName,
String principal,
String keyTabPath,
String registryType) {
return createKerberosConfig(entryName, principal, keyTabPath, null, null, registryType);
}
private static RemoteConfigurationRegistryConfig createKerberosConfig(String entryName,
String principal,
String keyTabPath,
Boolean useKeyTab,
Boolean useTicketCache,
String registryType) {
RemoteConfigurationRegistryConfig rc = EasyMock.createNiceMock(RemoteConfigurationRegistryConfig.class);
EasyMock.expect(rc.getRegistryType()).andReturn(registryType).anyTimes();
EasyMock.expect(rc.getName()).andReturn(entryName).anyTimes();
EasyMock.expect(rc.isSecureRegistry()).andReturn(true).anyTimes();
EasyMock.expect(rc.getAuthType()).andReturn("kerberos").anyTimes();
EasyMock.expect(rc.getPrincipal()).andReturn(principal).anyTimes();
EasyMock.expect(rc.getKeytab()).andReturn(keyTabPath).anyTimes();
EasyMock.expect(rc.isUseKeyTab()).andReturn(useKeyTab != null ? useKeyTab : true).anyTimes();
EasyMock.expect(rc.isUseTicketCache()).andReturn(useTicketCache != null ? useTicketCache : false).anyTimes();
EasyMock.replay(rc);
return rc;
}
private static void validateDigestContext(RemoteConfigurationRegistryJAASConfig config,
String entryName,
String loginModule,
String principal,
String password) throws Exception {
AppConfigurationEntry[] myContextEntries = config.getAppConfigurationEntry(entryName);
assertNotNull(myContextEntries);
assertEquals(1, myContextEntries.length);
AppConfigurationEntry entry = myContextEntries[0];
assertEquals(entry.getLoginModuleName(), loginModule);
Map<String, ?> entryOpts = entry.getOptions();
assertEquals(principal, entryOpts.get("username"));
assertEquals(password, entryOpts.get("password"));
}
private static void validateKerberosContext(RemoteConfigurationRegistryJAASConfig config,
String entryName,
String principal,
String keyTab,
boolean useKeyTab,
boolean useTicketCache) throws Exception {
AppConfigurationEntry[] myContextEntries = config.getAppConfigurationEntry(entryName);
assertNotNull(myContextEntries);
assertEquals(1, myContextEntries.length);
AppConfigurationEntry entry = myContextEntries[0];
assertTrue(entry.getLoginModuleName().endsWith(".security.auth.module.Krb5LoginModule"));
Map<String, ?> entryOpts = entry.getOptions();
assertEquals(principal, entryOpts.get("principal"));
assertEquals(keyTab, entryOpts.get("keyTab"));
assertEquals(useKeyTab, Boolean.valueOf((String)entryOpts.get("useKeyTab")));
assertEquals(useTicketCache, Boolean.valueOf((String)entryOpts.get("useTicketCache")));
}
}