Clean up javadoc.
git-svn-id: https://svn.apache.org/repos/asf/karaf/webconsole/trunk@1242777 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/brand/BrandProvider.java b/core/src/main/java/org/apache/karaf/webconsole/core/brand/BrandProvider.java
index 530f060..4b150b1 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/brand/BrandProvider.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/brand/BrandProvider.java
@@ -22,11 +22,31 @@
import org.apache.wicket.behavior.IBehavior;
import org.apache.wicket.markup.html.image.Image;
+/**
+ * Interface which allows to customize look and feel.
+ */
public interface BrandProvider {
+ /**
+ * Header image customization.
+ *
+ * @param imageId Identifier of image element.
+ * @return
+ */
Image getHeaderImage(String imageId);
+ /**
+ * List of generic behaviours to apply on every page.
+ *
+ * @return Brand specific behaviors, like CSS or JavaScript references.
+ */
List<IBehavior> getBehaviors();
+ /**
+ * Page specific hook which allows to modify or replace elements on singular
+ * page.
+ *
+ * @param page Page to modify.
+ */
void modify(Page page);
}
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/brand/DefaultBrandProvider.java b/core/src/main/java/org/apache/karaf/webconsole/core/brand/DefaultBrandProvider.java
index 9b7c670..c488626 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/brand/DefaultBrandProvider.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/brand/DefaultBrandProvider.java
@@ -16,6 +16,8 @@
*/
package org.apache.karaf.webconsole.core.brand;
+import static org.apache.wicket.markup.html.CSSPackageResource.getHeaderContribution;
+
import java.io.Serializable;
import java.util.Collections;
import java.util.List;
@@ -25,11 +27,15 @@
import org.apache.wicket.ResourceReference;
import org.apache.wicket.behavior.IBehavior;
import org.apache.wicket.behavior.SimpleAttributeModifier;
-import org.apache.wicket.markup.html.CSSPackageResource;
import org.apache.wicket.markup.html.image.Image;
+/**
+ * Default brand customization.
+ */
public class DefaultBrandProvider implements BrandProvider, Serializable /* for tests mainly */ {
+ private static final long serialVersionUID = 1L;
+
public Image getHeaderImage(String imageId) {
Image image = new Image(imageId, new ResourceReference(BasePage.class, "images/karaf-logo.png"));
image.add(new SimpleAttributeModifier("width", "150"));
@@ -44,8 +50,8 @@
}
public void modify(Page page) {
- page.add(CSSPackageResource.getHeaderContribution(BasePage.class, "style.css"));
- page.add(CSSPackageResource.getHeaderContribution(BasePage.class, "grid.css"));
+ page.add(getHeaderContribution(BasePage.class, "style.css"));
+ page.add(getHeaderContribution(BasePage.class, "grid.css"));
}
}
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/dashboard/DashboardPage.java b/core/src/main/java/org/apache/karaf/webconsole/core/dashboard/DashboardPage.java
index a0339b6..50c149e 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/dashboard/DashboardPage.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/dashboard/DashboardPage.java
@@ -42,6 +42,8 @@
add(CSSPackageResource.getHeaderContribution(DashboardPage.class, "dashboard.css"));
add(new Label("noWidgets", "So far there is no widgets to display") {
+ private static final long serialVersionUID = 1L;
+
@Override
public boolean isVisible() {
return widgets.size() == 0;
@@ -49,6 +51,8 @@
});
add(new ListView<WidgetProvider>("widgets", new ListModel<WidgetProvider>(widgets)) {
+ private static final long serialVersionUID = 1L;
+
@Override
protected void populateItem(ListItem<WidgetProvider> item) {
item.add(item.getModelObject().createPanel("widget"));
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/form/LabelBorder.java b/core/src/main/java/org/apache/karaf/webconsole/core/form/LabelBorder.java
index 3f2ccc7..4543140 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/form/LabelBorder.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/form/LabelBorder.java
@@ -21,6 +21,8 @@
public class LabelBorder extends Border {
+ private static final long serialVersionUID = 1L;
+
public LabelBorder(String id, IModel<?> model) {
super(id, model);
}
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/form/MapEditForm.java b/core/src/main/java/org/apache/karaf/webconsole/core/form/MapEditForm.java
index 2fbf4f9..4240ee7 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/form/MapEditForm.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/form/MapEditForm.java
@@ -26,8 +26,16 @@
import org.apache.wicket.model.CompoundPropertyModel;
import org.apache.wicket.model.IModel;
+/**
+ * Generic map editing form.
+ *
+ * @param <K> Key type.
+ * @param <V> Value type.
+ */
public abstract class MapEditForm<K, V> extends Form<Map<K, V>> {
+ private static final long serialVersionUID = 1L;
+
public MapEditForm(String id, CompoundPropertyModel<Map<K, V>> model) {
super(id, model);
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/internal/LanguagePanel.java b/core/src/main/java/org/apache/karaf/webconsole/core/internal/LanguagePanel.java
index b960d8d..e9f8fce 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/internal/LanguagePanel.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/internal/LanguagePanel.java
@@ -32,17 +32,25 @@
public class LanguagePanel extends Panel {
+ private static final long serialVersionUID = 1L;
+
public LanguagePanel(String id, IModel<List<Locale>> locales) {
super(id);
add(new Label("languagesTitle",new StringResourceModel("languages.available",this.getDefaultModel())));
add(new ListView<Locale>("languages", locales) {
+
+ private static final long serialVersionUID = 1L;
+
@Override
protected void populateItem(final ListItem<Locale> item) {
final Locale model = item.getModelObject();
Image flagImage = new Image("flag", new ResourceReference(BasePage.class, "images/" + model.getDisplayName(Locale.ENGLISH).toLowerCase() + "-flag.png"));
Link<Void> link = new Link<Void>("languageLink") {
+
+ private static final long serialVersionUID = 1L;
+
@Override
public void onClick() {
getSession().setLocale(model);
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/internal/SidebarPanel.java b/core/src/main/java/org/apache/karaf/webconsole/core/internal/SidebarPanel.java
index 33dad69..d8cf3f1 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/internal/SidebarPanel.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/internal/SidebarPanel.java
@@ -26,12 +26,17 @@
public class SidebarPanel extends Panel {
+ private static final long serialVersionUID = 1L;
+
public SidebarPanel(String id, SidebarProvider provider) {
super(id);
add(provider.getMasterPageLink("masterPageLink", "masterPageLabel"));
add(new ListView<Link<Page>>("subPageLinks", provider.getItems("subPageLink", "subPageLabel")) {
+
+ private static final long serialVersionUID = 1L;
+
@Override
protected void populateItem(ListItem<Link<Page>> item) {
item.add(item.getModelObject());
@@ -39,6 +44,9 @@
});
add(new ListView<WidgetProvider>("widgets", provider.getWidgetProviders()) {
+
+ private static final long serialVersionUID = 1L;
+
@Override
protected void populateItem(ListItem<WidgetProvider> item) {
item.add(item.getModelObject().createPanel("widget"));
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/internal/SystemConsoleTabProvider.java b/core/src/main/java/org/apache/karaf/webconsole/core/internal/SystemConsoleTabProvider.java
index 2cf916f..de32c92 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/internal/SystemConsoleTabProvider.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/internal/SystemConsoleTabProvider.java
@@ -29,6 +29,8 @@
public class SystemConsoleTabProvider implements ConsoleTabProvider, Serializable {
+ private static final long serialVersionUID = 1L;
+
public Link<Page> getModuleLink(String componentId, String labelId) {
Link<Page> link = new BookmarkablePageLink<Page>(componentId, DashboardPage.class);
link.add(new Label(labelId, "Dashboard"));
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/internal/preferences/SystemPreferencesForm.java b/core/src/main/java/org/apache/karaf/webconsole/core/internal/preferences/SystemPreferencesForm.java
index 0366523..a2dbe2a 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/internal/preferences/SystemPreferencesForm.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/internal/preferences/SystemPreferencesForm.java
@@ -34,6 +34,8 @@
*/
public class SystemPreferencesForm extends Form<Preferences> {
+ private static final long serialVersionUID = 1L;
+
private transient Logger logger = LoggerFactory.getLogger(SystemPreferencesForm.class);
private FileUploadField upload;
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/internal/preferences/SystemPreferencesPanel.java b/core/src/main/java/org/apache/karaf/webconsole/core/internal/preferences/SystemPreferencesPanel.java
index f16cfb6..992935b 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/internal/preferences/SystemPreferencesPanel.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/internal/preferences/SystemPreferencesPanel.java
@@ -29,6 +29,8 @@
*/
public class SystemPreferencesPanel extends Panel {
+ private static final long serialVersionUID = 1L;
+
@PaxWicketBean(name = "preferencesService")
private PreferencesService preferences;
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/navigation/ExtendableConsoleTabProvider.java b/core/src/main/java/org/apache/karaf/webconsole/core/navigation/ExtendableConsoleTabProvider.java
index decca02..0f53c1e 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/navigation/ExtendableConsoleTabProvider.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/navigation/ExtendableConsoleTabProvider.java
@@ -29,6 +29,8 @@
*/
public class ExtendableConsoleTabProvider implements ConsoleTabProvider {
+ private static final long serialVersionUID = 1L;
+
private Collection<NavigationProvider> extensions;
private ConsoleTabProvider base;
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/navigation/ExtendableSidebarProvider.java b/core/src/main/java/org/apache/karaf/webconsole/core/navigation/ExtendableSidebarProvider.java
index 3cec6bf..59b2517 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/navigation/ExtendableSidebarProvider.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/navigation/ExtendableSidebarProvider.java
@@ -29,6 +29,8 @@
*/
public class ExtendableSidebarProvider implements SidebarProvider {
+ private static final long serialVersionUID = 1L;
+
private Collection<NavigationProvider> navigationProviders;
private Collection<WidgetProvider> widgetProviders;
private SidebarProvider base;
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/navigation/markup/NavigationPanel.java b/core/src/main/java/org/apache/karaf/webconsole/core/navigation/markup/NavigationPanel.java
index 4eb4299..d6f5038 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/navigation/markup/NavigationPanel.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/navigation/markup/NavigationPanel.java
@@ -31,10 +31,15 @@
*/
public class NavigationPanel extends Panel {
+ private static final long serialVersionUID = 1L;
+
public NavigationPanel(String id, IModel<List<ConsoleTabProvider>> model) {
super(id);
add(new ListView<ConsoleTabProvider>("tabs", model) {
+
+ private static final long serialVersionUID = 1L;
+
@Override
protected void populateItem(ListItem<ConsoleTabProvider> item) {
ConsoleTabProvider tab = item.getModelObject();
@@ -42,6 +47,9 @@
item.add(tab.getModuleLink("moduleLink", "moduleLabel"));
item.add(new ListView<Link<Page>>("moduleLinks", tab.getItems("link", "label")) {
+
+ private static final long serialVersionUID = 1L;
+
@Override
protected void populateItem(ListItem<Link<Page>> item) {
item.add(item.getModelObject());
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/page/AvatarImage.java b/core/src/main/java/org/apache/karaf/webconsole/core/page/AvatarImage.java
index e6fa853..226ae48 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/page/AvatarImage.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/page/AvatarImage.java
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
package org.apache.karaf.webconsole.core.page;
import org.apache.wicket.ResourceReference;
@@ -5,8 +21,13 @@
import org.apache.wicket.resource.ByteArrayResource;
import org.osgi.service.prefs.Preferences;
+/**
+ * Avatar image which displays picture from preference store.
+ */
public class AvatarImage extends Image {
+ private static final long serialVersionUID = 1L;
+
public AvatarImage(String id, Preferences preferences) {
super(id);
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/page/SecuredPage.java b/core/src/main/java/org/apache/karaf/webconsole/core/page/SecuredPage.java
index 886eb30..56bf240 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/page/SecuredPage.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/page/SecuredPage.java
@@ -46,6 +46,9 @@
public SecuredPage() {
add(new NavigationPanel("navigationPanel", new LoadableDetachableModel<List<ConsoleTabProvider>>() {
+
+ private static final long serialVersionUID = 1L;
+
@Override
protected List<ConsoleTabProvider> load() {
return tabs;
@@ -59,6 +62,9 @@
add(new SecuredPageLink<PreferencesPage>("preferencesLink", PreferencesPage.class));
Link<Void> aLink = new Link<Void>("logoutLink") {
+
+ private static final long serialVersionUID = 1L;
+
@Override
public void onClick() {
WebConsoleSession.get().invalidateNow();
@@ -66,8 +72,8 @@
setResponsePage(LoginPage.class);
}
};
- aLink.add(new Label("logoutTranslatedLink",new StringResourceModel("logout.link", this.getDefaultModel())));
- add(aLink);
+ aLink.add(new Label("logoutTranslatedLink", new StringResourceModel("logout.link", this.getDefaultModel())));
+ add(aLink);
}
}
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/panel/AbstractImagePanel.java b/core/src/main/java/org/apache/karaf/webconsole/core/panel/AbstractImagePanel.java
index 5a369ec..edb46b7 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/panel/AbstractImagePanel.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/panel/AbstractImagePanel.java
@@ -23,6 +23,8 @@
*/
public class AbstractImagePanel extends Panel {
+ private static final long serialVersionUID = 1L;
+
public AbstractImagePanel(String id) {
super(id);
}
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/panel/CssImagePanel.java b/core/src/main/java/org/apache/karaf/webconsole/core/panel/CssImagePanel.java
index 932f1c5..82f875a 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/panel/CssImagePanel.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/panel/CssImagePanel.java
@@ -26,6 +26,8 @@
*/
public class CssImagePanel extends AbstractImagePanel {
+ private static final long serialVersionUID = 1L;
+
public CssImagePanel(String id, String cssClass) {
super(id);
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/panel/StaticImagePanel.java b/core/src/main/java/org/apache/karaf/webconsole/core/panel/StaticImagePanel.java
index a429b5a..d514bc6 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/panel/StaticImagePanel.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/panel/StaticImagePanel.java
@@ -24,6 +24,8 @@
*/
public class StaticImagePanel extends AbstractImagePanel {
+ private static final long serialVersionUID = 1L;
+
public StaticImagePanel(String id, ResourceReference resource) {
super(id);
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/preferences/PreferencesModel.java b/core/src/main/java/org/apache/karaf/webconsole/core/preferences/PreferencesModel.java
index 7048766..112252b 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/preferences/PreferencesModel.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/preferences/PreferencesModel.java
@@ -26,6 +26,8 @@
*/
public class PreferencesModel extends LoadableDetachableModel<Preferences> {
+ private static final long serialVersionUID = 1L;
+
/**
* Service to load preferences.
*/
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/preferences/PreferencesPanel.java b/core/src/main/java/org/apache/karaf/webconsole/core/preferences/PreferencesPanel.java
index db02979..3a0a370 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/preferences/PreferencesPanel.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/preferences/PreferencesPanel.java
@@ -30,6 +30,8 @@
*/
public class PreferencesPanel extends Panel {
+ private static final long serialVersionUID = 1L;
+
public PreferencesPanel(String id, String user, PreferencesService service, IModel<Preferences> model) throws BackingStoreException {
super(id, model);
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/security/JaasWebSession.java b/core/src/main/java/org/apache/karaf/webconsole/core/security/JaasWebSession.java
index ae09684..2e1c9d1 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/security/JaasWebSession.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/security/JaasWebSession.java
@@ -31,6 +31,8 @@
*/
public abstract class JaasWebSession extends WebConsoleSession {
+ private static final long serialVersionUID = 1L;
+
/**
* Logger.
*/
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/security/KarafJaasWebSession.java b/core/src/main/java/org/apache/karaf/webconsole/core/security/KarafJaasWebSession.java
index 3063596..390d17e 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/security/KarafJaasWebSession.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/security/KarafJaasWebSession.java
@@ -26,6 +26,8 @@
*/
public class KarafJaasWebSession extends JaasWebSession {
+ private static final long serialVersionUID = 1L;
+
private static final String KARAF_REALM = "karaf";
public KarafJaasWebSession(Request request) {
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/security/SecuredPageLink.java b/core/src/main/java/org/apache/karaf/webconsole/core/security/SecuredPageLink.java
index 8b1b47e..6979216 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/security/SecuredPageLink.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/security/SecuredPageLink.java
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
package org.apache.karaf.webconsole.core.security;
import org.apache.karaf.webconsole.core.page.SecuredPage;
@@ -5,8 +21,16 @@
import org.apache.wicket.authentication.AuthenticatedWebSession;
import org.apache.wicket.markup.html.link.BookmarkablePageLink;
+/**
+ * Bookmarkable secured link which hides link if destination page is not
+ * accessible by curent user/session.
+ *
+ * @param <T>
+ */
public class SecuredPageLink<T extends SecuredPage> extends BookmarkablePageLink<T> {
+ private static final long serialVersionUID = 1L;
+
public SecuredPageLink(String id, Class<T> pageClass) {
this(id, pageClass, null);
}
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/security/WebConsoleSession.java b/core/src/main/java/org/apache/karaf/webconsole/core/security/WebConsoleSession.java
index 548d69c..8748f18 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/security/WebConsoleSession.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/security/WebConsoleSession.java
@@ -24,6 +24,8 @@
*/
public abstract class WebConsoleSession extends AuthenticatedWebSession {
+ private static final long serialVersionUID = 1L;
+
public WebConsoleSession(Request request) {
super(request);
}
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/table/ActionsPanel.java b/core/src/main/java/org/apache/karaf/webconsole/core/table/ActionsPanel.java
index 0e613f9..5fc5987 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/table/ActionsPanel.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/table/ActionsPanel.java
@@ -34,6 +34,8 @@
@SuppressWarnings("rawtypes")
public class ActionsPanel<T> extends Panel {
+ private static final long serialVersionUID = 1L;
+
public ActionsPanel(String componentId, IModel<T> model) {
super(componentId, model);
@@ -41,6 +43,8 @@
final List<Link> links = getLinks(model.getObject(), "action", "label");
add(new ListView<Link>("actions", new ListModel<Link>(links)) {
+ private static final long serialVersionUID = 1L;
+
@Override
protected void populateItem(ListItem<Link> item) {
item.addOrReplace(item.getModelObject());
@@ -60,5 +64,4 @@
return Collections.emptyList();
}
-
}
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/table/OrdinalColumn.java b/core/src/main/java/org/apache/karaf/webconsole/core/table/OrdinalColumn.java
index aaddb3a..0fb26b8 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/table/OrdinalColumn.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/table/OrdinalColumn.java
@@ -28,7 +28,9 @@
*/
public class OrdinalColumn<T> extends AbstractColumn<T> {
- transient int counter = 1;
+ private static final long serialVersionUID = 1L;
+
+ private transient int counter = 1;
public OrdinalColumn(String displayModel, String sortProperty) {
super(Model.of(displayModel), sortProperty);
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/table/PropertyColumnExt.java b/core/src/main/java/org/apache/karaf/webconsole/core/table/PropertyColumnExt.java
index 108ca30..42cdeb7 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/table/PropertyColumnExt.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/table/PropertyColumnExt.java
@@ -19,8 +19,15 @@
import org.apache.wicket.extensions.markup.html.repeater.data.table.PropertyColumn;
import org.apache.wicket.model.Model;
+/**
+ * Column which given label in serializable model.
+ *
+ * @param <T> Type of displayed data.
+ */
public class PropertyColumnExt<T> extends PropertyColumn<T> {
+ private static final long serialVersionUID = 1L;
+
public PropertyColumnExt(String label, String property) {
super(Model.of(label), property);
}
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/table/SortablePropertyColumnExt.java b/core/src/main/java/org/apache/karaf/webconsole/core/table/SortablePropertyColumnExt.java
index 19160bc..77ffa7b 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/table/SortablePropertyColumnExt.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/table/SortablePropertyColumnExt.java
@@ -19,8 +19,15 @@
import org.apache.wicket.extensions.markup.html.repeater.data.table.PropertyColumn;
import org.apache.wicket.model.Model;
+/**
+ * Sortable column which wraps given label in serializable model.
+ *
+ * @param <T> Type of displayed data.
+ */
public class SortablePropertyColumnExt<T> extends PropertyColumn<T> {
+ private static final long serialVersionUID = 1L;
+
public SortablePropertyColumnExt(String label, String property) {
super(Model.of(label), property, property);
}
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/table/map/EntryModel.java b/core/src/main/java/org/apache/karaf/webconsole/core/table/map/EntryModel.java
index 23c6594..425f589 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/table/map/EntryModel.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/table/map/EntryModel.java
@@ -20,8 +20,16 @@
import org.apache.wicket.model.IModel;
+/**
+ * Entry model for table row.
+ *
+ * @param <K> Key type.
+ * @param <V> Value type.
+ */
public class EntryModel<K, V> implements IModel<Entry<K, V>> {
+ private static final long serialVersionUID = 1L;
+
private Entry<K, V> object;
public EntryModel(Entry<K, V> object) {
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/table/map/MapDataProvider.java b/core/src/main/java/org/apache/karaf/webconsole/core/table/map/MapDataProvider.java
index 1120473..f638553 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/table/map/MapDataProvider.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/table/map/MapDataProvider.java
@@ -24,8 +24,16 @@
import org.apache.wicket.extensions.markup.html.repeater.util.SortableDataProvider;
import org.apache.wicket.model.IModel;
+/**
+ * Generic data provider for map table.
+ *
+ * @param <K> Key type.
+ * @param <V> Value type.
+ */
public class MapDataProvider<K, V> extends SortableDataProvider<Entry<K, V>> {
+ private static final long serialVersionUID = 1L;
+
private final Map<K, V> map;
public MapDataProvider(Map<K, V> map) {
diff --git a/core/src/main/java/org/apache/karaf/webconsole/core/table/map/MapDataTable.java b/core/src/main/java/org/apache/karaf/webconsole/core/table/map/MapDataTable.java
index 836cca1..e5b5b08 100644
--- a/core/src/main/java/org/apache/karaf/webconsole/core/table/map/MapDataTable.java
+++ b/core/src/main/java/org/apache/karaf/webconsole/core/table/map/MapDataTable.java
@@ -26,8 +26,16 @@
import org.apache.wicket.extensions.markup.html.repeater.data.table.ISortableDataProvider;
import org.apache.wicket.markup.repeater.data.IDataProvider;
+/**
+ * Generic map table.
+ *
+ * @param <K> Key type.
+ * @param <V> Value type.
+ */
public class MapDataTable<K, V> extends DefaultDataTable<Entry<K, V>> {
+ private static final long serialVersionUID = 1L;
+
public MapDataTable(String id, IColumn<Entry<K, V>>[] columns, ISortableDataProvider<Entry<K, V>> dataProvider, int rowsPerPage) {
super(id, Arrays.asList(columns), dataProvider, rowsPerPage);
}