commit d5d0fc79c0cf3b423fc38e559e528c0912fbc011
author David Blevins <dblevins@tomitribe.com> Thu Apr 28 00:29:31 2022 -0700
committer David Blevins <dblevins@tomitribe.com> Thu Apr 28 00:29:31 2022 -0700
tree 9f91a490c6667faa21f75a75dd441910926fc93e
parent 076c610c237b97b7e7f3584ac4b09372b8fc5289

JOHNZON-367 Incorporate PR feedback

johnzon-core/src/main/java/org/apache/johnzon/core/Snippet.java

diff --git a/johnzon-core/src/main/java/org/apache/johnzon/core/Snippet.java b/johnzon-core/src/main/java/org/apache/johnzon/core/Snippet.java
index ba16ed9..06bc005 100644
--- a/johnzon-core/src/main/java/org/apache/johnzon/core/Snippet.java
+++ b/johnzon-core/src/main/java/org/apache/johnzon/core/Snippet.java
@@ -16,6 +16,7 @@
  */
 package org.apache.johnzon.core;
 
+import javax.json.Json;
 import javax.json.JsonArray;
 import javax.json.JsonObject;
 import javax.json.JsonValue;
@@ -49,10 +50,14 @@
      * This constructor should be used only in static or other scenarios were
      * there is no JsonGeneratorFactory instance in scope.
      *
+     * This constructor must not be used in Johnzon project.  It is only here
+     * for convenience for integrators.  Using it disables several Johnzon
+     * features.
+     *
      * @param max the maximum length of the serialized json produced via of()
      */
     public Snippet(final int max) {
-        this(max, new JsonGeneratorFactoryImpl(new HashMap<String, Object>() {
+        this(max, Json.createGeneratorFactory(new HashMap<String, Object>() {
             {
                 this.put(GENERATOR_BUFFER_LENGTH, max);
             }
@@ -265,6 +270,7 @@
                 this.bufferSize = () -> {
                     // disable flushing
                     flush = () -> {
+                        // no-op
                     };
                     // future calls can just return the size
                     bufferSize = () -> size;
@@ -325,10 +331,12 @@
             abstract class Mode extends Writer {
                 @Override
                 public void flush() throws IOException {
+                    // no-op
                 }
 
                 @Override
                 public void close() throws IOException {
+                    // no-op
                 }
             }
 
@@ -406,6 +414,7 @@
             class Truncated extends Mode {
                 @Override
                 public void write(final char[] cbuf, final int off, final int len) throws IOException {
+                    // no-op
                 }
             }
         }