commit 13b824a5a99bf14789a434ddf1e13b11bfd04573
author Vladimir Sitnikov <sitnikov.vladimir@gmail.com> Wed Dec 27 08:28:06 2023 +0300
committer Vladimir Sitnikov <sitnikov.vladimir@gmail.com> Wed Dec 27 12:19:21 2023 +0300
tree b6e5b69f07c8fde99938b983c7c5efaf600f6ece
parent 7ec460defe2eb362ce1f1e23702fcdcef8cd6557

test: ensure all Gui elements initialize non-empty TestElement names

src/dist-check/src/test/java/org/apache/jmeter/junit/JMeterTest.java

diff --git a/src/dist-check/src/test/java/org/apache/jmeter/junit/JMeterTest.java b/src/dist-check/src/test/java/org/apache/jmeter/junit/JMeterTest.java
index 3ed11e8..f442cb6 100644
--- a/src/dist-check/src/test/java/org/apache/jmeter/junit/JMeterTest.java
+++ b/src/dist-check/src/test/java/org/apache/jmeter/junit/JMeterTest.java
@@ -47,6 +47,7 @@
 
 import org.apache.commons.lang3.StringUtils;
 import org.apache.jmeter.config.gui.ObsoleteGui;
+import org.apache.jmeter.control.gui.TestFragmentControllerGui;
 import org.apache.jmeter.dsl.DslPrinterTraverser;
 import org.apache.jmeter.gui.JMeterGUIComponent;
 import org.apache.jmeter.gui.UnsharedComponent;
@@ -374,8 +375,14 @@
         assertEquals("GUI-CLASS: Failed on " + name, name, el.getPropertyAsString(TestElement.GUI_CLASS));
 
         assertEquals("NAME: Failed on " + name, guiItem.getName(), el.getName());
+        if (StringUtils.isEmpty(el.getName())) {
+            fail("Name of the element must not be blank. Gui class " + name + ", element class " + el.getClass().getName());
+        }
         assertEquals("TEST-CLASS: Failed on " + name, el.getClass().getName(), el
                 .getPropertyAsString(TestElement.TEST_CLASS));
+        if (guiItem.getClass() != TestFragmentControllerGui.class) {
+            assertTrue("Should be enabled by default: " + name, el.isEnabled());
+        }
         TestElement el2 = guiItem.createTestElement();
         el.setName("hey, new name!:");
         el.setProperty("NOT", "Shouldn't be here");