Address Google error-prone warnings
diff --git a/glacier/src/main/java/org/jclouds/glacier/blobstore/strategy/internal/BaseSlicingStrategy.java b/glacier/src/main/java/org/jclouds/glacier/blobstore/strategy/internal/BaseSlicingStrategy.java
index 181110c..0200842 100644
--- a/glacier/src/main/java/org/jclouds/glacier/blobstore/strategy/internal/BaseSlicingStrategy.java
+++ b/glacier/src/main/java/org/jclouds/glacier/blobstore/strategy/internal/BaseSlicingStrategy.java
@@ -59,7 +59,7 @@
}
protected long calculatePartSize(long length) {
- long lengthInMB = (long) (length / (1L << 20)) + 1;
+ long lengthInMB = (length / (1L << 20)) + 1;
double fpPartSizeInMB = sqrt(ratio * lengthInMB); //Get the part size which matches the given ratio
long partSizeInMB = Long.highestOneBit((long) fpPartSizeInMB - 1) << 1;
if (partSizeInMB < 1) return 1;
diff --git a/glacier/src/main/java/org/jclouds/glacier/domain/JobMetadata.java b/glacier/src/main/java/org/jclouds/glacier/domain/JobMetadata.java
index 1e67df8..52fea6b 100644
--- a/glacier/src/main/java/org/jclouds/glacier/domain/JobMetadata.java
+++ b/glacier/src/main/java/org/jclouds/glacier/domain/JobMetadata.java
@@ -77,7 +77,7 @@
this.archiveId = archiveId;
this.archiveSizeInBytes = archiveSizeInBytes;
this.archiveSHA256TreeHash = archiveSHA256TreeHash;
- this.completed = checkNotNull(completed, "completed");
+ this.completed = completed;
this.completionDate = completionDate == null ? null : (Date) completionDate.clone();
this.creationDate = (Date) checkNotNull(creationDate, "creationDate").clone();
this.inventorySizeInBytes = inventorySizeInBytes;
diff --git a/glacier/src/main/java/org/jclouds/glacier/predicates/validators/DescriptionValidator.java b/glacier/src/main/java/org/jclouds/glacier/predicates/validators/DescriptionValidator.java
index 5dd9f16..bfd381f 100644
--- a/glacier/src/main/java/org/jclouds/glacier/predicates/validators/DescriptionValidator.java
+++ b/glacier/src/main/java/org/jclouds/glacier/predicates/validators/DescriptionValidator.java
@@ -39,7 +39,7 @@
if (isNullOrEmpty(description))
return;
checkArgument(description.length() <= MAX_DESC_LENGTH,
- "Description can't be longer than %d characters but was %d",
+ "Description can't be longer than %s characters but was %s",
MAX_DESC_LENGTH, description.length());
checkArgument(DESCRIPTION_ACCEPTABLE_RANGE.matchesAllOf(description),
"Description should have ASCII values between 32 and 126.");
diff --git a/glacier/src/main/java/org/jclouds/glacier/predicates/validators/PayloadValidator.java b/glacier/src/main/java/org/jclouds/glacier/predicates/validators/PayloadValidator.java
index dcb2900..93eb42d 100644
--- a/glacier/src/main/java/org/jclouds/glacier/predicates/validators/PayloadValidator.java
+++ b/glacier/src/main/java/org/jclouds/glacier/predicates/validators/PayloadValidator.java
@@ -37,6 +37,6 @@
checkNotNull(payload, "Archive must have a payload.");
checkNotNull(payload.getContentMetadata().getContentLength(), "Content length must be set.");
checkArgument(payload.getContentMetadata().getContentLength() <= MAX_CONTENT_SIZE,
- "Max content size is 4gb but was %d", payload.getContentMetadata().getContentLength());
+ "Max content size is 4gb but was %s", payload.getContentMetadata().getContentLength());
}
}
diff --git a/glacier/src/main/java/org/jclouds/glacier/predicates/validators/VaultNameValidator.java b/glacier/src/main/java/org/jclouds/glacier/predicates/validators/VaultNameValidator.java
index fd99e02..257b9b7 100644
--- a/glacier/src/main/java/org/jclouds/glacier/predicates/validators/VaultNameValidator.java
+++ b/glacier/src/main/java/org/jclouds/glacier/predicates/validators/VaultNameValidator.java
@@ -43,7 +43,7 @@
@Override
public void validate(String vaultName) {
checkArgument(!isNullOrEmpty(vaultName) && vaultName.length() <= MAX_LENGTH,
- "Can't be null or empty. Length must be %d to %d symbols.", MIN_LENGTH, MAX_LENGTH);
+ "Can't be null or empty. Length must be %s to %s symbols.", MIN_LENGTH, MAX_LENGTH);
checkArgument(VAULT_NAME_ACCEPTABLE_RANGE.matchesAllOf(vaultName),
"Should contain only ASCII letters and numbers, underscores, hyphens, or periods.");
}
diff --git a/rds/src/main/java/org/jclouds/rds/domain/InstanceRequest.java b/rds/src/main/java/org/jclouds/rds/domain/InstanceRequest.java
index 13267e5..da9513d 100644
--- a/rds/src/main/java/org/jclouds/rds/domain/InstanceRequest.java
+++ b/rds/src/main/java/org/jclouds/rds/domain/InstanceRequest.java
@@ -200,7 +200,7 @@
this.autoMinorVersionUpgrade = autoMinorVersionUpgrade;
this.port = checkNotNull(port, "port");
this.characterSet = checkNotNull(characterSet, "characterSet");
- this.backupRetentionPeriod = checkNotNull(backupRetentionPeriod, "backupRetentionPeriod");
+ this.backupRetentionPeriod = backupRetentionPeriod;
this.subnetGroup = checkNotNull(subnetGroup, "subnetGroup");
this.securityGroups = ImmutableSet.copyOf(checkNotNull(securityGroups, "securityGroups"));
this.masterPassword = checkNotNull(masterPassword, "masterPassword");
